Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d86G7-0000Rm-JR for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 14:37:03 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d86G7-00067x-2g for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 14:37:03 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d86G6-00067n-Fe for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 14:37:02 +0000 Received: from mail-wr0-x22a.google.com ([2a00:1450:400c:c0c::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d86G2-00068w-Se for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 14:37:01 +0000 Received: by mail-wr0-x22a.google.com with SMTP id l9so1795719wre.1 for ; Tue, 09 May 2017 07:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=cVsijo+KXSU+XytUJX1dWXH6XVN2CwJMJJgGXW9lfMY=; b=qAg8+oF7dbp0ioXbtB5h1NPyZo3chiJtrinCxvMtF+tmgdOaSWjmvZ2AeYg4LdwsFi i0J5YuF7hrGmB2GRmDsEjr+kYPIpylbzjvJWw3O52b6RFn8lksBGR6kuBQ1j6iA981DN QPpreTYAJLoOxmcNJZ9nPGpn9VaQUzAVW+3cCdUKnDnmoNe24j3hb1Swg5V6pCaC5HNp ksE+YpPUiu4jpdxejwtby5G/OjnxT69Jq8bbp8DkHLpXct3GhkY/kC5yoYDFixASYzbQ omqb/bIJJ4g+6dttdBvL8/t9rItOjJ6kV857Y5YO9k/1XZzJCLBf9tN6kSCnbRvzpsjW 7zNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=cVsijo+KXSU+XytUJX1dWXH6XVN2CwJMJJgGXW9lfMY=; b=WdQrLwHKnYjAZiK8WJ8CM364u6tmNN2YIiiKc2rCFzkiq70IWwBj46KSc+dViZnLqO jaJMVpImjgNttKixXo0Dl45x/snUeFScfC7HNbbn1MOIgdnwEclPUrsZ2AjZxvsCZ0B/ 0jvHZ+tO0y9lpRODTnKCLSq6eCU35leBo4L2SGE/+xEnd7Ys9hXfz7f8waCOiuYP9VLB bOYBwAT3JhhmffI9OF0bfAIct8E4/F7Ae3ahzivZsn8n0+DWKhhx6MgGEtqw0NKhC7S7 y7XOrkMd2LjAuiS1ocxHsjZ5UEBeSimxiP/pCgKEYAmPPa0hDSK28uVAGPWOXlx7S+PB wTZg== X-Gm-Message-State: AODbwcAIwjYymQUYLewUQuEEoGcFdMJ+KtYK49m+YJL0Pdt7Qfv30DyG TvgSXvQx/+apL1L7Uba/rsrwg+fRgqbL X-Received: by 10.28.107.77 with SMTP id g74mr380013wmc.58.1494340615429; Tue, 09 May 2017 07:36:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.136.70 with HTTP; Tue, 9 May 2017 07:36:34 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Tue, 9 May 2017 20:06:34 +0530 Message-ID: Subject: Re: [pgAdmin4][PATCH] To fix the of issue in table node To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a11468d9a8eeaca054f184937 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11468d9a8eeaca054f184937 Content-Type: multipart/alternative; boundary=001a11468d9a8eeac6054f184935 --001a11468d9a8eeac6054f184935 Content-Type: text/plain; charset=UTF-8 Hi, Please find updated patch. Updated logic to convert name only if name is of type int/long/float (Python2) or of type int/float (Python3) instead of blindly convert it to string. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 9, 2017 at 7:06 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue in table node where it fails to create > table when user provides numeric table name eg: 123. > RM#2284 > > Issue is when use json.loads() it converts string "123" into integer 123. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a11468d9a8eeac6054f184935 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Please find updated patch.

Updated logic to convert name only if name is of type int/= long/float (Python2) or of type int/float (Python3) instead of blindly conv= ert it to string.

<= div>
--
Regards,Mur= tuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
= The Enterprise PostgreSQL Company

On Tue, May 9, 2017 at 7:06 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> = wrote:
Hi,

PFA minor patch to fix the issue in table node where it fails to crea= te table when user provides numeric table name eg: 123.
RM#2284

Issue is when use=C2=A0json.loads() it converts str= ing "123" into integer 123.

= --
Regards,
Murtuza Zabuawala=
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a11468d9a8eeac6054f184935-- --001a11468d9a8eeaca054f184937 Content-Type: text/plain; charset=US-ASCII; name="RM_2284_v1.diff" Content-Disposition: attachment; filename="RM_2284_v1.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j2hnsi291 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9fX2luaXRfXy5w eSBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJz L2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9fX2luaXRfXy5weQppbmRleCBl MTE4Y2FiLi5iNmJmN2VkIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90 YWJsZXMvX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVz L19faW5pdF9fLnB5CkBAIC0xMzc2LDYgKzEzNzYsMjggQEAgY2xhc3MgVGFi bGVWaWV3KFBHQ2hpbGROb2RlVmlldywgRGF0YVR5cGVSZWFkZXIsIFZhY3V1 bVNldHRpbmdzKToKIAogICAgICAgICByZXR1cm4gZGF0YQogCisgICAgZGVm IGNoZWNrX2FuZF9jb252ZXJ0X25hbWVfdG9fc3RyaW5nKHNlbGYsIGRhdGEp OgorICAgICAgICAiIiIKKyAgICAgICAgVGhpcyBmdW5jdGlvbiB3aWxsIGNo ZWNrIGFuZCBjb3ZlcnQgdGFibGUgdG8gc3RyaW5nIGluY2FzZQorICAgICAg ICBpdCBpcyBudW1lcmljCisKKyAgICAgICAgQXJnczoKKyAgICAgICAgICAg IGRhdGE6IGRhdGEgZGljdAorCisgICAgICAgIFJldHVybnM6CisgICAgICAg ICAgICBVcGRhdGVkIGRhdGEgZGljdAorICAgICAgICAiIiIKKyAgICAgICAg IyBGb3IgUHl0aG9uMiwgaXQgY2FuIGJlIGludCwgbG9uZywgZmxvYXQKKyAg ICAgICAgaWYgaGFzYXR0cihzdHIsICdkZWNvZGUnKToKKyAgICAgICAgICAg IGlmIGlzaW5zdGFuY2UoZGF0YVsnbmFtZSddLCAoaW50LCBsb25nLCBmbG9h dCkpOgorICAgICAgICAgICAgICAgIGRhdGFbJ25hbWUnXSA9IHN0cihkYXRh WyduYW1lJ10pCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICAjIEZvciBQ eXRob24zLCBpdCBjYW4gYmUgaW50LCBmbG9hdAorICAgICAgICAgICAgaWYg aXNpbnN0YW5jZShkYXRhWyduYW1lJ10sIChpbnQsIGZsb2F0KSk6CisgICAg ICAgICAgICAgICAgZGF0YVsnbmFtZSddID0gc3RyKGRhdGFbJ25hbWUnXSkK KyAgICAgICAgcmV0dXJuIGRhdGEKKworCiAgICAgQGNoZWNrX3ByZWNvbmRp dGlvbgogICAgIGRlZiBjcmVhdGUoc2VsZiwgZ2lkLCBzaWQsIGRpZCwgc2Np ZCk6CiAgICAgICAgICIiIgpAQCAtMTQxNyw2ICsxNDM5LDcgQEAgY2xhc3Mg VGFibGVWaWV3KFBHQ2hpbGROb2RlVmlldywgRGF0YVR5cGVSZWFkZXIsIFZh Y3V1bVNldHRpbmdzKToKIAogICAgICAgICAjIFBhcnNlICYgZm9ybWF0IGNv bHVtbnMKICAgICAgICAgZGF0YSA9IHNlbGYuX3BhcnNlX2Zvcm1hdF9jb2x1 bW5zKGRhdGEpCisgICAgICAgIGRhdGEgPSBzZWxmLmNoZWNrX2FuZF9jb252 ZXJ0X25hbWVfdG9fc3RyaW5nKGRhdGEpCiAKICAgICAgICAgIyAnY29sbF9p bmhlcml0cycgaXMgQXJyYXkgYnV0IGl0IGNvbWVzIGFzIHN0cmluZyBmcm9t IGJyb3dzZXIKICAgICAgICAgIyBXZSB3aWxsIGNvbnZlcnQgaXQgYWdhaW4g dG8gbGlzdApAQCAtMTQ0Nyw4ICsxNDcwLDEwIEBAIGNsYXNzIFRhYmxlVmll dyhQR0NoaWxkTm9kZVZpZXcsIERhdGFUeXBlUmVhZGVyLCBWYWN1dW1TZXR0 aW5ncyk6CiAgICAgICAgICAgICAgICAgcmV0dXJuIGludGVybmFsX3NlcnZl cl9lcnJvcihlcnJvcm1zZz1yZXMpCiAKICAgICAgICAgICAgICMgUG9zdGdy ZVNRTCB0cnVuY2F0ZXMgdGhlIHRhYmxlIG5hbWUgdG8gNjMgY2hhcmFjdGVy cy4KLSAgICAgICAgICAgICMgSGF2ZSB0byB0cnVuY2F0ZSB0aGUgbmFtZSBs aWtlIFBvc3RncmVTUUwgdG8gZ2V0IHRoZSBwcm9wZXIgc2NoZW1hIGlkCisg ICAgICAgICAgICAjIEhhdmUgdG8gdHJ1bmNhdGUgdGhlIG5hbWUgbGlrZSBQ b3N0Z3JlU1FMIHRvIGdldCB0aGUKKyAgICAgICAgICAgICMgcHJvcGVyIE9J RAogICAgICAgICAgICAgQ09OU1RfTUFYX0NIQVJfQ09VTlQgPSA2MworCiAg ICAgICAgICAgICBpZiBsZW4oZGF0YVsnbmFtZSddKSA+IENPTlNUX01BWF9D SEFSX0NPVU5UOgogICAgICAgICAgICAgICAgIGRhdGFbJ25hbWUnXSA9IGRh dGFbJ25hbWUnXVswOkNPTlNUX01BWF9DSEFSX0NPVU5UXQogCkBAIC0yMTI5 LDkgKzIxNTQsMTIgQEAgY2xhc3MgVGFibGVWaWV3KFBHQ2hpbGROb2RlVmll dywgRGF0YVR5cGVSZWFkZXIsIFZhY3V1bVNldHRpbmdzKToKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBkYXRhWydyZWxhY2wnXVttb2RlXSwgc2Vs Zi5hY2wKICAgICAgICAgICAgICAgICAgICAgICAgICkKIAotICAgICAgICAg ICAgIyBJZiBuYW1lIGlmIG5vdCBwcmVzZW50CisgICAgICAgICAgICAjIElm IG5hbWUgaXMgbm90IHByZXNlbnQgaW4gcmVxdWVzdCBkYXRhCiAgICAgICAg ICAgICBpZiAnbmFtZScgbm90IGluIGRhdGE6CiAgICAgICAgICAgICAgICAg ZGF0YVsnbmFtZSddID0gb2xkX2RhdGFbJ25hbWUnXQorCisgICAgICAgICAg ICBkYXRhID0gc2VsZi5jaGVja19hbmRfY29udmVydF9uYW1lX3RvX3N0cmlu ZyhkYXRhKQorCiAgICAgICAgICAgICAjIElmIG5hbWUgaWYgbm90IHByZXNl bnQKICAgICAgICAgICAgIGlmICdzY2hlbWEnIG5vdCBpbiBkYXRhOgogICAg ICAgICAgICAgICAgIGRhdGFbJ3NjaGVtYSddID0gb2xkX2RhdGFbJ3NjaGVt YSddCkBAIC0yMzEwLDYgKzIzMzgsNyBAQCBjbGFzcyBUYWJsZVZpZXcoUEdD aGlsZE5vZGVWaWV3LCBEYXRhVHlwZVJlYWRlciwgVmFjdXVtU2V0dGluZ3Mp OgogCiAgICAgICAgICAgICAjIFBhcnNlICYgZm9ybWF0IGNvbHVtbnMKICAg ICAgICAgICAgIGRhdGEgPSBzZWxmLl9wYXJzZV9mb3JtYXRfY29sdW1ucyhk YXRhKQorICAgICAgICAgICAgZGF0YSA9IHNlbGYuY2hlY2tfYW5kX2NvbnZl cnRfbmFtZV90b19zdHJpbmcoZGF0YSkKIAogICAgICAgICAgICAgaWYgJ2Zv cmVpZ25fa2V5JyBpbiBkYXRhOgogICAgICAgICAgICAgICAgIGZvciBjIGlu IGRhdGFbJ2ZvcmVpZ25fa2V5J106Cg== --001a11468d9a8eeaca054f184937 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a11468d9a8eeaca054f184937--