Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyxqt-0006e0-Gd for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 10:53:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyxqr-0003l1-QN for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 10:53:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyxqr-0003kr-Jq for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 10:53:45 +0000 Received: from mail-ot0-x236.google.com ([2607:f8b0:4003:c0f::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyxqm-0003Rn-Is for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 10:53:44 +0000 Received: by mail-ot0-x236.google.com with SMTP id i28-v6so8933684otf.8 for ; Thu, 22 Mar 2018 03:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6j5iPgf6t98KPUfmElI3+8ntrn3JE3wJWJUlR036EPs=; b=G+FAK8wPc4pJ1Fe6BBNCJdWCKk0lhNsf4POsxSfsacdrn24j6ryq7xZnYw5ad3Ae3n uoLgyM8VUDx2Kc4G6/wBNJvWPZloAMdqw2++jLY2XMNzlAsi/DrcsozUxVz4hNwD+Lhm 8fyQkoTEarTR0ctE9aggGAR+wBl7JU2K9W0j4+MaqIZ8NEuoVxbo/aBQN1nxyE+kc3Pw X42LZ2ENfs6A1+d86p2zwCPuQFmOj+/92RzEYOYGMxEOJBtBMv0oYDlh3vOpLOYRQKUz MoLZxbyUChSJHa5h6RYXqpBxvjg6seEZsRj4GShMAnf4iGMKx2mp+Rbj41YFwLO0KvjF vsjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6j5iPgf6t98KPUfmElI3+8ntrn3JE3wJWJUlR036EPs=; b=B2Q5w5Olaz2adpOdKnhWGHYEO65DdgF3Ke8PDQUbIfj7pxsDNiGHsGKuy2WeRiX8dL QSfcMREsOctgaM7td+IfYOJ6gWo+F2pdfjlhP6dmCRSF8Ngz7wXhO6btcpJcZR1GaWmp 7K0/Vrkiu/1JVfCMlZ3CmSueaejNQZz3C3iv4RBciwG7bUQyIi3M6X5vRnT8rdFjzmSg dmp/zYknnvP3uQ4ZG6UsUayRL3V8dvPdRUto2blkmhdLafgDqn35+0iSB6NuK6jGtJJ8 KIU98PILdCOAI4ZmR9StazJga8AyPbs1oL88/Awhv+D5dC5QJjJqufqSdhQxM4fMuz1b wnTg== X-Gm-Message-State: AElRT7GIu9HNgAEBNyI9ZpoEuxB11W3em9BzqUadoiwM7QSz1k87q5k/ j/upOh1YQXNWPUX0K+SSVmhMjMyN2VBFDKkeqhZxgA== X-Google-Smtp-Source: AIpwx48p8Qw+9nzKjubKzWxyH/avzty3QW+eRPyTu7GewHS4eDgwXn4E42clrc9AZ+tKlJNHPiX2QQZJPuADr/W7SHw= X-Received: by 2002:a9d:4811:: with SMTP id c17-v6mr941298otf.291.1521716018320; Thu, 22 Mar 2018 03:53:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.149.198 with HTTP; Thu, 22 Mar 2018 03:53:17 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Thu, 22 Mar 2018 16:23:17 +0530 Message-ID: Subject: Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: Rahul Soshte Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b8b1220567fe1e38" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b8b1220567fe1e38 Content-Type: text/plain; charset="UTF-8" Have you configured your local test configuration file ../pgadmin4/web/regression/test_config.json.in , Make a copy of it as ../pgadmin4/web/regression/test_config.json and update it as per your environment to run tests. On Thu, Mar 22, 2018 at 4:18 PM, Rahul Soshte wrote: > Although I have postgresql-9.6 it is showing-Running the test cases for > 'PostgreSQL 9.4' > > > On Thu, Mar 22, 2018 at 4:17 PM, Rahul Soshte > wrote: > >> Although I have postgresql-9.6 it is showing >> -- >> -- >> Running the test cases for 'PostgreSQL 9.4' >> >> On Thu, Mar 22, 2018 at 4:01 PM, Rahul Soshte >> wrote: >> >>> >>> ---------- Forwarded message ---------- >>> From: Rahul Soshte >>> Date: Thu, Mar 22, 2018 at 4:01 PM >>> Subject: Re: Little patch for Runtime build from Top Level >>> Directory($PGADMIN_SRC) MakeFile >>> To: Murtuza Zabuawala >>> >>> >>> I am still getting the same error even when I did SERVER_MODE = False. >>> >>> On Thu, Mar 22, 2018 at 3:05 PM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> You need to make SERVER_MODE = False in config_local.py in order to >>>> run feature tests. >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> On Thu, Mar 22, 2018 at 3:00 PM, Rahul Soshte >>> > wrote: >>>> >>>>> how do I resolve those errors in step 4 of the checklist? >>>>> >>>>> >>>>> On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte < >>>>> rahulsoshte360@gmail.com> wrote: >>>>> >>>>>> This is my first time trying to make a Patch. >>>>>> >>>>>> I am using Ubuntu 17.10. >>>>>> >>>>>> This patch is in reference to the Feature Added by Dave Page >>>>>> https://redmine.postgresql.org/issues/1305 >>>>>> >>>>>> I just added code to call makefile in runtime directory( >>>>>> $PGADMIN_SRC/runtime/Makefile ) from the top level directory's MakeFile ( >>>>>> $PGADMIN_SRC/Makefile ) >>>>>> >>>>>> >>>>>> I followed the checklist for submitting a patch sent by Murutuza >>>>>> Zabuawala >>>>>> >>>>>> <================================> >>>>>> Hello, >>>>>> >>>>>> Here is the common checklist to follow before sending patch to >>>>>> pgAdmin4-hackers group, >>>>>> >>>>>> 1) Get the latest pull from master branch. >>>>>> >>>>>> 2) Apply your patch and check if applies successfully on the latest >>>>>> code. >>>>>> >>>>>> 3) Check for PEP8 issues >>>>>> - activate virtual env >>>>>> - cd ../web >>>>>> - yarn run pep8 >>>>>> >>>>>> 4) Run regression test >>>>>> python regression/runtests.py >>>>>> >>>>>> - To run only UI/feature tests >>>>>> python regression/runtests.py --pkg feature_tests >>>>>> >>>>>> - To run regression test (without UI/Feature tests) >>>>>> python regression/runtests.py --exclude feature_tests >>>>>> >>>>>> 5) Run Jasmine tests >>>>>> - activate virtual env >>>>>> - cd ../web >>>>>> yarn run test:karma-once >>>>>> >>>>>> 6) Make sure to add or update help docs and screenshot(s) if you have >>>>>> added any new feature or changed any existing one. >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> <===================================================> >>>>>> >>>>>> But I am facing some issues, >>>>>> Step 1,2,3 and 5 had no issues >>>>>> But when I tried step 4 it gave some errors >>>>>> I executed the following command >>>>>> >>>>>> *python regression/runtests.py * >>>>>> >>>>>> I got the following errors: >>>>>> 1)The screenshot attached show I wasnt able to connect to the server >>>>>> 2) the error ouput on the command line: >>>>>> =============Running the test cases for 'PostgreSQL 9.4'============= >>>>>> Traceback (most recent call last): >>>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>>> line 128, in create_database >>>>>> server['sslmode'] >>>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>>> line 36, in get_db_connection >>>>>> sslmode=sslmode >>>>>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>>>>> line 130, in connect >>>>>> conn = _connect(dsn, connection_factory=connection_factory, >>>>>> **kwasync) >>>>>> OperationalError: FATAL: password authentication failed for user >>>>>> "postgres" >>>>>> FATAL: password authentication failed for user "postgres" >>>>>> >>>>>> Traceback (most recent call last): >>>>>> File "regression/runtests.py", line 350, in >>>>>> server_information = test_utils.create_parent_server_node(server) >>>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>>> line 491, in create_parent_server_node >>>>>> server_info['sslmode'] >>>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>>> line 36, in get_db_connection >>>>>> sslmode=sslmode >>>>>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>>>>> line 130, in connect >>>>>> conn = _connect(dsn, connection_factory=connection_factory, >>>>>> **kwasync) >>>>>> psycopg2.OperationalError: FATAL: password authentication failed for >>>>>> user "postgres" >>>>>> FATAL: password authentication failed for user "postgres" >>>>>> >>>>>> Traceback (most recent call last): >>>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>>> line 619, in _cleanup >>>>>> connection = get_db_server(database["server_id"]) >>>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>>> line 593, in get_db_server >>>>>> db_name, username, db_password, host, db_port, ssl_mode >>>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>>> line 36, in get_db_connection >>>>>> sslmode=sslmode >>>>>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>>>>> line 130, in connect >>>>>> conn = _connect(dsn, connection_factory=connection_factory, >>>>>> **kwasync) >>>>>> OperationalError: FATAL: password authentication failed for user >>>>>> "postgres" >>>>>> FATAL: password authentication failed for user "postgres" >>>>>> >>>>>> I have no password authentication errors when I am connecting from >>>>>> the application.I had also changed password for postgres manually through >>>>>> the command line. >>>>>> >>>>> >>>>> >>>> >>> >>> >> > --000000000000b8b1220567fe1e38 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Have you configured your local test configu= ration file=C2=A0../pgadm= in4/web/regression/test_config.json.= in ,=C2=A0Make a copy of it as=C2=A0../pgadmin4/web/regression/test_config.json=C2=A0and update it a= s per your environment to run tests.

On Thu, Mar 22, 2018 at 4:18 = PM, Rahul Soshte <rahulsoshte360@gmail.com> wrote:
Al= though I have postgresql-9.6 it is showing-Running the test cases for 'PostgreSQL 9.4'


On Thu, Mar 22, 2018 at 4:17 PM, Rahul Soshte <rah= ulsoshte360@gmail.com> wrote:
Although I have postgresql-9.6 it is= showing
--
--
Running the test cases for 'PostgreSQL 9.= 4'

On Thu, Mar 22, 2018 at 4:01 PM, Rahul Soshte <rahulsoshte360@gmail.com> wrote:

---------= - Forwarded message ----------
From: Rahul= Soshte <rahulsoshte360@gmail.com>
Date: Thu, = Mar 22, 2018 at 4:01 PM
Subject: Re: Little patch for Runtime build from= Top Level Directory($PGADMIN_SRC) MakeFile
To: Murtuza Zabuawala <murtu= za.zabuawala@enterprisedb.com>


I am= still getting the same error even when I did SERVER_MODE =3D False.

On Thu, Mar 22, 2018 at 3:05 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
You need to mak= e SERVER_MODE =3D False <= /span>in config_local.py in order to run feature tests.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http= ://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Mar 22, 2018 at 3:00 PM, Rahul Sosht= e <rahulsoshte360@gmail.com> wrote:
how do I resolve thos= e errors in step 4 of the checklist?


On Thu, Mar 22, 2018 at 2:58 PM, Rahul Sos= hte <rahulsoshte360@gmail.com> wrote:
= This is my first time trying to make a Patch.

I am using Ubunt= u 17.10.

This patch is in reference to the Feature Added by Dave Pag= e
https://redmine.postgresql.org/issues/1305

I just= added code to call makefile in runtime directory( $PGADMIN_SRC/runtime/Mak= efile ) from the top level directory's MakeFile=C2=A0 ( $PGADMIN_SRC/Ma= kefile )


I followed the checklist for submitting a p= atch sent by Murutuza Zabuawala

<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>
He= llo,

Here is the common checklist to follow= before sending patch to pgAdmin4-hackers group,

1) Get the latest pull from m= aster branch.

2) Apply your patch and check if applies successfully on the lat= est code.

3) Check for PEP8 issues
- activate virtual env
- cd ../web
- yarn run pep8

4) Run regression test
python regre= ssion/runtests.py=C2=A0

- To run only UI/fea= ture tests
= python regression/runtests.py --pkg feature_tests=C2=A0

- To run regression test (without UI/Feature = tests)
python regression/runt= ests.py --exclude feature_tests=C2=A0

5) Run Jasmine tests
- activate virtual env
<= div style=3D"font-size:small;font-style:normal;font-variant-ligatures:norma= l;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align= :start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:= 0px;text-decoration-style:initial;text-decoration-color:initial;font-family= :verdana,sans-serif;color:rgb(68,68,68)">- cd ../web
yarn run=C2=A0test:karma-once=

6) Make sure to add or update help docs and screensho= t(s) if you have added any new=C2=A0feature=C2= =A0or changed any existing one.

= --Regards,=
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterpris= edb.com
The Enterprise PostgreSQL Company
<= /div>
<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D>

But I am faci= ng some issues,
Step 1,2,3 and 5 had no issues
= But when I tried step 4 it gave some errors
I executed the fo= llowing command
=C2=A0
python regression/runtests.py=C2=A0

I got the following errors:
1)The screenshot attached show= I wasnt able to connect to the server
2) the error ouput on = the command line:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the tes= t cases for 'PostgreSQL 9.4'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
Traceback (most recent call last):
=C2=A0 File "/var/www/flask/= pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py&= quot;, line 128, in create_database
=C2=A0=C2=A0=C2=A0 server['sslmo= de']
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/reg= ression/python_test_utils/test_utils.py", line 36, in get_db_conn= ection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2=A0 File "/var/ww= w/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__ini= t__.py", line 130, in connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(= dsn, connection_factory=3Dconnection_factory, **kwasync)
Operationa= lError: FATAL:=C2=A0 password authentication failed for user "postgres= "
FATAL:=C2=A0 password authentication failed for user "postgr= es"

Traceback (most recent call last):
=C2=A0 File "reg= ression/runtests.py", line 350, in <module>
=C2=A0=C2=A0=C2= =A0 server_information =3D test_utils.create_parent_server_node(server= )
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regression= /python_test_utils/test_utils.py", line 491, in create_parent_ser= ver_node
=C2=A0=C2=A0=C2=A0 server_info['sslmode']
=C2=A0 Fil= e "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", line 36, in get_db_connection
=C2=A0=C2=A0= =C2=A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/flask/pgadmin4/local= /lib/python2.7/site-packages/psycopg2/__init__.py", line 130= , in connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_factor= y=3Dconnection_factory, **kwasync)
psycopg2.OperationalError: FATAL= :=C2=A0 password authentication failed for user "postgres"
FAT= AL:=C2=A0 password authentication failed for user "postgres"
<= br>Traceback (most recent call last):
=C2=A0 File "/var/www/flask/p= gadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py&q= uot;, line 619, in _cleanup
=C2=A0=C2=A0=C2=A0 connection =3D get_db_ser= ver(database["server_id"])
=C2=A0 File "/var/www/fla= sk/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.= py", line 593, in get_db_server
=C2=A0=C2=A0=C2=A0 db_name, usernam= e, db_password, host, db_port, ssl_mode
=C2=A0 File "/var/www/flask= /pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py= ", line 36, in get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmo= de
=C2=A0 File "/var/www/flask/pgadmin4/local/lib/python2.7/si= te-packages/psycopg2/__init__.py", line 130, in connect
=C2=A0= =C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory=3Dconnection_fa= ctory, **kwasync)
OperationalError: FATAL:=C2=A0 password authentication= failed for user "postgres"
FATAL:=C2=A0 password authenticati= on failed for user "postgres"

I have no passwor= d authentication errors when I am connecting from the application.I had als= o changed password for postgres manually through the command line.







--000000000000b8b1220567fe1e38--