public inbox for [email protected]  
help / color / mirror / Atom feed
From: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: PATCH: To fix the issue in Packages node (pgAdmin4)
Date: Mon, 19 Sep 2016 12:50:20 +0530
Message-ID: <CAKKotZT3fn=ybhg0KjTLBPNWJxUVNtQE1VmDBbtSVPjneU8PXA@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

PFA minor patch to fix the issue in Packages node where after updating any
package user was getting 'Not Found' error.
RM#1625

*Issue:*
It was due to wrong parent was provided while sending the node to client.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] RM_1625.patch (1.0K, 3-RM_1625.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py
index 77482a9..dfbae1e 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/__init__.py
@@ -226,7 +226,7 @@ class PackageView(PGChildNodeView):
             return make_json_response(
                 data=self.blueprint.generate_browser_node(
                     row['oid'],
-                    sid,
+                    scid,
                     row['name'],
                     icon="icon-%s" % self.node_type
                 )
@@ -236,7 +236,7 @@ class PackageView(PGChildNodeView):
             res.append(
                 self.blueprint.generate_browser_node(
                     row['oid'],
-                    sid,
+                    scid,
                     row['name'],
                     icon="icon-%s" % self.node_type
                 ))


view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: PATCH: To fix the issue in Packages node (pgAdmin4)
  In-Reply-To: <CAKKotZT3fn=ybhg0KjTLBPNWJxUVNtQE1VmDBbtSVPjneU8PXA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox