Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ew0gx-0004bc-5w for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 07:19:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ew0gv-0004A6-Ob for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 07:19:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ew0gv-00049w-Ix for pgadmin-hackers@lists.postgresql.org; Wed, 14 Mar 2018 07:19:17 +0000 Received: from mail-oi0-x236.google.com ([2607:f8b0:4003:c06::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ew0gq-0002yq-UB for pgadmin-hackers@postgresql.org; Wed, 14 Mar 2018 07:19:16 +0000 Received: by mail-oi0-x236.google.com with SMTP id x10so1900722oig.2 for ; Wed, 14 Mar 2018 00:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=f7CC958kpAYBm101036rhl1djASl0rukrH4x9DSt/+U=; b=P+o31MtS4ijPbMKcMVxcm+UQDvK/J7Pk20Ks3f9lZrXpiJatlyfNrY603wV5eFOSKa lyvae2XJ8EQL3tP7xCoNI6fccwCJdripMJb8R+4NbeyOtTcKqruuLbfOXi7X0eVBuu4d Xpd9kJ/JzcS6/IsZIYQ7hNqjJYGv5nmBW0omaaGsBBecsk2YI94EzH8ml7g34/l3vRv5 yA+M3jMJbGw3UaW2U2/mLC9eURUYxRWwWz1QesSiR940f+nnjjvfpgcgCAqK+po6A6Xp gYhSwuG6VUh3bjV8hM3u9nm25isZ7fy6qDNKwvN41yd++En0PFf8vfZfXvEQT0Y7VyXl phOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=f7CC958kpAYBm101036rhl1djASl0rukrH4x9DSt/+U=; b=edG0izcz5Coi7q491mfi4NDInN1eVthuhPr55wQNK4ZuO8ieOLdmIUVJ5UyHR80h1A 23zj6IGp6PHT0Kl5nFeZLcI9VsJMhQKO0oA6UYK736LdQbCfnKD0r1p3X3m1vG58GCqh k8jstemEuPT6pDItHPxcOwgfLVm2w6XPfyfJxMAkcHXXFkt9nClEcZoM2Ay45O4NmlER IHJsTtJLI8AlOGFemERwayZmivcHTfyGIO64dk2+fKcksuE+4skKMejXX/VaFYk/T0Pi zl4U8PzKm4kP7Hqrea/3nE4/PCBGJuybD4D+Ku9e70sOU9TDGirbuWhedH7ogF2wrE0k 3fag== X-Gm-Message-State: AElRT7EV2mziny7J++D5kpFE7FG6vZxr4XJX8ewHkmJRBderOV8M/rdo 0DSYfKxnBLwqhvyL6HcT7g3DYIWfHA+ZkpF/3sIiKTav X-Google-Smtp-Source: AG47ELtEgSTieevZ6OJv013aM0XAaRiME/GdEJK806JVqpSWpDyv5iVV1rYIrCewwxVrRb0hnK0cJ/G1032SLm+XKZk= X-Received: by 10.202.77.22 with SMTP id a22mr2217894oib.61.1521011950134; Wed, 14 Mar 2018 00:19:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Wed, 14 Mar 2018 00:18:49 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Wed, 14 Mar 2018 12:48:49 +0530 Message-ID: Subject: Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a11c1704cfce19205675a3099" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a11c1704cfce19205675a3099 Content-Type: text/plain; charset="UTF-8" ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without your patch applied. On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Khushboo, > > We can simplify this, we don't need to create any extra column, > > Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322 where > we are setting ENV variable we can create common utility function (let say > in ../tools/utils/__init__.py) which will set all required the environment > variables and then we will pass that function in p.start(..) method. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Wed, Mar 14, 2018 at 11:03 AM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix RM #3122 : Backup not working on >> certificate (SSL) protected servers. >> >> The attached patch fixes the issue in the following modules: >> >> 1. Backup >> 2. Restore >> 3. Import/Export >> 4. Maintenance >> >> Thanks, >> Khushboo >> >> >> > --001a11c1704cfce19205675a3099 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=C2=A0../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310=C2=A0without your patch applied.


On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Khushboo,

We can simplif= y this, we don't need to create any extra column,

Check: ../pgadmin4/web/pgadmin/tools/import_= export/__init__.py +322 where we are setting ENV variable we can cre= ate common utility function (let say in ../tools/utils/__init__.py) which w= ill set all required the environment variables and then we will pass that f= unction in p.start(..) method.


<= div dir=3D"ltr">
--=
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.= enterprisedb.com
The Enterprise PostgreSQL Company

<= /div>

On Wed, Mar 14, 2018 at 11:03 AM, Khushboo V= ashi <khushboo.vashi@enterprisedb.com> wr= ote:
Hi,

<= div>Please find the attached patch to fix RM #3122 :=C2=A0Backup not workin= g on certificate (SSL) protected servers.

The atta= ched patch fixes the issue in the following modules:

1. Backup
2. Restore
3. Import/Export
4. M= aintenance

Thanks,
Khushboo



--001a11c1704cfce19205675a3099--