Re: PATCH: Added Node Type & Catalog objects [pgAdmin4]

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: Added Node Type & Catalog objects [pgAdmin4]
Date: Fri, 18 Mar 2016 12:56:41 +0530
Message-ID: <CAKKotZT5b2ykhq5TKuddEWULTXZaLqRog76vC0KGeyQD0Tb9QA@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZSrb=YrxbaasHQF9DXA-roFmzmA7cVC3tVPMdhYwL58cw@mail.gmail.com>
References: <CAKKotZSda6+wgyzckDJPXKK3dc8U-UXho9hmaaBp+LwZzdnhaQ@mail.gmail.com>
	<CA+OCxoxNx3ghQZ+YnWeNpyVs_BaJE+yL7C6H-PUFh6ddpr061Q@mail.gmail.com>
	<CA+OCxozEyaxygwg4KKNWKjKcLw=a-s6R64Tij9Z2JSVzzEKLrg@mail.gmail.com>
	<CAKKotZTGn2aUnkrotK5u=9hh+nD4gUC9mvKWo2FcDVuEhH5oyA@mail.gmail.com>
	<CA+OCxoyeSbbyKFm236agok7DNr4iRt16On9Kea+Z3tUj_iXa_g@mail.gmail.com>
	<CAKKotZQVJPRkHKzhix+s9zc+QnwUfWfOj+sVFfk6c7abKuyECg@mail.gmail.com>
	<CA+OCxowYVt2V-sr5YQm-YDxhmNiam-4iSudNSmydu_e2_T3eMA@mail.gmail.com>
	<CAKKotZSrb=YrxbaasHQF9DXA-roFmzmA7cVC3tVPMdhYwL58cw@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

Compressed everything in Zip file and sending it again, Because got below
email for my last sent email.






*"Your message to pgadmin-hackers has been delayed, and requires the
approvalof the moderators, for the following reason(s):The message body is
too long (481753 > 204800)"*

*Hi Dave,*

*Even after installing PosGIS I’m not able to create new custom external
type because the SQL does not return any value (Same behaviour as is in
pgAdmin3) , But I’m able to list all of it’s properties of external types
same as pgAdmin3 (PFA screenshots).*

*I have also attached patch for plain fields control (without lable &
border) for backform. (Please apply it before testing new type patch)*

*Thanks,*

*--*
*Regards,*


*Murtuza ZabuawalaEnterpriseDB: http://www.enterprisedb.com
<http://www.enterprisedb.com/>The Enterprise PostgreSQL Company*

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Mar 18, 2016 at 12:45 PM, Murtuza Zabuawala <
[email protected]> wrote:

> Hi Dave,
>
> Even after installing PosGIS I’m not able to create new custom external
> type because the SQL does not return any value (Same behaviour as is in
> pgAdmin3) , But I’m able to list all of it’s properties of external types
> same as pgAdmin3 (PFA screenshots).
>
> I have also attached patch for plain fields control (without lable &
> border) for backform. (Please apply it before testing new type patch)
>
> Thanks,
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Mar 17, 2016 at 4:13 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, Mar 17, 2016 at 10:08 AM, Murtuza Zabuawala
>> <[email protected]> wrote:
>> >
>> > - When editing a type, I cannot select a Grantee on the Privileges tab.
>> >
>> > This is general issue with privilege control.
>> > [We will add it in TODO list]
>>
>> OK.
>>
>> > - When adding a composite type, I cannot type/select directly in the
>> > grid, I have to expand the row.
>> >
>> > Because currently in Backgrid we do not have functionality like if I
>> edit
>> > one cell second cell re-renders according the value of first cell,
>> > If we expand and select the type the other two fields (length &
>> > precision)are dependent on the value of type for composite types they
>> become
>> > enable/disable accordingly.
>>
>> That's must-have functionality. Please add a TODO for it.
>>
>> > - If I click ADD to add a new member to a composite type whilst the
>> > previous row is expanded, the new row is added, but the expanded panel
>> > remains linked to the first row.
>> >
>> > - If I then click on the Edit button on the new row, I see two
>> > expanded panels, neither of which is attached to their row (and
>> > they're in the wrong order). I would only expect to see one panel at a
>> > time.
>> >
>> > This is general with sub-node collection control.
>> > [We will add it in TODO list]
>>
>> OK.
>>
>> > - When creating an External type, the Input, Output, Send, Receive and
>> > Analyze function lists are all blank. Is this expected? I would have
>> > thought there would be system functions listed as there are for Typmod
>> > in/out.
>> >
>> > Dave, I was not able to test External type functionality completely
>> because
>> > it requires external type which is not inbuilt in postgres.
>> > Once you create that custom type using C/C++ code, it will be listed in
>> > those combobox by sql we are using to fetch external function types
>> added by
>> > user in postgres.
>>
>> I wonder if installing PostGIS would allow that testing to be done.
>>
>> > - Why does "Range" type have a frame around it?
>> >
>> > So that we can make visible/hide all the control/elements related to
>> Range
>> > type as whole instead having separate code for each control/element.
>> > That frame is because we used ‘FieldsetControl’ of backform to group
>> all the
>> > elements of Range type.
>>
>> Can you make it a plain div with no border/title? That would fit in
>> better with the existing styling, assuming the columns line up
>> properly.
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/zip] types node_v4.zip (112.9K, 3-types%20node_v4.zip)
  download

view thread (26+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: PATCH: Added Node Type & Catalog objects [pgAdmin4]
  In-Reply-To: <CAKKotZT5b2ykhq5TKuddEWULTXZaLqRog76vC0KGeyQD0Tb9QA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox