Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eywdG-0001jz-8o for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 09:35:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eywdE-0001VK-Vl for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 09:35:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eywdE-0001V2-PG for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 09:35:36 +0000 Received: from mail-ot0-x243.google.com ([2607:f8b0:4003:c0f::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eywd7-0001gW-Fn for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 09:35:35 +0000 Received: by mail-ot0-x243.google.com with SMTP id m7-v6so8739281otd.1 for ; Thu, 22 Mar 2018 02:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6eeENHtL+YgdSG7Wti3yb+vUzG+/rxLR/TRleOGKoPY=; b=Zm5b3C+ehlkmlEn4k0QYcWFfSwVMe/79MG+kLmIiP3axVCCb3S5fsVJ+ZBlLZW7OFn +UqItjFBWWjkKycA5EttlfQha806hYZBnNlvy4IxzdZbKs9UHEapTT2yXw0gh1B8S5LN aBqmia+pWkKY89xkcbP94OMnDqn1Xls4v0fZh7lRuxvXTZDIMKu47/9Nhw++y3OpmGwn jg6rkACsO7gdT5EUP5DbmAeuBkCSUynmvCFcHD+0bz3Dc6wSnw92O5+JgL2KHIX8qqVe UYrd3dMp4weDS5OxvtHqdqhjbSsMT7DcAiJhac+9w3qzSgBBHKOlyr8rm7WsWgLLECFw Dg3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6eeENHtL+YgdSG7Wti3yb+vUzG+/rxLR/TRleOGKoPY=; b=kmQqLAWZUM2KSrL3yOctuYMcG6qS3vmY3JiVLHyNZtq0BpAXkjj7CgL3sCbwukL+bm GwbEQSrqktArxYHkZ9WXHFnFBO8/HXA0AMclq9f1JMLh7nhjPAgcPgUQrq5jwxZijUpq V+NkD3LN9qMasLw+EQg3MUwl/caxVVD80h+3Qc2cswdZPRdekNYEzuVExVdix0v++Aba oU9/r3eQnfoXkljon2VYWMKYCizsdU3OkEqT0U5iz5Bg9IhzBuTo/8gFwuMCdy27MWH6 9+7zTpX3j+quoTd1OJaKIfWTPMAbfCdsmBxgIb1Gl27SrB6dukEwCfjl4nBYjHDyuM0i dXXQ== X-Gm-Message-State: AElRT7FyavOSzdpj1zNAmDf65qHub6LwZH65tcecJtIsKY/bmdn/dCmD yaXrELKzhjmDk0qf1uyJaK7eETarO4uG72I1AhUSUQ== X-Google-Smtp-Source: AG47ELsKKCbr3O/PAQaZEHWjDOhA4Ezu8z8xhk2ECAC3ftiSkKrhWOxn/sdExhwVik5nqu7XQVww+s5puDOzgOW3M3c= X-Received: by 2002:a9d:430e:: with SMTP id s14-v6mr13586103ote.79.1521711326752; Thu, 22 Mar 2018 02:35:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.149.198 with HTTP; Thu, 22 Mar 2018 02:35:06 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Thu, 22 Mar 2018 15:05:06 +0530 Message-ID: Subject: Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: Rahul Soshte Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001535ec0567fd07d7" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001535ec0567fd07d7 Content-Type: text/plain; charset="UTF-8" You need to make SERVER_MODE = False in config_local.py in order to run feature tests. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Mar 22, 2018 at 3:00 PM, Rahul Soshte wrote: > how do I resolve those errors in step 4 of the checklist? > > > On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte > wrote: > >> This is my first time trying to make a Patch. >> >> I am using Ubuntu 17.10. >> >> This patch is in reference to the Feature Added by Dave Page >> https://redmine.postgresql.org/issues/1305 >> >> I just added code to call makefile in runtime directory( >> $PGADMIN_SRC/runtime/Makefile ) from the top level directory's MakeFile ( >> $PGADMIN_SRC/Makefile ) >> >> >> I followed the checklist for submitting a patch sent by Murutuza Zabuawala >> >> <================================> >> Hello, >> >> Here is the common checklist to follow before sending patch to >> pgAdmin4-hackers group, >> >> 1) Get the latest pull from master branch. >> >> 2) Apply your patch and check if applies successfully on the latest code. >> >> 3) Check for PEP8 issues >> - activate virtual env >> - cd ../web >> - yarn run pep8 >> >> 4) Run regression test >> python regression/runtests.py >> >> - To run only UI/feature tests >> python regression/runtests.py --pkg feature_tests >> >> - To run regression test (without UI/Feature tests) >> python regression/runtests.py --exclude feature_tests >> >> 5) Run Jasmine tests >> - activate virtual env >> - cd ../web >> yarn run test:karma-once >> >> 6) Make sure to add or update help docs and screenshot(s) if you have >> added any new feature or changed any existing one. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> <===================================================> >> >> But I am facing some issues, >> Step 1,2,3 and 5 had no issues >> But when I tried step 4 it gave some errors >> I executed the following command >> >> *python regression/runtests.py * >> >> I got the following errors: >> 1)The screenshot attached show I wasnt able to connect to the server >> 2) the error ouput on the command line: >> =============Running the test cases for 'PostgreSQL 9.4'============= >> Traceback (most recent call last): >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 128, in create_database >> server['sslmode'] >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 36, in get_db_connection >> sslmode=sslmode >> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >> line 130, in connect >> conn = _connect(dsn, connection_factory=connection_factory, >> **kwasync) >> OperationalError: FATAL: password authentication failed for user >> "postgres" >> FATAL: password authentication failed for user "postgres" >> >> Traceback (most recent call last): >> File "regression/runtests.py", line 350, in >> server_information = test_utils.create_parent_server_node(server) >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 491, in create_parent_server_node >> server_info['sslmode'] >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 36, in get_db_connection >> sslmode=sslmode >> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >> line 130, in connect >> conn = _connect(dsn, connection_factory=connection_factory, >> **kwasync) >> psycopg2.OperationalError: FATAL: password authentication failed for >> user "postgres" >> FATAL: password authentication failed for user "postgres" >> >> Traceback (most recent call last): >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 619, in _cleanup >> connection = get_db_server(database["server_id"]) >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 593, in get_db_server >> db_name, username, db_password, host, db_port, ssl_mode >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 36, in get_db_connection >> sslmode=sslmode >> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >> line 130, in connect >> conn = _connect(dsn, connection_factory=connection_factory, >> **kwasync) >> OperationalError: FATAL: password authentication failed for user >> "postgres" >> FATAL: password authentication failed for user "postgres" >> >> I have no password authentication errors when I am connecting from the >> application.I had also changed password for postgres manually through the >> command line. >> > > --0000000000001535ec0567fd07d7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
You need to make SERVER_MODE =3D False in config_local.py in order = to run feature tests.

<= div dir=3D"ltr">
--
Regards,
Murtuza Zabuaw= ala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company


On Thu, Mar 22, 2018 at 3:00 PM, Rahul Sosht= e <rahulsoshte360@gmail.com> wrote:
how do I resolve those errors in step 4 = of the checklist?


On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte <rahuls= oshte360@gmail.com> wrote:
=
This is my first time trying to make a= Patch.

I am using Ubuntu 17.10.

This patch is in refer= ence to the Feature Added by Dave Page
https://redmine.postgresql.org/issues/1305

I just added code to call makefile in runtim= e directory( $PGADMIN_SRC/runtime/Makefile ) from the top level directory&#= 39;s MakeFile=C2=A0 ( $PGADMIN_SRC/Makefile )


I foll= owed the checklist for submitting a patch sent by Murutuza Zabuawala

<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>
Hello,

Here is t= he common checklist to follow before sending patch to pgAdmin4-hacke= rs group,

1) Get the latest p= ull from master branch.

2) App= ly your patch and check if applies successfully on the latest code.

3) Check for PEP8 issues
- activate virtual env
- cd ../web
- yarn run pep8

4) Run regression test
python regression/runtests.py=C2=A0
=
- To run only UI/feature tests
python= regression/runtests.py --pkg feature_tests=C2=A0

- T= o run regression test (without UI/Feature tests)
python regression/runtests.py -= -exclude feature_tests=C2=A0

5) Run Jasmi= ne tests
- act= ivate virtual env
- cd ../web
yarn run=C2=A0test:karma-once

6) Make su= re to add or update help docs and screenshot(s) if you have added any new= =C2=A0feature=C2=A0or changed any existi= ng one.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= /font>
<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>
=

But I am facing some issues,
Step 1,2,3 and 5 h= ad no issues
But when I tried step 4 it gave some errors
<= /div>
I executed the following command
=C2=A0
python regres= sion/runtests.py=C2=A0

I got the following e= rrors:
1)The screenshot attached show I wasnt able to connect= to the server
2) the error ouput on the command line:
=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the test cases for 'Postgre= SQL 9.4'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Traceback (most rece= nt call last):
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/w= eb/regression/python_test_utils/test_utils.py", line 128, in crea= te_database
=C2=A0=C2=A0=C2=A0 server['sslmode']
=C2=A0 File = "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test= _utils/test_utils.py", line 36, in get_db_connection
=C2=A0=C2=A0= =C2=A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/flask/pgadmin4/local= /lib/python2.7/site-packages/psycopg2/__init__.py", line 130= , in connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_factor= y=3Dconnection_factory, **kwasync)
OperationalError: FATAL:=C2=A0 p= assword authentication failed for user "postgres"
FATAL:=C2=A0= password authentication failed for user "postgres"

Traceb= ack (most recent call last):
=C2=A0 File "regression/runtests.py&qu= ot;, line 350, in <module>
=C2=A0=C2=A0=C2=A0 server_information = =3D test_utils.create_parent_server_node(server)
=C2=A0 File "= /var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils= /test_utils.py", line 491, in create_parent_server_node
=C2=A0=C2= =A0=C2=A0 server_info['sslmode']
=C2=A0 File "/var/www/flas= k/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.p= y", line 36, in get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslm= ode
=C2=A0 File "/var/www/flask/pgadmin4/local/lib/python2.7/s= ite-packages/psycopg2/__init__.py", line 130, in connect
=C2= =A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory=3Dconnection_factory, **kwasync)
psycopg2.OperationalError: FATAL:=C2=A0 password au= thentication failed for user "postgres"
FATAL:=C2=A0 password = authentication failed for user "postgres"

Traceback (most = recent call last):
=C2=A0 File "/var/www/flask/pgadmin4/pgadmi= n4/web/regression/python_test_utils/test_utils.py", line 619, in = _cleanup
=C2=A0=C2=A0=C2=A0 connection =3D get_db_server(database["= server_id"])
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", line 593,= in get_db_server
=C2=A0=C2=A0=C2=A0 db_name, username, db_password, hos= t, db_port, ssl_mode
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", line 36, in= get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2=A0 File &= quot;/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/ps= ycopg2/__init__.py", line 130, in connect
=C2=A0=C2=A0=C2=A0 conn = =3D _connect(dsn, connection_factory=3Dconnection_factory, **kwasync)<= br>OperationalError: FATAL:=C2=A0 password authentication failed for user &= quot;postgres"
FATAL:=C2=A0 password authentication failed for user= "postgres"

I have no password authentication e= rrors when I am connecting from the application.I had also changed password= for postgres manually through the command line.


--0000000000001535ec0567fd07d7--