Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fRiC0-0004HH-9G for pgadmin-hackers@arkaria.postgresql.org; Sat, 09 Jun 2018 18:02:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fRiBy-00048e-W6 for pgadmin-hackers@arkaria.postgresql.org; Sat, 09 Jun 2018 18:02:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fRiBy-00048U-Lw for pgadmin-hackers@lists.postgresql.org; Sat, 09 Jun 2018 18:02:22 +0000 Received: from mail-ot0-x22d.google.com ([2607:f8b0:4003:c0f::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fRiBu-0004aG-Jm for pgadmin-hackers@postgresql.org; Sat, 09 Jun 2018 18:02:21 +0000 Received: by mail-ot0-x22d.google.com with SMTP id d19-v6so13796123oti.8 for ; Sat, 09 Jun 2018 11:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to:cc; bh=Z4f0LtQ3IFXkyG24g0LMoCf3KyHtS+lLoKNeytpuouY=; b=e6RPv4CHO1bry3BNG2rqIQx1R7nYQdd003PD8Nbqkc8BGXHRNHb9IiWtJhZwiCVnuv +ZOf2A5zTCmO8pxeerZRZZ8eEUG9d3PCBZ2CRffVnWo1xQsakghIMZVQgNDRBYxndOoz H4ZecCxUV2nRqgrhJn3Rh912+UUleQaKyC1FPmFv7b5u9hPuNZTXqKAR2wJd3e/X/0vk jePTimoAiZjBP18xXkMtuQ2gRSrLJS4I679wXB5MgqSXLZxxipuj+f556bf9vWsoVz0m rnP4Cv4JYtlYhKjwVhepXheVeEDCxmIvHzXZOFagkMyriWg8NuHKO4BznhdZSM+2vHId fL6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=Z4f0LtQ3IFXkyG24g0LMoCf3KyHtS+lLoKNeytpuouY=; b=fU8sFdy33OK79eGwe/RcLsxy2H7ol4lkyjbHpQoTsdv4h8FCQOT99rAEKMNNuZVLtF R5sjkjIKtokG7uZB96ExYAfyPGBj+mVdomVYvtNk4zFH7dbwmCd1LIg8RQ874Z5R/y/M sP7M8r/9jxxUZLwFb6DSsqjcqfHmwFjMLRzDIlU5Qbm5K77/NhRsuXj/gcEbP2ak3w6C RxYjimiK6FZWiulHITfzYdl6d/mVR1Pi01m1yCErj/IBZ2qCbitFYcP1foQ+iAtOSmU3 2bnJgLa5IgJhOt4r2xoBJmIn0LL1xSYm4KtgIelIeW5kA+SiV4e5pi8+H4/WsgMmENzo 6OHw== X-Gm-Message-State: APt69E0fVZ329TEim43BN1FpWSwOzVcrlLamuj3ll1WE0UHGDrzRVLiF I+sb5tVY1s1V01HVpcZEbxSNCAmL6Q6Wty/4J+IJbA== X-Google-Smtp-Source: ADUXVKL6lQ5xqfKE/vm0Bd46I/Odhv0bwFwHq0DibhZ4FxlrWBdJOVvz6R1SBoYkb2O8Wf5GLGy8oaH2dgxiP/y6L5Q= X-Received: by 2002:a9d:cc7:: with SMTP id o7-v6mr6014746otd.291.1528567336335; Sat, 09 Jun 2018 11:02:16 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:8515:0:0:0:0:0 with HTTP; Sat, 9 Jun 2018 11:01:55 -0700 (PDT) From: Murtuza Zabuawala Date: Sat, 9 Jun 2018 23:31:55 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000194146056e39513e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000194146056e39513e Content-Type: multipart/alternative; boundary="000000000000194143056e39513c" --000000000000194143056e39513c Content-Type: text/plain; charset="UTF-8" Hi Dave, Sorry, the previous patch had a typo, Here's an updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 7, 2018 at 2:32 PM, Dave Page wrote: > Hi > > On Wed, Jun 6, 2018 at 6:04 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to fix the regression issue introduced with RM#3271 >> commit due to which label is not displaying under the graphical explain >> node, I've attached the screenshot in RM for your reference. >> > > I see the labels, but the popups are not displaying on mouseover/hover > like they used to. Can you look into that please? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000194143056e39513c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

Sorry,= the previous patch had a typo, Here's an updated patch.
=
--
Regards,
Murtuza Zabuaw= ala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=

On Thu, Jun 7, 2018 at 2:32 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Wed, Jun 6, 2018 at 6:04 PM, Murtuza Zabuawala &l= t;m= urtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to fix the regression issue in= troduced with RM#3271 commit due to which label is not displaying under the= graphical explain node, I've attached the screenshot in RM for your re= ference.

I see the labels, but the popups are not displaying = on mouseover/hover like they used to. Can you look into that please?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: = @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQ= L Company

--000000000000194143056e39513c-- --000000000000194146056e39513e Content-Type: application/octet-stream; name="RM_3404_v1.diff" Content-Disposition: attachment; filename="RM_3404_v1.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ji7phb590 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGljL2V4cGxhaW4vanMvZXhwbGFpbi5q cyBiL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGljL2V4cGxhaW4vanMvZXhwbGFpbi5qcwppbmRleCA2 MWNmOGY5Li5lMDI4Nzc0IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9taXNjL3N0YXRpYy9leHBs YWluL2pzL2V4cGxhaW4uanMKKysrIGIvd2ViL3BnYWRtaW4vbWlzYy9zdGF0aWMvZXhwbGFpbi9q cy9leHBsYWluLmpzCkBAIC01NzYsNyArNTc2LDcgQEAgZGVmaW5lKCdwZ2FkbWluLm1pc2MuZXhw bGFpbicsIFsKIAogICAgICAgLy8gRHJhdyB0b29sdGlwCiAgICAgICB2YXIgaW1hZ2VfZGF0YSA9 IHRoaXMudG9KU09OKCk7Ci0gICAgICBpbWFnZS5vbignbW91c2VvdmVyJywoKSA9PiB7CisgICAg ICBpbWFnZS5tb3VzZW92ZXIoKCkgPT4gewogCiAgICAgICAgIC8vIEVtcHR5IHRoZSB0b29sdGlw IGNvbnRlbnQgaWYgaXQgaGFzIGFueSBhbmQgYWRkIG5ldyBkYXRhCiAgICAgICAgIHRvb2xUaXBD b250YWluZXIuZW1wdHkoKTsKQEAgLTYxOCw3ICs2MTgsNyBAQCBkZWZpbmUoJ3BnYWRtaW4ubWlz Yy5leHBsYWluJywgWwogICAgICAgfSk7CiAKICAgICAgIC8vIFJlbW92ZSB0b29sdGlwIHdoZW4g bW91c2UgaXMgb3V0IGZyb20gbm9kZSdzIGFyZWEKLSAgICAgIGltYWdlLm9uKCdtb3VzZW91dCcs KCkgPT4geworICAgICAgaW1hZ2UubW91c2VvdXQoKCkgPT4gewogICAgICAgICB0b29sVGlwQ29u dGFpbmVyLmVtcHR5KCk7CiAgICAgICAgIHRvb2xUaXBDb250YWluZXIuY3NzKHsKICAgICAgICAg ICAnb3BhY2l0eSc6ICcwJywK --000000000000194146056e39513e--