Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqdze-0002Tw-K2 for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Feb 2018 12:04:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eqdzd-00029U-Iz for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Feb 2018 12:04:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqdzd-00029J-CO for pgadmin-hackers@lists.postgresql.org; Tue, 27 Feb 2018 12:04:25 +0000 Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eqdzV-00067z-QK for pgadmin-hackers@postgresql.org; Tue, 27 Feb 2018 12:04:24 +0000 Received: by mail-oi0-x230.google.com with SMTP id u73so8123271oie.3 for ; Tue, 27 Feb 2018 04:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AJi8QXyKiPKz8typAcgvOTy++NZo56/OUkFQSENBP2k=; b=F0EfuwOH0WMPRGBxQoExo7vv1iKBup+AUWtKYMaDJUG/fP+m/Ys3xP4BIvzJ5hHh4H S4htWh3730iT+ZyTQD5Zv5sEtsK5QZUevhaYdeG9He04FjOSQmbzlSVHYPFnZ++z6vzF 8ZsbFxNO4vySB78vZ0NixcHHCGkDpRIbhFphOqD0mEFCcsqbC1qHrzx7JeU+JuUQDYml AKF/tuIBvmriKa31kJgV7mQ/Q5aVRjGxKcZIBLwIyN5iV/J+PXAug4sNsSbD6efNeHhA H9DaunMxkK6Ean3Nacb7+9WKJoXtsus6a6q/W0YR0NpQL6ikF8B+FsmCXHSNuyNf1lZq JFJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AJi8QXyKiPKz8typAcgvOTy++NZo56/OUkFQSENBP2k=; b=LVzMlBp4Qi6Jrq2F2IFPugnYCBvP4c2ahWWP+pNfUWIUZaYnATnxOunHQM+PAEGtZX bJOWRUoxO59pObXrra7xJF3xHr+DwKorWrQqBNO6K0kSeJuvHP/AzzgI7dDWQl2Cn1uc uA7egLAL2wT+Ribjy5rL37Hc/zgq0vYsY0ncYUsEt04bRx2B5Smonxc/hGlp+pIj0NcK y128q9PGnCIY6IpCizOaKnhMVQNqIypfHug2PXnkFr0OyQ17Irs91buZ8avLo85t9Nlw BSWRMfC4YkQn2ROpakKv7TGGhSEvv6QroFJsA0K5VjMZ6oAYydNy9gtNyWn1Lc5SuU8d acXw== X-Gm-Message-State: APf1xPDJDR/t5nrR3Auc3T7dmbIVe2fOuk4TnE6bzQwNgX2vkXigaIBV yJJRdSLy0+rYHxLxHtztciToXFoq4zzSPPMtIbQ+2A== X-Google-Smtp-Source: AG47ELtIThCafJSq/IILdW1hL4wpwx+4QBnMniw534zru66hj0jhgdoG6+d+qMlMZRa37nQXZrPBUysdVceI5HA7mr8= X-Received: by 10.202.5.132 with SMTP id 126mr9189191oif.238.1519733055605; Tue, 27 Feb 2018 04:04:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Tue, 27 Feb 2018 04:03:55 -0800 (PST) In-Reply-To: References: From: Murtuza Zabuawala Date: Tue, 27 Feb 2018 17:33:55 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c18d618eee4ac0566306c7b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c18d618eee4ac0566306c7b Content-Type: text/plain; charset="UTF-8" I'm not able to re-produce the issue, Could you hard refresh and try again? If possible could you please provide exact steps? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Feb 27, 2018 at 5:30 PM, Dave Page wrote: > Sorry - here it is. > > On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> Could you please send screenshot? >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page wrote: >> >>> Hi >>> >>> Still not quite right - see the attached screenshot which is the result >>> of simply viewing the properties of an existing job. Note that the start >>> time is shown in the grid but not the subnode control. >>> >>> Thanks. >>> >>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> As validation related patch was committed with RM#3148 [ Sorry about >>>> that I forgot to checkout :) ] >>>> PFA patch to fix the issues you mentioned, I have also removed extra >>>> error message from sub node collection control and made it optional via >>>> flag. >>>> >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA patch to fix the issue where user was not able to create pgAgent >>>>>> job from UI without entering End date in schedule section. >>>>>> >>>>> >>>>> Whilst this does resolve the validation issue, there are still a >>>>> couple of other related problems, as can be seen in the attached >>>>> screenshots: >>>>> >>>>> - The Start date/time in the subnode control doesn't seem to be >>>>> properly synchronised with the value in the grid. >>>>> >>>>> - If you leave the End date/time blank (but maybe click into it >>>>> first), the grid will show "Invalid date". >>>>> >>>>> It's possible there are other oddities as well - please check >>>>> carefully for anything else. >>>>> >>>>> Thanks. >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c18d618eee4ac0566306c7b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm not able to re-produce the issue, Could y= ou hard refresh and try again?

If possible could you = please provide exact steps?

--
Regards,
Murtuza Zab= uawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=

On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Sorry - here it is.

On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawal= a <murtuza.zabuawala@enterprisedb.com>= wrote:
Hi Dave= ,

Could you please send screenshot?
<= /div>

= --Regards,=
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterpris= edb.com
The Enterprise PostgreSQL Company
<= div><= img src=3D"https://drive.google.com/a/enterprisedb.com/uc?id=3D0B6jGeB3BfKR= MV0t4MEp0YnZCTTA&export=3Ddownload" width=3D"420" height=3D"31">

On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <dpage@pgadmin.org&= gt; wrote:
Hi
Still not quite right - see the attached screenshot which i= s the result of simply viewing the properties of an existing job. Note that= the start time is shown in the grid but not the subnode control.

Thanks.

On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:<= br>
Hi Dave,<= /div>

As validation related patch wa= s committed with RM#3148 [ Sorry about that I forgot to checkout :)=C2=A0]<= /div>
PFA patch to fix the issues you mentioned, I have also = removed extra error message from sub node collection control and made it op= tional via flag.



--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2= =A0http://www.enterprisedb.com
The Enterprise PostgreSQL Com= pany


On Mon, Feb 26, 2018 at 10:14 PM, Dave Page = <dpage@pgadmin.org> wrote:
Hi

On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where user was not able to create = pgAgent job from UI without entering End date in schedule section.

=C2=A0Whilst this does resolve the vali= dation issue, there are still a couple of other related problems, as can be= seen in the attached screenshots:

- The Start dat= e/time in the subnode control doesn't seem to be properly synchronised = with the value in the grid.

- If you leave the End= date/time blank (but maybe click into it first), the grid will show "= Invalid date".

It'= s possible there are other oddities as well - please check carefully for an= ything else.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company

=



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enter= prise PostgreSQL Company


--
Dave Page
= Blog: http://pgsn= ake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company
--94eb2c18d618eee4ac0566306c7b--