public inbox for [email protected]  

help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version
Date: Tue, 3 Apr 2018 20:50:16 +0530
Message-ID: <CAKKotZTEHy_=8v6rP0xUhks_pDwiAH2iB43BHegqXDVbySgiAg@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQRQpDdn2KbqcUFZ_UaMnruAOxxt7dzasn6C-ShODANvQ@mail.gmail.com>
References: <CAKKotZRD_epwD7wQE0pXPJJx_6di=xpsCzNEXiTm9LqYCSWFjQ@mail.gmail.com>
	<CA+OCxoxKZ=LeY+GWW0RMz-Fcd9KrR0jm1FWQoYexshaOe2Uiyw@mail.gmail.com>
	<CAKKotZQRQpDdn2KbqcUFZ_UaMnruAOxxt7dzasn6C-ShODANvQ@mail.gmail.com>

Please hold on my previous patch.

We can't use latest jQuery version as SlickGrid has dependancy on older
version.
I'll send updated patch again.

On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala <
[email protected]> wrote:

> Hi Dave,
>
> Please find updated patches, there are two patches attached one is for the
> story and another is for changes required as per new modules.
>
>
> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to update the modules to latest version.
>>>
>>>
>> - Why isn't jQuery updated to 3.3.1?
>>
> ​Done​
>
>
>> ​
>>
>>
>
>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2 and
>> pycrypto etc?
>>
> ​Done​
>
>
>>
>>
>>
>>> We are not able to update some of the modules to latest version due to
>>> dependancy on other modules, For example
>>> - Python: Flask-Security has dependancy on flask-babelex which causes
>>> conflict with flask_babel
>>>
>>
>> Hmm, flask-babelex might be a better option anyway; in particular, it
>> avoids loading catalogs with every request which seems desirable given the
>> size of ours. On the other hand, it hasn't been updated so recently.
>>
> ​I have removed flask-babel and used flask_babelex instead.​
>
>
>>
>>
>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch & Bootstrap Datetime
>>> picker has dependancy on Bootstrap3.
>>>
>>
>> OK.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version
  In-Reply-To: <CAKKotZTEHy_=8v6rP0xUhks_pDwiAH2iB43BHegqXDVbySgiAg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox