Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhZK6-00054o-5y for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Sep 2016 09:39:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bhZK5-0000CY-Ov for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Sep 2016 09:39:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bhZJs-0008Mw-Bf for pgadmin-hackers@postgresql.org; Wed, 07 Sep 2016 09:39:00 +0000 Received: from mail-qt0-x232.google.com ([2607:f8b0:400d:c0d::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bhZJo-0005A0-KY for pgadmin-hackers@postgresql.org; Wed, 07 Sep 2016 09:38:59 +0000 Received: by mail-qt0-x232.google.com with SMTP id 93so4573615qtg.2 for ; Wed, 07 Sep 2016 02:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=2LT0jfrxM53s8qoVoDqErC3kXsPa3YHqEVnJU1Zai/E=; b=zr/lLNCy7av6dRc7qHVcLd6GEU63K6R/2PBdhSwMvySzjLQ8krKz6yfJoRdb8k9/JJ 3RzORyUug2TzrrqrsYQFYxwPDcNRuJOs8RDR19oftIwy9iItLLKESu3kZrLGF75fJ2+r M5yyMdwaLGXFeIRiGks0vgqGvuNutHuDkVr5e0WxUDeICeDdBKyWUX4Z3LJjZhUfgXzd FbvmyZtfCNj8dh0RVH1MAT+pijtglOUD6iDdz8LnPZekwMdL4v5tzkZdaNDg+3OGfyIk 6yxrjT27wJJGIBiJ81UiH6IF2g2bydAXzycy8eu/YR9vyjL9pWcRs+I/zk4z90Q0VZtp b8oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=2LT0jfrxM53s8qoVoDqErC3kXsPa3YHqEVnJU1Zai/E=; b=YPRSy/C9YOlYGQMXpIUw3AjuNapRrtdvpWSsCSEY3gJzxfHqSotSOU5GYZ1ym/az2+ Wi2GAfAit9Wlh1jnKqzp+M681PFdAkmNmgUf7mOsCSYAdqahYxQngexeaL8lmTcuUks8 3KBVmpCNoPnXCDqyIMXYSSmcoj84nRid90b2sZjGgUfhQUAeyLa2Q5Ld9ZEULqYZAGRX 8Wf905PUDL2kULhBApwqZ6wD6iSOcZg9T5ejnjf0VivzdNGB7mAqZCn2k9I7fbNjEoAS aJig75ouHLgjY7kKVWLvY9vAXc38Gvw8mVjvbzqV7SYbDEizoJoEJwtCtA0Qeu3HO+v2 rsag== X-Gm-Message-State: AE9vXwMuANytq3tNQfgykk9p8zJnz1QaWvkAbxDQ0wYDdnXaWMbTDUc8KrA0hzIv66hTtpyINzPqA0kW5BNON7TX X-Received: by 10.200.50.114 with SMTP id y47mr25931285qta.61.1473241134434; Wed, 07 Sep 2016 02:38:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.140.5 with HTTP; Wed, 7 Sep 2016 02:38:33 -0700 (PDT) From: Murtuza Zabuawala Date: Wed, 7 Sep 2016 15:08:33 +0530 Message-ID: Subject: PATCH: Adding more confirmations in query tool (pgAdmin4) To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114102267cc031053be7ae86 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114102267cc031053be7ae86 Content-Type: multipart/alternative; boundary=001a114102267cc02d053be7ae84 --001a114102267cc02d053be7ae84 Content-Type: text/plain; charset=UTF-8 Hi, PFA patch to add more confirmations in query tool before taking any actions which might cause lose changes, - Clearing editor - Clearing history - Load file data RM#1666 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114102267cc02d053be7ae84 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA patch to add more confirmations= in query tool before taking any actions which might cause lose changes,
- Clearing editor
- Clearing history=C2=A0
= - Load file data
=C2=A0RM#1666

Pleas= e review.

--
Regards,
= Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny
--001a114102267cc02d053be7ae84-- --001a114102267cc031053be7ae86 Content-Type: text/x-patch; charset=US-ASCII; name="RM_1666.patch" Content-Disposition: attachment; filename="RM_1666.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_isspn4wj0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci90ZW1w bGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVkaXRvci5qcyBiL3dlYi9wZ2FkbWlu L3Rvb2xzL3NxbGVkaXRvci90ZW1wbGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVk aXRvci5qcwppbmRleCBlYmM3MDc3Li5kNDhmNGI5IDEwMDY0NAotLS0gYS93 ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVtcGxhdGVzL3NxbGVkaXRv ci9qcy9zcWxlZGl0b3IuanMKKysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3Fs ZWRpdG9yL3RlbXBsYXRlcy9zcWxlZGl0b3IvanMvc3FsZWRpdG9yLmpzCkBA IC0yNzksMTcgKzI3OSwxNyBAQCBkZWZpbmUoCiAgICAgICAgICAgICAgICBp ZihfLnNpemUoZGF0YV9zdG9yZS5hZGRlZCkgfHwKICAgICAgICAgICAgICAg ICAgICBfLnNpemUoZGF0YV9zdG9yZS51cGRhdGVkKSkgewogICAgICAgICAg ICAgICAgICBtc2cgPSAne3sgXygnVGhlIGRhdGEgaGFzIGJlZW4gbW9kaWZp ZWQsIGJ1dCBub3Qgc2F2ZWQuIEFyZSB5b3Ugc3VyZSB5b3Ugd2lzaCB0byBk aXNjYXJkIHRoZSBjaGFuZ2VzPycpIH19JzsKLSAgICAgICAgICAgICAgICAg bm90aWZ5ID0gdHJ1ZTsgCisgICAgICAgICAgICAgICAgIG5vdGlmeSA9IHRy dWU7CiAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgfSBlbHNlIGlm KHNlbGYuaGFuZGxlci5pc19xdWVyeV90b29sKSB7CiAgICAgICAgICAgICAg ICAvLyBXZSB3aWxsIGNoZWNrIGZvciBtb2RpZmllZCBzcWwgY29udGVudAog ICAgICAgICAgICAgICAgdmFyIHNxbCA9IHNlbGYuaGFuZGxlci5ncmlkVmll dy5xdWVyeV90b29sX29iai5nZXRWYWx1ZSgpOwotICAgICAgICAgICAgICAg c3FsID0gc3FsLnJlcGxhY2UoL1xzKy9nLCAnJyk7IAorICAgICAgICAgICAg ICAgc3FsID0gc3FsLnJlcGxhY2UoL1xzKy9nLCAnJyk7CiAgICAgICAgICAg ICAgICAvLyBJZiBpdCBpcyBhbiBlbXB0eSBxdWVyeSwgZG8gbm90aGluZy4K ICAgICAgICAgICAgICAgIGlmIChzcWwubGVuZ3RoID4gMCkgewogICAgICAg ICAgICAgICAgICBtc2cgPSAne3sgXygnVGhlIHF1ZXJ5IGhhcyBiZWVuIG1v ZGlmaWVkLCBidXQgbm90IHNhdmVkLiBBcmUgeW91IHN1cmUgeW91IHdpc2gg dG8gZGlzY2FyZCB0aGUgY2hhbmdlcz8nKSB9fSc7Ci0gICAgICAgICAgICAg ICAgIG5vdGlmeSA9IHRydWU7IAotICAgICAgICAgICAgICAgfSAKKyAgICAg ICAgICAgICAgICAgbm90aWZ5ID0gdHJ1ZTsKKyAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgaWYobm90aWZ5KSB7cmV0 dXJuIHNlbGYudXNlcl9jb25maXJtYXRpb24ocCwgbXNnKTt9CiAgICAgICAg ICAgICAgcmV0dXJuIHRydWU7CkBAIC00MDEsMjAgKzQwMSwyMCBAQCBkZWZp bmUoCiAKICAgICAgIC8qIFRvIHByb21wdCB1c2VyIGZvciB1bnNhdmVkIGNo YW5nZXMgKi8KICAgICAgIHVzZXJfY29uZmlybWF0aW9uOiBmdW5jdGlvbihw YW5lbCwgbXNnKSB7Ci0gICAgICAgIC8vIElmIHRoZXJlIGlzIGFueXRoaW5n IHRvIHNhdmUgdGhlbiBwcm9tcHQgdXNlciAKLSAgICAgICAgICBhbGVydGlm eS5jb25maXJtKCd7eyBfKCdVbnNhdmVkIGNoYW5nZXMnKSB9fScsIG1zZywg Ci0gICAgICAgICAgICBmdW5jdGlvbigpIHsKLSAgICAgICAgICAgICAgLy8g RG8gbm90aGluZyBhcyB1c2VyIGRvIG5vdCB3YW50IHRvIHNhdmUsIGp1c3Qg Y29udGludWUKLSAgICAgICAgICAgICAgd2luZG93Lm9uYmVmb3JldW5sb2Fk ID0gbnVsbDsKLSAgICAgICAgICAgICAgcGFuZWwub2ZmKHdjRG9ja2VyLkVW RU5ULkNMT1NJTkcpOwotICAgICAgICAgICAgICB3aW5kb3cudG9wLnBnQWRt aW4uQnJvd3Nlci5kb2NrZXIucmVtb3ZlUGFuZWwocGFuZWwpOwotICAgICAg ICAgICAgfSwKLSAgICAgICAgICAgIGZ1bmN0aW9uKCkgewotICAgICAgICAg ICAgICAvLyBTdG9wLCBVc2VyIHdhbnRzIHRvIHNhdmUKLSAgICAgICAgICAg ICAgLy8gZmFsc2UgdmFsdWUgd2lsbCBwcmV2ZW50IGZyb20gcGFuZWwgdG8g Y2xvc2UKLSAgICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgICAg ICB9Ci0gICAgICAgICAgKS5zZXQoJ2xhYmVscycsIHtvazonWWVzJywgY2Fu Y2VsOidObyd9KTsKKyAgICAgICAgLy8gSWYgdGhlcmUgaXMgYW55dGhpbmcg dG8gc2F2ZSB0aGVuIHByb21wdCB1c2VyCisgICAgICAgIGFsZXJ0aWZ5LmNv bmZpcm0oJ3t7IF8oJ1Vuc2F2ZWQgY2hhbmdlcycpIH19JywgbXNnLAorICAg ICAgICAgIGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgLy8gRG8gbm90aGlu ZyBhcyB1c2VyIGRvIG5vdCB3YW50IHRvIHNhdmUsIGp1c3QgY29udGludWUK KyAgICAgICAgICAgIHdpbmRvdy5vbmJlZm9yZXVubG9hZCA9IG51bGw7Cisg ICAgICAgICAgICBwYW5lbC5vZmYod2NEb2NrZXIuRVZFTlQuQ0xPU0lORyk7 CisgICAgICAgICAgICB3aW5kb3cudG9wLnBnQWRtaW4uQnJvd3Nlci5kb2Nr ZXIucmVtb3ZlUGFuZWwocGFuZWwpOworICAgICAgICAgIH0sCisgICAgICAg ICAgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAvLyBTdG9wLCBVc2VyIHdh bnRzIHRvIHNhdmUKKyAgICAgICAgICAgIC8vIGZhbHNlIHZhbHVlIHdpbGwg cHJldmVudCBmcm9tIHBhbmVsIHRvIGNsb3NlCisgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKKyAgICAgICAgICB9CisgICAgICAgICkuc2V0KCdsYWJlbHMn LCB7b2s6J1llcycsIGNhbmNlbDonTm8nfSk7CiAgICAgICAgIHJldHVybiBm YWxzZTsKICAgICAgIH0sCiAKQEAgLTExNDksMjEgKzExNDksNDkgQEAgZGVm aW5lKAogCiAgICAgICAvLyBDYWxsYmFjayBmdW5jdGlvbiBmb3IgdGhlIGNs ZWFyIGJ1dHRvbiBjbGljay4KICAgICAgIG9uX2NsZWFyOiBmdW5jdGlvbihl dikgeworICAgICAgICB2YXIgc2VsZiA9IHRoaXMsIHNxbDsKICAgICAgICAg dGhpcy5fc3RvcEV2ZW50UHJvcG9nYXRpb24oZXYpOwogICAgICAgICB0aGlz Ll9jbG9zZURyb3BEb3duKGV2KTsKIAotICAgICAgICB0aGlzLnF1ZXJ5X3Rv b2xfb2JqLnNldFZhbHVlKCcnKTsKKyAgICAgICAgLy8gV2Ugd2lsbCBjaGVj ayBmb3IgbW9kaWZpZWQgc3FsIGNvbnRlbnQKKyAgICAgICAgc3FsID0gc2Vs Zi5xdWVyeV90b29sX29iai5nZXRWYWx1ZSgpOworICAgICAgICBzcWwgPSBz cWwucmVwbGFjZSgvXHMrL2csICcnKTsKKyAgICAgICAgLy8gSWYgdGhlcmUg aXMgbm90aGluZyB0byBzYXZlLCBjbGVhciBpdC4KKyAgICAgICAgaWYgKCFz cWwubGVuZ3RoKSB7IHNlbGYucXVlcnlfdG9vbF9vYmouc2V0VmFsdWUoJycp OyAgcmV0dXJuOyB9CisKKyAgICAgICAgYWxlcnRpZnkuY29uZmlybSgKKyAg ICAgICAgICAne3sgXygnQ2xlYXIgRWRpdG9yJykgfX0nLAorICAgICAgICAg ICd7eyBfKCdBcmUgeW91IHN1cmUgeW91IHdpc2ggdG8gZGlzY2FyZCB0aGUg Y3VycmVudCBjaGFuZ2VzPycpIH19JywKKyAgICAgICAgICBmdW5jdGlvbigp IHsKKyAgICAgICAgICAgIC8vIERvIG5vdGhpbmcgYXMgdXNlciBkbyBub3Qg d2FudCB0byBzYXZlLCBqdXN0IGNvbnRpbnVlCisgICAgICAgICAgICBzZWxm LnF1ZXJ5X3Rvb2xfb2JqLnNldFZhbHVlKCcnKTsKKyAgICAgICAgICB9LAor ICAgICAgICAgIGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgcmV0dXJuIHRy dWU7CisgICAgICAgICAgfQorICAgICAgICApLnNldCgnbGFiZWxzJywge29r OidZZXMnLCBjYW5jZWw6J05vJ30pOwogICAgICAgfSwKIAogICAgICAgLy8g Q2FsbGJhY2sgZnVuY3Rpb24gZm9yIHRoZSBjbGVhciBoaXN0b3J5IGJ1dHRv biBjbGljay4KICAgICAgIG9uX2NsZWFyX2hpc3Rvcnk6IGZ1bmN0aW9uKGV2 KSB7CisgICAgICAgIHZhciBzZWxmID0gdGhpczsKICAgICAgICAgdGhpcy5f c3RvcEV2ZW50UHJvcG9nYXRpb24oZXYpOwogICAgICAgICB0aGlzLl9jbG9z ZURyb3BEb3duKGV2KTsKLQotICAgICAgICAvLyBSZW1vdmUgYW55IGV4aXN0 aW5nIGdyaWQgZmlyc3QKLSAgICAgICAgaWYgKHRoaXMuaGlzdG9yeV9ncmlk KSB7Ci0gICAgICAgICAgICB0aGlzLmhpc3RvcnlfY29sbGVjdGlvbi5yZXNl dCgpOwotICAgICAgICB9CisgICAgICAgIC8vIGFzayBmb3IgY29uZmlybWF0 aW9uIG9ubHkgaWYgYW55dGhpbmcgdG8gY2xlYXIKKyAgICAgICAgaWYoIXNl bGYuaGlzdG9yeV9jb2xsZWN0aW9uLmxlbmd0aCkgeyByZXR1cm47IH0KKwor ICAgICAgICBhbGVydGlmeS5jb25maXJtKCd7eyBfKCdDbGVhciBoaXN0b3J5 JykgfX0nLAorICAgICAgICAgICd7eyBfKCdBcmUgeW91IHN1cmUgeW91IHdp c2ggdG8gY2xlYXIgYWxsIHRoZSBoaXN0b3J5PycpIH19JywKKyAgICAgICAg ICBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIC8vIFJlbW92ZSBhbnkgZXhp c3RpbmcgZ3JpZCBmaXJzdAorICAgICAgICAgICAgaWYgKHNlbGYuaGlzdG9y eV9ncmlkKSB7CisgICAgICAgICAgICAgIHNlbGYuaGlzdG9yeV9jb2xsZWN0 aW9uLnJlc2V0KCk7CisgICAgICAgICAgICB9CisgICAgICAgICAgfSwKKyAg ICAgICAgICBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHJldHVybiB0cnVl OworICAgICAgICAgIH0KKyAgICAgICAgKS5zZXQoJ2xhYmVscycsIHtvazon WWVzJywgY2FuY2VsOidObyd9KTsKICAgICAgIH0sCiAKICAgICAgIC8vIENh bGxiYWNrIGZ1bmN0aW9uIGZvciB0aGUgYXV0byBjb21taXQgYnV0dG9uIGNs aWNrLgpAQCAtMjE2Niw2ICsyMTk0LDI3IEBAIGRlZmluZSgKICAgICAgICAg Ly8gcmVhZCBmaWxlIGRhdGEgYW5kIHJldHVybiBhcyByZXNwb25zZQogICAg ICAgICBfc2VsZWN0X2ZpbGVfaGFuZGxlcjogZnVuY3Rpb24oZSkgewogICAg ICAgICAgIHZhciBzZWxmID0gdGhpczsKKyAgICAgICAgICAvLyBXZSB3aWxs IGNoZWNrIGZvciBtb2RpZmllZCBzcWwgY29udGVudAorICAgICAgICAgIHNx bCA9IHNlbGYuZ3JpZFZpZXcucXVlcnlfdG9vbF9vYmouZ2V0VmFsdWUoKQor ICAgICAgICAgIHNxbCA9IHNxbC5yZXBsYWNlKC9ccysvZywgJycpOworICAg ICAgICAgIC8vIElmIHRoZXJlIGlzIG5vdGhpbmcgdG8gc2F2ZSwgY2xlYXIg aXQuCisgICAgICAgICAgaWYgKCFzcWwubGVuZ3RoKSB7IHNlbGYuX2xvYWRf ZmlsZV9kYXRhKGUpOyByZXR1cm47fQorCisgICAgICAgICAgYWxlcnRpZnku Y29uZmlybSgne3sgXygnTG9hZCBmaWxlLi4uJykgfX0nLAorICAgICAgICAg ICAgJ3t7IF8oJ0FyZSB5b3Ugc3VyZSB5b3Ugd2lzaCB0byBkaXNjYXJkIHRo ZSBjdXJyZW50IGNoYW5nZXM/JykgfX0nLAorICAgICAgICAgICAgZnVuY3Rp b24oKSB7CisgICAgICAgICAgICAgIC8vIERvIG5vdGhpbmcgYXMgdXNlciBk byBub3Qgd2FudCB0byBzYXZlLCBqdXN0IGNvbnRpbnVlCisgICAgICAgICAg ICAgIHNlbGYuX2xvYWRfZmlsZV9kYXRhKGUpOworICAgICAgICAgICAgfSwK KyAgICAgICAgICAgIGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICApLnNldCgnbGFi ZWxzJywge29rOidZZXMnLCBjYW5jZWw6J05vJ30pOworICAgICAgICB9LAor CisgICAgICAgIC8vIE1ha2UgYWpheCBmb3IgbG9hZGluZyB0aGUgZGF0YSBm cm9tIGZpbGUgaW4gc3FsIGVkaXRvcgorICAgICAgICBfbG9hZF9maWxlX2Rh dGE6IGZ1bmN0aW9uKGUpIHsKKyAgICAgICAgICB2YXIgc2VsZiA9IHRoaXM7 CiAKICAgICAgICAgICBkYXRhID0gewogICAgICAgICAgICAgJ2ZpbGVfbmFt ZSc6IGUK --001a114102267cc031053be7ae86 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114102267cc031053be7ae86--