MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D80C1BH7xENfmrzjo+RS_=N1ijBx7chvDykBUtarSUfrA@mail.gmail.com>
References: 
 <CAM5-9D80C1BH7xENfmrzjo+RS_=N1ijBx7chvDykBUtarSUfrA@mail.gmail.com>
From: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Date: Tue, 12 Jul 2016 15:43:42 +0530
Message-ID: 
 <CAKKotZTQt4+2SB-prG2YtMy+5pVdG+Jj1O1ysKSBDoqcHhstEQ@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: Regarding RM#1419 - Internal
 Server Error displayed if create any object through simplified Chinese
 character
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=94eb2c048d2427935305376d8795
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--94eb2c048d2427935305376d8795
Content-Type: text/plain; charset=UTF-8

Hi,

Just a heads up, This issue is occurs only in runtime & If you try in web
everything works fine when you provide unicode characters as object name.

Now sure but the issue is when runtime(QtWebkit) sends data it does not
encodes it properly & this should be generic fix in runtime.

Regards,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jul 12, 2016 at 3:27 PM, Surinder Kumar <
surinder.kumar@enterprisedb.com> wrote:

> Hi
>
> *What is happening in code?*
> Database is created with Chinese characters successfully with ascii
> values(Chinese characters converted to ascii) before saving internally.
>
> but when database properties is retrieved by name, it fails to fetch data
> and throws UnicodeError.
>
> *Solution:*
> Database name should be encoded in 'utf-8' before storing to database.
> This resolved the issue.
> I have tested this patch by creating database name using Japanese and
> Chinese characters. It works.
>
> Also referenced the code to *set default encoding to 'uff-8' *before
> start of application.
> https://github.com/joeyespo/grip/issues/86
>
> @Ashesh/@Dave can you please review the patch?
> If it looks good, we can do the same changes in case of other nodes.
>
> Thanks,
> Surinder Kumar
>
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--94eb2c048d2427935305376d8795
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>Just a heads up, This issue is occu=
rs only in runtime &amp; If you try in web everything works fine when you p=
rovide unicode characters as object name.</div><div><br></div><div>Now sure=
 but the issue is when runtime(QtWebkit) sends data it does not encodes it =
properly &amp; this should be generic fix in runtime.</div><div><br></div><=
div>Regards,</div><div>Murtuza</div></div><div class=3D"gmail_extra"><br cl=
ear=3D"all"><div><div class=3D"gmail_signature" data-smartmail=3D"gmail_sig=
nature"><div dir=3D"ltr"><span style=3D"color:rgb(136,136,136)"><font size=
=3D"2" face=3D"tahoma, sans-serif">--</font></span><div><span style=3D"colo=
r:rgb(136,136,136)"><font size=3D"2" face=3D"tahoma, sans-serif">Regards,</=
font></span><div><font size=3D"2" face=3D"tahoma, sans-serif"><font color=
=3D"#888888">Murtuza Zabuawala</font><br style=3D"color:rgb(136,136,136)"><=
span style=3D"color:rgb(136,136,136)">EnterpriseDB:=C2=A0</span><a href=3D"=
http://www.enterprisedb.com/" rel=3D"noreferrer" style=3D"color:rgb(17,85,2=
04)" target=3D"_blank">http://www.enterprisedb.com</a><br style=3D"color:rg=
b(136,136,136)"><span style=3D"color:rgb(136,136,136)">The Enterprise Postg=
reSQL Company</span></font><br style=3D"color:rgb(136,136,136);font-size:12=
.8px"></div></div></div></div></div>
<br><div class=3D"gmail_quote">On Tue, Jul 12, 2016 at 3:27 PM, Surinder Ku=
mar <span dir=3D"ltr">&lt;<a href=3D"mailto:surinder.kumar@enterprisedb.com=
" target=3D"_blank">surinder.kumar@enterprisedb.com</a>&gt;</span> wrote:<b=
r><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:=
1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi<div><br></div><div><di=
v><u>What is happening in code?</u></div><div>Database is created with Chin=
ese characters successfully with ascii values(Chinese characters converted =
to ascii) before saving internally.</div><div><br></div><div>but when datab=
ase properties is retrieved by name, it fails to fetch data and throws Unic=
odeError.</div><div><br></div><div><u>Solution:</u></div><div>Database name=
 should be encoded in &#39;utf-8&#39; before storing to database.</div><div=
>This resolved the issue.=C2=A0</div><div>I have tested this patch by creat=
ing database name using Japanese and Chinese characters. It works.</div><di=
v><br></div><div>Also referenced the code to <b>set default encoding to =
9;uff-8&#39; </b>before start of application.</div><div><a href=3D"https://=
github.com/joeyespo/grip/issues/86" target=3D"_blank">https://github.com/jo=
eyespo/grip/issues/86</a><br></div><div><br></div><div>@Ashesh/@Dave can yo=
u please review the patch?</div><div>If it looks good, we can do the same c=
hanges in case of other nodes.</div><div><br></div><div>Thanks,</div><div>S=
urinder Kumar</div><div><br></div><div><br></div><div><br></div></div></div=
>
<br><br>
--<br>
Sent via pgadmin-hackers mailing list (<a href=3D"mailto:pgadmin-hackers@po=
stgresql.org">pgadmin-hackers@postgresql.org</a>)<br>
To make changes to your subscription:<br>
<a href=3D"http://www.postgresql.org/mailpref/pgadmin-hackers" rel=3D"noref=
errer" target=3D"_blank">http://www.postgresql.org/mailpref/pgadmin-hackers=
</a><br>
<br></blockquote></div><br></div>

--94eb2c048d2427935305376d8795--