Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cacXv-0002za-2Z for pgadmin-hackers@arkaria.postgresql.org; Mon, 06 Feb 2017 06:13:03 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cacXu-0000Ma-Lx for pgadmin-hackers@arkaria.postgresql.org; Mon, 06 Feb 2017 06:13:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cacXt-0000MJ-QI for pgadmin-hackers@postgresql.org; Mon, 06 Feb 2017 06:13:02 +0000 Received: from mail-ot0-x22f.google.com ([2607:f8b0:4003:c0f::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cacXp-0006CB-Ir for pgadmin-hackers@postgresql.org; Mon, 06 Feb 2017 06:13:01 +0000 Received: by mail-ot0-x22f.google.com with SMTP id 73so55229569otj.0 for ; Sun, 05 Feb 2017 22:12:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=eBtimqfIVmAaaaRXHG2uPo34UV87mWeY4pLhPbNTj0E=; b=EsICpitB4bKy/lEJiVZCEH8pDprRzMhXQxYtaZ7+GrI/KMKqpzryF11Og4UmKJGQL7 r4RkN0Wozptmsq4gxaCztMMW/PsBy48YkdaeU1RA4C4oS4e4wximWFMCVjQ0zLhnH6Pz /SiF21htIoKefe3txWf0VuELYP/lm2LPx3GAR0ohWi0QfUwo/wYvO7sRL1Wi2FC6c//G mAytQd6qX/Vj2nbJHS4OaZ2ngmqxeUE09EfaU65id6kjrS/wN/NfhP5QkDJv2w1ZebYG vFwzsSuyka+fLjOcTe+F4lViY/gQgOrQYtD1ag6IfRFXea62oyv87x4RG2OYcFnMIeLN /bBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eBtimqfIVmAaaaRXHG2uPo34UV87mWeY4pLhPbNTj0E=; b=nLNAW5kmruyjYDNbbVxsg0ydsXxMTpE4lVQY4ruxngtxrOzquBxVDSvAjhDLt0ytgJ h2I8lJuVX7Npz+tQo9HCB+Wrs2apO9yap/gDMCXJyOK1r29hMo1gjqhlOULE0GAVsvZN vCkdvslI3zZJzBn8pEx7fIZOzl/40zre5fJgrOgZJH9B7pLjUqtjPnhb1drd6n4jqnzl mgo8j1uRG7PkG/7adurEsaXWI7gEZOyjmT2AAlgRpt6Lcni/gyNTjoOq8mlz5i1OujxJ gwSHLFFGRgv2qII+7GPGLNpVcjfVJkvyT9fkajY/ge3RPblSiZ2Nvg1erc7S4xqJCnhF SSdQ== X-Gm-Message-State: AMke39l6bUPDrzCDIAHJzNh8KH2vcUsrBjvSauQlapbqRAj580ZScFcpZZJ6xbKWJutVX2rtXRehxuranytsKdY+ X-Received: by 10.157.5.161 with SMTP id 30mr3983239otd.74.1486361575717; Sun, 05 Feb 2017 22:12:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.183.26.2 with HTTP; Sun, 5 Feb 2017 22:12:35 -0800 (PST) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 6 Feb 2017 11:42:35 +0530 Message-ID: Subject: Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type To: Dave Page Cc: pgadmin-hackers , Ashesh Vashi Content-Type: multipart/mixed; boundary=001a11392664bb33780547d685e2 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11392664bb33780547d685e2 Content-Type: multipart/alternative; boundary=001a11392664bb33720547d685e0 --001a11392664bb33720547d685e0 Content-Type: text/plain; charset=UTF-8 Hi Dave, Please find a fix for the same, attribute length was set to False instead of None. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 6, 2017 at 11:18 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Sure, Checking. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Sat, Feb 4, 2017 at 7:34 PM, Dave Page wrote: > >> Hi Murtuza, >> >> I clearly neglected to run the regression tests with this patch, and >> unfortunately it looks like it broke them. Can you look at this ASAP >> please? >> >> runTest (pgadmin.browser.server_groups.servers.databases.schemas. >> tables.column.tests.test_column_add.ColumnAddTestCase) >> This function will add column under table node. (Add table Node URL) >> ... 2017-02-04 14:43:55,191: ERROR pgadmin: Failed to execute query >> (execute_scalar) for the server #4 - DB:test_db_9e176 (Query-id: >> 4792242): >> Error Message:ERROR: syntax error at or near "False" >> LINE 2: ADD COLUMN test_column_add_f0d5d char(False); >> ^ >> FAIL >> >> As far as I can see, the app works fine - it's only the test that >> broke (probably because the application uses type name aliases (e.g. >> character) rather than the base type name that the test is using >> ("char"). >> >> Thanks. >> >> On Fri, Feb 3, 2017 at 1:52 PM, Dave Page wrote: >> > Thanks - patch applied. >> > >> > On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala >> > wrote: >> >> Hi, >> >> >> >> Please find updates patch for the same. >> >> RM#2076 >> >> >> >> -- >> >> Regards, >> >> Murtuza Zabuawala >> >> EnterpriseDB: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> >> >> >> On Wed, Feb 1, 2017 at 3:08 PM, Dave Page wrote: >> >>> >> >>> Hi >> >>> >> >>> On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala >> >>> wrote: >> >>> > Hi Dave, >> >>> > >> >>> > PFA updated patch. >> >>> >> >>> This seems to display "timestamp(0) with[out] timezone" columns >> >>> correctly in both the properties panel and dialog now, but the size is >> >>> still ignored if I try to add a new column through the table or column >> >>> dialogue. >> >>> >> >>> -- >> >>> Dave Page >> >>> Blog: http://pgsnake.blogspot.com >> >>> Twitter: @pgsnake >> >>> >> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >>> The Enterprise PostgreSQL Company >> >> >> >> >> > >> > >> > >> > -- >> > Dave Page >> > Blog: http://pgsnake.blogspot.com >> > Twitter: @pgsnake >> > >> > EnterpriseDB UK: http://www.enterprisedb.com >> > The Enterprise PostgreSQL Company >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a11392664bb33720547d685e0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

Please find a fix for the same= , attribute length was set to False instead of None.


--=
Regards,
Murtuza ZabuawalaE= nterpriseDB:=C2=A0http://www.enter= prisedb.com
The Enterprise PostgreSQL Company

On Mon, Feb 6, 2017 at 11:18 AM, Murtuza Zab= uawala <murtuza.zabuawala@enterprisedb.com>= wrote:
Sure, Checking.<= /div>

--
Regards,
= Murtuz= a Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= /span>

On Sat, Feb 4, 2017 at 7:34 PM, Dave Page <= dpage@pgadmin.org> wrote:
H= i Murtuza,

I clearly neglected to run the regression tests with this patch, and
unfortunately it looks like it broke them. Can you look at this ASAP
please?

runTest (pgadmin.browser.server_groups.servers.databases.schemas.= tables.column.tests.test_column_add.ColumnAddTestCase)
This function will add column under table node. (Add table Node URL)
... 2017-02-04 14:43:55,191: ERROR pgadmin: Failed to execute query
(execute_scalar) for the server #4 - DB:test_db_9e176 (Query-id:
4792242):
Error Message:ERROR:=C2=A0 syntax error at or near "False"
LINE 2:=C2=A0 =C2=A0 =C2=A0ADD COLUMN test_column_add_f0d5d char(False);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
FAIL

As far as I can see, the app works fine - it's only the test that
broke (probably because the application uses type name aliases (e.g.
character) rather than the base type name that the test is using
("char").

Thanks.

On Fri, Feb 3, 2017 at 1:52 PM, Dave Page <dpage@pgadmin.org> wrote:
> Thanks - patch applied.
>
> On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Hi,
>>
>> Please find updates patch for the same.
>> RM#2076
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Wed, Feb 1, 2017 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi
>>>
>>> On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala
>>> <murtuza.zabuawala@enterprisedb.com> wrote:
>>> > Hi Dave,
>>> >
>>> > PFA updated patch.
>>>
>>> This seems to display "timestamp(0) with[out] timezone&qu= ot; columns
>>> correctly in both the properties panel and dialog now, but the= size is
>>> still ignored if I try to add a new column through the table o= r column
>>> dialogue.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a11392664bb33720547d685e0-- --001a11392664bb33780547d685e2 Content-Type: text/plain; charset=US-ASCII; name="fix_attlen_column.diff" Content-Disposition: attachment; filename="fix_attlen_column.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iytp6p7d0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9jb2x1bW4vdGVz dHMvdGVzdF9jb2x1bW5fYWRkLnB5IGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVz L2NvbHVtbi90ZXN0cy90ZXN0X2NvbHVtbl9hZGQucHkKaW5kZXggMjU1NDJk Ny4uZmIyYmJlNyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVz L2NvbHVtbi90ZXN0cy90ZXN0X2NvbHVtbl9hZGQucHkKKysrIGIvd2ViL3Bn YWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2Vz L3NjaGVtYXMvdGFibGVzL2NvbHVtbi90ZXN0cy90ZXN0X2NvbHVtbl9hZGQu cHkKQEAgLTU1LDcgKzU1LDcgQEAgY2xhc3MgQ29sdW1uQWRkVGVzdENhc2Uo QmFzZVRlc3RHZW5lcmF0b3IpOgogICAgICAgICAgICAgICAgICJhdHRhY2wi OiBbXSwKICAgICAgICAgICAgICAgICAiaXNfcHJpbWFyeV9rZXkiOiBGYWxz ZSwKICAgICAgICAgICAgICAgICAiYXR0bm90bnVsbCI6IEZhbHNlLAotICAg ICAgICAgICAgICAgICJhdHRsZW4iOiBGYWxzZSwKKyAgICAgICAgICAgICAg ICAiYXR0bGVuIjogTm9uZSwKICAgICAgICAgICAgICAgICAiYXR0cHJlY2lz aW9uIjogTm9uZSwKICAgICAgICAgICAgICAgICAiYXR0b3B0aW9ucyI6IFtd LAogICAgICAgICAgICAgICAgICJzZWNsYWJlbHMiOiBbXQo= --001a11392664bb33780547d685e2 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a11392664bb33780547d685e2--