Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMVOM-00031w-Hs for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 07:12:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bMVOL-0002rS-7e for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 07:12:33 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bMVO8-0002dl-A5 for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 07:12:20 +0000 Received: from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bMVO5-0004fD-1g for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 07:12:18 +0000 Received: by mail-qk0-x233.google.com with SMTP id 82so83936212qko.3 for ; Mon, 11 Jul 2016 00:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=1nAzZJ81CQUl0OIrFUT0ESqgeZOD0mtrk0qhZFCiB6Y=; b=NXySaSBjdC2EIc0pJPDXGASaq5c/5PhmBXjdfQs153pYP/J6fWxnavGq+sN4fEhn+b pETz2EYx/Bik3ciwcnaD9bYg4U8nsgc2V9BvAXiOFFz2i0/9IQwAap7QlVe3KNPC5TPa 685oPSqLXYZhKbP71rn2/O79q1BF3My3FNjru4lfLk9qAlQ9+4pt+7Ym1GWVx6dvBT/Y 1EnUj6Vz7GzXHZ2UIT2D9Rm9W94im3leXGDgBA56zLNmEsQpE/0v3zKKepp8MnMFOZSq 5Igm3pVYQdYP1miKz+PLblDCVhV9DQnPKNyrss2uE6Dm/jZY6osUYctO0N1nF7VQ1UlZ mPGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=1nAzZJ81CQUl0OIrFUT0ESqgeZOD0mtrk0qhZFCiB6Y=; b=XGJYNKag46ypTlSDnofW19Q1/JGW/3nPLx8lVjz+lP2+FkuXReDsynIF1mFSi2EbLH 5hLZIFdADAbFUNFy7luLSouRKOJBpEGTSgGCBhdlySlcAIEDmH315s+sHftK61MxPnKO mrO/JcHse//ZM71A4hMttuUbPUIOjPemIojAxaYpubbSljjp4HOtM1ESl7WHo1WiAoah jrRa09Z7oIl8dyqRe3gDhLIv7nz4sDVabRf2IuaiwwS5dNCMyNJYdOsx/VzHJzBqIIhn v9ee4NM2EDVS02YoaosyHyOVNPo7n4tNfi7CpGFc3bvR0Cbnnit5mEyj3s/hdCwvX0yM g+Gw== X-Gm-Message-State: ALyK8tJfIw/TbkiSkW7yx2+W/SOF1ijKuf8mwECaYSVb9mmv/VAaTzhSR2k1vgBcVvv3oqnzWdTM6OThXvi0/IqS X-Received: by 10.55.159.87 with SMTP id i84mr24672933qke.115.1468221135864; Mon, 11 Jul 2016 00:12:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.8.3 with HTTP; Mon, 11 Jul 2016 00:11:56 -0700 (PDT) From: Murtuza Zabuawala Date: Mon, 11 Jul 2016 12:41:56 +0530 Message-ID: Subject: PATCH: To fix salt generation in session.py To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114d31b041fb2f053756df6c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114d31b041fb2f053756df6c Content-Type: multipart/alternative; boundary=001a114d31b041fb2b053756df6a --001a114d31b041fb2b053756df6a Content-Type: text/plain; charset=UTF-8 Hi, With latest pull session.py fails with below error with python3 because in python3 strings 'lowercase' method has been renamed to 'ascii_lowercase', PFA patch to fix the issue. Issue: ---------- * File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign* * self.randval = ''.join(random.sample(string.lowercase+string.digits, 20))* *AttributeError: module 'string' has no attribute 'lowercase'* -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114d31b041fb2b053756df6a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

With latest pull session.py fails w= ith below error with python3 because in python3 strings 'lowercase'= method has been renamed to 'ascii_lowercase', PFA patch to fix the= issue.

Issue:
----------
=C2=A0 File "../pgadmin4/web/pgadmin/utils/session.py", line = 59, in sign
=C2=A0 =C2=A0 self.randval =3D ''.join= (random.sample(string.lowercase+string.digits, 20))
Attrib= uteError: module 'string' has no attribute 'lowercase'<= /div>


--Regards,
Murtuza Zabuawala
EnterpriseDB:=C2= =A0http://www.enterprisedb.com=
The Enterprise PostgreSQL Company
--001a114d31b041fb2b053756df6a-- --001a114d31b041fb2f053756df6c Content-Type: application/octet-stream; name="Fix_sessions.patch" Content-Disposition: attachment; filename="Fix_sessions.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iqhoxtfi0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3V0aWxzL3Nlc3Npb24ucHkgYi93 ZWIvcGdhZG1pbi91dGlscy9zZXNzaW9uLnB5CmluZGV4IDlmNzQwZjUuLjBk Y2NhNGQgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3V0aWxzL3Nlc3Npb24u cHkKKysrIGIvd2ViL3BnYWRtaW4vdXRpbHMvc2Vzc2lvbi5weQpAQCAtNTYs NyArNTYsMTUgQEAgY2xhc3MgTWFuYWdlZFNlc3Npb24oQ2FsbGJhY2tEaWN0 LCBTZXNzaW9uTWl4aW4pOgogCiAgICAgZGVmIHNpZ24oc2VsZiwgc2VjcmV0 KToKICAgICAgICAgaWYgbm90IHNlbGYuaG1hY19kaWdlc3Q6Ci0gICAgICAg ICAgICBzZWxmLnJhbmR2YWwgPSAnJy5qb2luKHJhbmRvbS5zYW1wbGUoc3Ry aW5nLmxvd2VyY2FzZStzdHJpbmcuZGlnaXRzLCAyMCkpCisgICAgICAgICAg ICAjIElmIHNjcmlwdCBpcyBydW5uaW5nIHVuZGVyIHB5dGhvbjIKKyAgICAg ICAgICAgIGlmIGhhc2F0dHIoc3RyaW5nLCAnbG93ZXJjYXNlJyk6CisgICAg ICAgICAgICAgICAgcG9wdWxhdGlvbiA9IHN0cmluZy5sb3dlcmNhc2UKKyAg ICAgICAgICAgICMgSWYgc2NyaXB0IGlzIHJ1bm5pbmcgdW5kZXIgcHl0aG9u MworICAgICAgICAgICAgZWxpZiBoYXNhdHRyKHN0cmluZywgJ2FzY2lpX2xv d2VyY2FzZScpOgorICAgICAgICAgICAgICAgIHBvcHVsYXRpb24gPSBzdHJp bmcuYXNjaWlfbG93ZXJjYXNlCisgICAgICAgICAgICBwb3B1bGF0aW9uICs9 IHN0cmluZy5kaWdpdHMKKworICAgICAgICAgICAgc2VsZi5yYW5kdmFsID0g Jycuam9pbihyYW5kb20uc2FtcGxlKHBvcHVsYXRpb24sIDIwKSkKICAgICAg ICAgICAgIHNlbGYuaG1hY19kaWdlc3QgPSBfY2FsY19obWFjKCclczolcycg JSAoc2VsZi5zaWQsIHNlbGYucmFuZHZhbCksIHNlY3JldCkKIAogCg== --001a114d31b041fb2f053756df6c Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114d31b041fb2f053756df6c--