Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2z35-0003qZ-1l for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 May 2016 10:49:55 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b2z34-00024B-FA for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 May 2016 10:49:54 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b2z33-000244-85 for pgadmin-hackers@postgresql.org; Wed, 18 May 2016 10:49:53 +0000 Received: from mail-qk0-x234.google.com ([2607:f8b0:400d:c09::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b2z2z-0000Kd-Ju for pgadmin-hackers@postgresql.org; Wed, 18 May 2016 10:49:51 +0000 Received: by mail-qk0-x234.google.com with SMTP id r184so24328376qkc.1 for ; Wed, 18 May 2016 03:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ibQIvUHAWJP/t8htcXZkhQnw49G9iJJV2vp5c7y4Mco=; b=Ggfa5EvDPVEqUzP8i3fSdtFCL3G0PGAD7wQ2f8jyqBBKyOito9dLxwgSjX5ChwwvGv x+nfgoQ+/Fsb/e1wwVbvNgNZgRQC1NcXcPiMqJD/MelE3b70uR2P51doE+sTlmw4Pril IXnbD0sn4qi2k43aa1LDkcRYbTh7K1eTFyrf3XXmUY5uaaksPG8iq/PcR1pKOelsouB2 50K6FR4MwqABeJtqM2OOb6qwV+9yjtpp+RAKKL7Ivd1VNt/UPgfsp45HMXwagbXo8W/N oNQZrhbtuNO0n/rZEowyMC1tMDFnYcQIfafCA62sKiIeMe92lFpIGNlnb/COgT8cp1A/ O0pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ibQIvUHAWJP/t8htcXZkhQnw49G9iJJV2vp5c7y4Mco=; b=F8ZgDBPok0ACxg4O1DqY7cZ0ajx2rYnB9swE2RwR+B7YHmaF+cLH/AlBWm4KiHt0ht 1ay+vVkShBz8U1D5egJ/UB8cNhbbs2fFKSqUZARKEzVmqUWDPYrgPRh05zHyrpq3pcJK vCdqGrlKdmUUdc0oQ636uBci0rFXKkV7tDume7aijQ4mGaltpn2vS/5U0H0j+p8UZesJ 0yRElwI//TTlVJj9o12XH9ZQn89Pcfn2zspnsdOHjeZgx2A3TVp2OGlh0BISqSVKh2dn ogvz9iSL5WDDRd1BBVxlNEPMDZffS9MqbG11Co/89lKfasfhelwyCc6j87LKrkdbhf4A sV8w== X-Gm-Message-State: AOPr4FXMrGu+O+LoFU4DuI+ii30PpKTW+/NjhzV8Gm+cf2LBqUGvU8mJ9BtnjsDffGmasWVFfddwn7yIYkTNXzHj X-Received: by 10.55.143.129 with SMTP id r123mr6786083qkd.170.1463568588703; Wed, 18 May 2016 03:49:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.207.202 with HTTP; Wed, 18 May 2016 03:49:28 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Wed, 18 May 2016 16:19:28 +0530 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) To: Harshal Dhumal Cc: pgadmin-hackers , Sanket Mehta Content-Type: multipart/mixed; boundary=94eb2c083bc0d5d3e905331b9d64 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c083bc0d5d3e905331b9d64 Content-Type: multipart/alternative; boundary=94eb2c083bc0d5d3e505331b9d62 --94eb2c083bc0d5d3e505331b9d62 Content-Type: text/plain; charset=UTF-8 Hi, PFA table add-on patch version 8.3. (apply after 8.2) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, May 18, 2016 at 3:20 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA table add-on patch version 8.2 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, May 18, 2016 at 2:42 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch for table node (version 8.1). apply this patch on version 7 >> patch. Not all issue are fixed in this patch. Murtuza will be sending >> version 8.2 witch will have resolution for remaining issues. Apply version >> 8.2 patch on version 8.1 >> >> -- >> *Harshal Dhumal* >> *Software Engineer * >> >> >> >> EenterpriseDB >> >> On Tue, May 17, 2016 at 10:12 PM, Sanket Mehta < >> sanket.mehta@enterprisedb.com> wrote: >> >>> Hi Harshal, >>> >>> >>> Below are my review comments: >>> >>> I got below warning when I tried to apply the patch for table node as >>> mentioned below: >>> >>> Table creation: >>> >>> - Trailing white spaces warnings >>> >>> $ git apply >>> /projects/patches/pgadmin4/Table/table_14_May_V6.patch >>> >>> /projects/patches/pgadmin4/Table/table_14_May_V6.patch:6008: trailing >>> whitespace. >>> return false; >>> >>> /projects/patches/pgadmin4/Table/table_14_May_V6.patch:6016: trailing >>> whitespace. >>> return false; >>> warning: 2 lines add whitespace errors. >>> >> >> Fixed (These were introduced due to rules node.) >> >> >>> >>> - In Table creation dialog, while adding a new primary key, it does >>> not allow to change the tablespace to empty. (which is not the case in case >>> of tablespace in table) >>> >>> Fixed >> >>> >>> - In Table creation dialog, while adding a new column, data type and >>> name field must be mandatory. otherwise while clicking on save it gives >>> below error >>> >>> File >>> "/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py", >>> line 1319, in _parse_format_columns >>> c['cltype'] = self._cltype_formatter(c['cltype']) >>> KeyError: 'cltype >>> >> Fixed >> >> >>> >>> - In Table creation dialog, While adding a new column, in primary >>> check box is needed to click twice in order to check it. Ideally it should >>> be checked by only one click. >>> >>> This is Backgrid behaviour. >> >>> >>> - In Table creation dialog, While adding a new column, primary key >>> should not be allowed to added unless user has provided name and data type >>> for at least one column. >>> >>> Fixed >> >>> >>> - currently if user has clicked on add column button and immediately >>> click on add primary key button, it will add a row in primary key data grid >>> >>> Fixed >> >>> >>> - When delete table/drop cascade is apply on any table, i got a >>> javascript error as mentioned below >>> >>> node.js:94 Uncaught TypeError: self.canDrop.apply is >>> not a function >>> >> Already fixed in other commit. >> >> >>> >>> - Once the above error generated, every time user tries to open a >>> context menu by right clicking on any existing table, that same error comes >>> >>> Already fixed in other commit. >> >>> >>> - In table creation dialog, if table is inherited from another >>> table, if a new primary key is added manually there, the create sql will >>> not have an entry for primary key >>> >>> Fixed >> >>> >>> - In table creation dialog, if primary key check box is checked >>> while adding the row, a new row is added in primary key datagrid but >>> unchecking the primary key checkbox from column datagrid, does not removes >>> that row from primary key data grid. >>> >>> Fixed. >> >>> >>> - In AutoVacuum tab, if user provides any invalid value to any >>> parameter, then a error message should be prompted, only background color >>> change would not tell user to change the value. >>> >>> Expected behaviour. >> >>> >>> - In table creation dialog, security label are not being added. >>> javascript error is coming as mentioned below: >>> {"success": 0, "info": "", "result": null, "data": null, >>> "errormsg": "can't adapt type 'Undefined'"} >>> >>> Fixed >> >>> >>> - In Table creation dialog, while adding foreign key, in action tab. >>> if user click on 'x' button in "on update" or "on delete" select2 control, >>> it gives error "Uncaught SyntaxError: Unexpected end of input" >>> >>> Fixed >> >>> >>> - In Table creation dialog, while adding a check constraint, >>> "validated" button does not work properly >>> >>> Fixed. >> >>> >>> - After successfully creation of table, "table name cannot be empty" >>> error is not getting cleared. >>> >>> Not reproducible. >> >>> >>> - In Table creation dialog, if user has added an empty column >>> without entering its name or type and trying to add check constraint, it >>> will add an empty constraint >>> >>> Expected behaviour (Columns are not mandatory for check constrains) >> >>> >>> - In Table creation dialog, while adding an exclude constraint, for >>> "character varying" column type, no operators are being listed >>> >>> There are no operators for character varying data type. >> >>> >>> - In Table creation dialog, while adding an exclude constraint, >>> below mentioned error comes if user removes operator class by clicking 'x' >>> on that control Uncaught TypeError: Cannot read property 'id' of undefined >>> >>> TODO >> >>> >>> - In Table creation dialog, SQL is not getting generated for exclude >>> constraint >>> >>> Fixed >> >>> >>> - In Table creation dialog, schema should be prefixed with table >>> name in "of type" control >>> >>> Fixed >> >>> >>> - In Table creation dialog, while adding privileges, it always shows >>> default privileges even if user has selected different privileges. (This >>> works fine once user edit the privileges in edit table mode and shows only >>> those privileges which user selects). Ashesh, please confirm the behaviour. >>> >>> Privileges are set correctly. Only it shows in incorrect order. >> >> >>> Table edit mode: >>> >>> - If in edit mode, any constraint is already having any comment, >>> then remove it. It will not create the SQL for the same. >>> >>> >> Fixed >> >>> >>> - Changing Schema will give server error >>> >>> This is generic issue for each node. >> >> >>> Column Creation: >>> >>> - Save button is enabled by default >>> - Data type validation is not provided. Save button is enabled just >>> after providing column name >>> - Length field limitation is not provided. (i.e. for numeric type, >>> length should be allowed greater than 1000) >>> >>> *Fixed* > >> Exclusion constraint creation: >>> >>> - Access method should not be allowed to be empty. (currently by >>> clicking 'x' will remove the selection in it) >>> >>> Access method is optional. >> >> >>> Index creation: >>> >>> - No error message for name field when empty >>> - No error message when column name is not provided while adding a >>> column in index >>> - While adding a column if no name is provided, "None" appears in >>> SQL tab which will give error on OK button click >>> - when comment is provided while creation, it gives error saying >>> index does not exists. because schema name is not added before it. >>> >>> *Fixed* > >> Rule creation: >>> >>> - Name is empty error does not come till user enters something in >>> definition tab >>> - DO INSTEAD button does not make any difference to SQL (it works in >>> edit mode) >>> >>> *Surinder will send patch* > >> Rule edit mode: >>> >>> - Add comment in edit mode, check the SQL in sql tab. Now come back >>> to general tab and removes comment and check the sql tab again. >>> SQL for comment is still there with empty string as comment >>> >>> *Surinder will send patch* > >> Trigger Creation: >>> >>> - SQL is not proper when creating a trigger. "()" should be appended >>> to function name in SQL. >>> It gives error while creating a trigger >>> - "+" sign is visible in browser tree in front of trigger. either >>> On expanding trigger, it should show the trigger function name or that "+" >>> sign should not appear >>> >>> *Fixed* > >> Trigger edit node: >>> >> >>> - On removing comment, nothing happens. No sql is being created. >>> Comment is still there in properties. >>> >>> *Fixed* > >> >>> Regards, >>> Sanket Mehta >>> Sr Software engineer >>> Enterprisedb >>> >> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > --94eb2c083bc0d5d3e505331b9d62 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA table add-on= patch version 8.3. (apply after 8.2)


--
Regards,
= Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny

On Wed, May 18, 2016 at 3:20 PM, Murtuza Zab= uawala <murtuza.zabuawala@enterprisedb.com>= wrote:
Hi,

PFA table add-on patch version 8.2
<= br clear=3D"all">
--
<= span style=3D"color:rgb(136,136,136)">Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The = Enterprise PostgreSQL Company

On Wed, May 18, 2016 at 2:42 PM, Harshal Dhu= mal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for tab= le node (version 8.1). apply this patch on version 7 patch. Not all issue a= re fixed in this patch. Murtuza will be sending version 8.2 witch will have= resolution for remaining issues. Apply version 8.2 patch on version 8.1
--=C2=A0
Harshal Dhumal
Software Engineer=C2=A0



On Tue, May 17, 2016 at 10:12 PM, Sanket Meh= ta <sanket.mehta@enterprisedb.com> wrote:
Hi Harshal,


Below are my review comments:

=C2=A0I got below = warning when I tried to apply the patch for table node as mentioned below:<= /div>

Table creation:
  • =C2=A0Trail= ing white spaces warnings=C2=A0
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $ git apply /projects/patc= hes/pgadmin4/Table/table_14_May_V6.patch
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /projects/patches/pgadmin4/Ta= ble/table_14_May_V6.patch:6008: trailing whitespace.
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 return false;=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/projects/patches/pgadmin4/Tab= le/table_14_May_V6.patch:6016: trailing whitespace.
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 return false;=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0warning: 2 lines add whitespace e= rrors.

Fixed (These were introduced = due to rules node.)
=C2=A0
  • In Table creation dialog, while adding a new primary key,= it does not allow to change the tablespace to empty. (which is not the cas= e in case of tablespace in table)
Fi= xed=C2=A0
  • In Table crea= tion dialog, while adding a new column, data type and name field must be ma= ndatory. otherwise while clicking on save it gives below error
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 File= "/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databas= es/schemas/tables/__init__.py", line 1319, in _parse_format_columns
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0c['cltype'] =3D self._cltype_formatter(c['cltype'])
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= KeyError: 'cltype
Fixed
=C2= =A0
  • In Table creation d= ialog, While adding a new column, in primary check box is needed to click t= wice in order to check it. Ideally it should be checked by only one click.<= br>
This is Backgrid behaviour.
  • In Table creation dialog, W= hile adding a new column, primary key should not be allowed to added unless= user has provided name and data type for at least one column.
=C2=A0Fixed
  • currently if user has clicked on add column button = and immediately click on add primary key button, it will add a row in prima= ry key data grid
Fixed=C2=A0
  • When delete table/drop cas= cade is apply on any table, i got a javascript error as mentioned below
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0no= de.js:94 Uncaught TypeError: self.canDrop.apply is not a function
Already fixed in other commit.
=C2=A0
  • Once the above error gen= erated, every time user tries to open a context menu by right clicking on a= ny existing table, that same error comes=C2=A0
Already fixed in other commit.
  • In table creation dialog, if table is inherited from ano= ther table, if a new primary key is added manually there, the create sql wi= ll not have an entry for primary key
Fixed=C2=A0
  • In table c= reation dialog, if primary key check box is checked while adding the row, a= new row is added in primary key datagrid but unchecking the primary key ch= eckbox from column datagrid, does not removes that row from primary key dat= a grid.
Fixed.=C2=A0
  • In AutoVacuum tab, if user provide= s any invalid value to any parameter, then a error message should be prompt= ed, only background color change would not tell user to change the value.
Expected =C2=A0behaviour.
  • In table creation dialog, security= label are not being added. javascript error is coming as mentioned below:<= br>=C2=A0=C2=A0{"= ;success": 0, "info": "", "result": null= , "data": null, "errormsg": "can't adapt type = 'Undefined'"}
= =C2=A0Fixed
  • In Table creation dialog,= while adding foreign key, in action tab. if user click on 'x' but= ton in "on update" or "on delete" select2 control, it g= ives error "Uncaught SyntaxError: Unexpected end of input"=
Fixed
  • In Table creation dialog, while adding a check constra= int, "validated" button does not work properly
    • =
Fixed.=C2=A0
  • After successfully creation of table, "table name cannot be= empty" error is not getting cleared.
Not reproducible.=C2=A0
  • In Table creation dialog, if user has added an empty column wit= hout entering its name or type and trying to add check constraint, it will = add an empty constraint
=C2=A0Expected =C2=A0behaviour (Columns are not mandatory for check const= rains)
  • In Table creation dialog, whil= e adding an exclude constraint, for "character varying" column ty= pe, no operators are being listed
=C2=A0There are no operators for=C2=A0character varying data type.
  • In Table creation dialog, while adding an exclu= de constraint, below mentioned error comes if user removes operator class b= y clicking 'x' on that control Uncaught TypeError: Cannot read property 'id' of unde= fined
=C2=A0TODO
=
  • In Table creation dialog, SQL is not getti= ng generated for exclude constraint
Fixed
  • In Table creation= dialog, schema should be prefixed with table name in "of type" c= ontrol
=C2=A0Fixed
  • In Table creation dialog, while adding p= rivileges, it always shows default privileges even if user has selected dif= ferent privileges. (This works fine once user edit the privileges in edit t= able mode and shows only those privileges which user selects).=20 Ashesh, please confirm the behaviour.
= Privileges are set correctly. Only it shows in incorrect order.
<= /div>
=C2=A0
Table edit mode:=
  • If in edit mode, any constraint is already having any comment, = then remove it. It will not create the SQL for the same.
    • =

Fixed=C2=A0
  • <= span style=3D"white-space:pre-wrap">Changing Schema will give server error<= /span>
This is generic = issue for each node.
=C2=A0
Co= lumn Creation:
  • Save button is enabled by default
  • = Data type validation is not provided. Save button is enabled just after pro= viding column name
  • Length field limitation is not provided. (i.e. f= or numeric type, length should be allowed greater than 1000)<= /li>
=
=
Fixed=C2=A0
Exclusion constraint creation:
  • = Access method should not be allowed to be empty. (currently by clicking = 9;x' will remove the selection in it)
Access method is optional.
=C2=A0
Index creation:
  • No error message for name field when empty
  • No error message wh= en column name is not provided while adding a column in index
  • While= adding a column if no name is provided, "None" appears in SQL ta= b which will give error on OK button click
  • when comment is provided= while creation, it gives error saying index does not exists. because schem= a name is not added before it.
    • Fixed=C2=A0
    Rule crea= tion:
    • Name is empty error does not come till = user enters something in definition tab
    • DO INSTEAD button does not = make any difference to SQL (it works in edit mode)
    Surinder = will send patch=C2=A0
    Rule edit mode:
    • Add comment in e= dit mode, check the SQL in sql tab. Now come back to general tab and remove= s comment and check the sql tab again.
      SQL for comment is still there wi= th empty string as comment
    Surinder will send patch=C2= =A0
    =
    Trig= ger Creation:
    • SQL is not proper when creating a tri= gger. "()" should be appended to function name in SQL.
      It give= s error while creating a trigger
    • "+" sign is visible in b= rowser tree in front of trigger. =C2=A0either On expanding trigger, it shou= ld show the trigger function name or that "+" sign should not app= ear
    Fixed=C2=A0
    <= div>
    =
    Trigger edit node:
    • On removing comment, nothin= g happens. No sql is being created. Comment is still there in properties.= =C2=A0
    Fixed=C2=A0

    Regards,
    Sank= et Mehta
    Sr Software engineer
    Enterprisedb
    <= /div>



    --
    Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
    To make changes to your subscription:
    http://www.postgresql.org/mailpref/pgadmin-hackers=



    --94eb2c083bc0d5d3e505331b9d62-- --94eb2c083bc0d5d3e905331b9d64 Content-Type: application/octet-stream; name="table_v8.3.patch" Content-Disposition: attachment; filename="table_v8.3.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iocqxe6l1 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9jb2x1bW4vdGVt cGxhdGVzL2NvbHVtbi9qcy9jb2x1bW4uanMgYi93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90 YWJsZXMvY29sdW1uL3RlbXBsYXRlcy9jb2x1bW4vanMvY29sdW1uLmpzCmlu ZGV4IDY4OGFjMjQuLjAwOWJjNGIgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWlu L2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hl bWFzL3RhYmxlcy9jb2x1bW4vdGVtcGxhdGVzL2NvbHVtbi9qcy9jb2x1bW4u anMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3Nl cnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL2NvbHVtbi90ZW1wbGF0 ZXMvY29sdW1uL2pzL2NvbHVtbi5qcwpAQCAtNDIzLDcgKzQyMyw3IEBAIGZ1 bmN0aW9uKCQsIF8sIFMsIHBnQWRtaW4sIHBnQnJvd3NlciwgQmFja2Zvcm0s IGFsZXJ0aWZ5KSB7CiAgICAgICAgICAgICAgIG1zZyA9IHVuZGVmaW5lZDsK IAogICAgICAgICAgIC8vIE5vdGhpbmcgdG8gdmFsaWRhdGUKLSAgICAgICAg ICBpZiAoa2V5cy5sZW5ndGggPT0gMCkgeworICAgICAgICAgIGlmIChrZXlz ICYmIGtleXMubGVuZ3RoID09IDApIHsKICAgICAgICAgICAgIHRoaXMuZXJy b3JNb2RlbC5jbGVhcigpOwogICAgICAgICAgICAgcmV0dXJuIG51bGw7CiAg ICAgICAgICAgfSBlbHNlIHsKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jy b3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFz L3RhYmxlcy9pbmRleGVzL3RlbXBsYXRlcy9pbmRleC9qcy9pbmRleC5qcyBi L3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9pbmRleGVzL3RlbXBsYXRlcy9pbmRl eC9qcy9pbmRleC5qcwppbmRleCA1NmNjMGRmLi5iNDk0OTJhIDEwMDY0NAot LS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVy cy9kYXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvaW5kZXhlcy90ZW1wbGF0ZXMv aW5kZXgvanMvaW5kZXguanMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVz L2luZGV4ZXMvdGVtcGxhdGVzL2luZGV4L2pzL2luZGV4LmpzCkBAIC0zMDEs NyArMzAxLDcgQEAgZnVuY3Rpb24oJCwgXywgUywgcGdBZG1pbiwgcGdCcm93 c2VyLCBCYWNrZm9ybSwgYWxlcnRpZnkpIHsKICAgICAgICAgICAgICAgbXNn ID0gdW5kZWZpbmVkOwogCiAgICAgICAgICAgLy8gTm90aGluZyB0byB2YWxp ZGF0ZQotICAgICAgICAgIGlmIChrZXlzLmxlbmd0aCA9PSAwKSB7CisgICAg ICAgICAgaWYgKGtleXMgJiYga2V5cy5sZW5ndGggPT0gMCkgewogICAgICAg ICAgICAgdGhpcy5lcnJvck1vZGVsLmNsZWFyKCk7CiAgICAgICAgICAgICBy ZXR1cm4gbnVsbDsKICAgICAgICAgICB9IGVsc2Ugewo= --94eb2c083bc0d5d3e905331b9d64 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --94eb2c083bc0d5d3e905331b9d64--