Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dECFL-0003Z4-UA for pgadmin-hackers@arkaria.postgresql.org; Fri, 26 May 2017 10:13:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dECFK-0007ch-El for pgadmin-hackers@arkaria.postgresql.org; Fri, 26 May 2017 10:13:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dECFI-0007cS-QU for pgadmin-hackers@postgresql.org; Fri, 26 May 2017 10:13:24 +0000 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dECFD-0002Di-8l for pgadmin-hackers@postgresql.org; Fri, 26 May 2017 10:13:24 +0000 Received: by mail-wm0-x234.google.com with SMTP id 123so5099612wmg.1 for ; Fri, 26 May 2017 03:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=Z4S/mu9aZbVA3KqN0M8lGAypI7BRHufjnyOI5oQDaA4=; b=vFl0NThFpFOzcAzhptRP6OPyBPs3NxmQdPKQE7Xuyzu8gCqCAUC7LAbFCTfgLn/hG8 zef93wjaFVVzfvQJomcKrDWofI5eprXEhK2N/Cltd6naT2TLEip5KGz76NgGrKbmmcYG InMEOaAIrnwmhsqATXOFAmmw1gdOv8NCMLfQhRCI0QQuzUPVb8WRUPbPoJkFNT5pPd/T /5BozPXo27B9qSfvKwZpkXJggss7pfwcTFtcmgR7YVC4RMoVSsn0Ro+NbfwYQHXhkX2U 6jUEisUCiPDoSkVBMluE7p9t5SC4V9RTWuO446V2LRkHjUgUYSutIq8ome8BbZKvvtzi lLrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Z4S/mu9aZbVA3KqN0M8lGAypI7BRHufjnyOI5oQDaA4=; b=TjT2CUxYiebRsfLu7vp0vr6z5ugkEL3IG6tTEojbfnmomGWLmLtfnPCV9dUsGUMcP8 QPGm8A+morvdtqtWdZV8Lu2fiX9u4Ha79j0at/upiPG4+LJV5r17lEgSk3+Gjpe8qhEC zGw+8COJu1GqrTK/mggkaVdX6VSzmWraovpJsOq/RSIiXT+b7sFW6bWA24b2bBsk8WhV 64hw74+t3ACceF0mXmrZ2vOPZGMxgOOXgmW7/R6zYJZGpunmn0nQXSaQJ2aaTk+nB2AC W63jR/nKT9jvlL4MvFJjs8QFoJ2Mj6om8nW8LoDEXEOaVRQIPSCYuSHcYFFl/JDBgHvP w9xg== X-Gm-Message-State: AODbwcC+yOP0EPjkxvNiyXpqNNaf49QoDKSti7Ic5LnhuYvwlABVOtT3 A0a6fXET01VrqyIyUC6X7Z9K4DWzOabYNfE= X-Received: by 10.223.136.252 with SMTP id g57mr1003036wrg.191.1495793595715; Fri, 26 May 2017 03:13:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.136.70 with HTTP; Fri, 26 May 2017 03:12:55 -0700 (PDT) From: Murtuza Zabuawala Date: Fri, 26 May 2017 15:42:55 +0530 Message-ID: Subject: [pgAdmin4] [PATCH] To fix issue in UPDATE Script and Primary key order when view data To: pgadmin-hackers Content-Type: multipart/mixed; boundary="001a11491864ee471a05506a9547" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11491864ee471a05506a9547 Content-Type: multipart/alternative; boundary="001a11491864ee471705506a9545" --001a11491864ee471705506a9545 Content-Type: text/plain; charset="UTF-8" Hi, PFA patch to fix the issue in table node, 1) In 'UPDATE Script', '?' is missing with last column. 2) If there are multiple primary keys in table then the order of columns is incorrect in view data ORDER BY clause. RM#2417 Also fixed minor issue in Materialized view which I found during testing, we were not passing database id in properties.sql which is required for Select and Insert script to work. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a11491864ee471705506a9545 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

PFA patch to fix the issue in table= node,=C2=A0
1) In 'UPDATE Script', '?' is missin= g with last column.=C2=A0
2) If there are multiple primary keys i= n table then the order of columns is incorrect in view data ORDER BY clause= .
RM#2417

Also fixed minor issue in Mate= rialized view which I found during testing, we were not passing database id= in properties.sql which is required for Select and Insert script to work.<= /div>

--
= Regards,
Murtuza Z= abuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--001a11491864ee471705506a9545-- --001a11491864ee471a05506a9547 Content-Type: text/plain; charset="US-ASCII"; name="RM_2417.diff" Content-Disposition: attachment; filename="RM_2417.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j35opvpn0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9fX2luaXRfXy5w eSBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJz L2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9fX2luaXRfXy5weQppbmRleCA1 NGJhYjBkLi45OWYwZGRjIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90 YWJsZXMvX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVz L19faW5pdF9fLnB5CkBAIC0yODcwLDkgKzI4NzAsOSBAQCBjbGFzcyBUYWJs ZVZpZXcoUEdDaGlsZE5vZGVWaWV3LCBEYXRhVHlwZVJlYWRlciwgVmFjdXVt U2V0dGluZ3MpOgogICAgICAgICBpZiBsZW4oY29sdW1ucykgPiAwOgogICAg ICAgICAgICAgaWYgbGVuKGNvbHVtbnMpID09IDE6CiAgICAgICAgICAgICAg ICAgY29sdW1ucyA9IGNvbHVtbnNbMF0KLSAgICAgICAgICAgICAgICBjb2x1 bW5zICs9ICI9PyIKICAgICAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICAg ICAgY29sdW1ucyA9ICI9PywgIi5qb2luKGNvbHVtbnMpCisgICAgICAgICAg ICBjb2x1bW5zICs9ICI9PyIKIAogICAgICAgICAgICAgc3FsID0gdSJVUERB VEUgezB9XG5cdFNFVCB7MX1cblx0V0hFUkUgPGNvbmRpdGlvbj47Ii5mb3Jt YXQoCiAgICAgICAgICAgICAgICAgc2VsZi5xdElkZW50KHNlbGYuY29ubiwg ZGF0YVsnc2NoZW1hJ10sIGRhdGFbJ25hbWUnXSksCmRpZmYgLS1naXQgYS93 ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRh YmFzZXMvc2NoZW1hcy92aWV3cy9fX2luaXRfXy5weSBiL3dlYi9wZ2FkbWlu L2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hl bWFzL3ZpZXdzL19faW5pdF9fLnB5CmluZGV4IDBlYWQ0MzcuLjgzNjAxOGIg MTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3ZpZXdzL19faW5pdF9fLnB5 CisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2 ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3ZpZXdzL19faW5pdF9fLnB5CkBAIC0x MTE5LDcgKzExMTksNyBAQCBjbGFzcyBWaWV3Tm9kZShQR0NoaWxkTm9kZVZp ZXcsIFZhY3V1bVNldHRpbmdzKToKICAgICAgICAgICAgICIvIi5qb2luKFsK ICAgICAgICAgICAgICAgICBzZWxmLnRlbXBsYXRlX3BhdGgsICdzcWwvcHJv cGVydGllcy5zcWwnCiAgICAgICAgICAgICBdKSwKLSAgICAgICAgICAgIHNj aWQ9c2NpZCwgdmlkPXZpZCwKKyAgICAgICAgICAgIHNjaWQ9c2NpZCwgdmlk PXZpZCwgZGlkPWRpZCwKICAgICAgICAgICAgIGRhdGxhc3RzeXNvaWQ9c2Vs Zi5kYXRsYXN0c3lzb2lkCiAgICAgICAgICkKICAgICAgICAgc3RhdHVzLCBy ZXMgPSBzZWxmLmNvbm4uZXhlY3V0ZV9kaWN0KFNRTCkKQEAgLTExODAsNyAr MTE4MCw3IEBAIGNsYXNzIFZpZXdOb2RlKFBHQ2hpbGROb2RlVmlldywgVmFj dXVtU2V0dGluZ3MpOgogICAgICAgICAgICAgIi8iLmpvaW4oWwogICAgICAg ICAgICAgICAgIHNlbGYudGVtcGxhdGVfcGF0aCwgJ3NxbC9wcm9wZXJ0aWVz LnNxbCcKICAgICAgICAgICAgIF0pLAotICAgICAgICAgICAgc2NpZD1zY2lk LCB2aWQ9dmlkLAorICAgICAgICAgICAgc2NpZD1zY2lkLCB2aWQ9dmlkLCBk aWQ9ZGlkLAogICAgICAgICAgICAgZGF0bGFzdHN5c29pZD1zZWxmLmRhdGxh c3RzeXNvaWQKICAgICAgICAgKQogICAgICAgICBzdGF0dXMsIHJlcyA9IHNl bGYuY29ubi5leGVjdXRlX2RpY3QoU1FMKQpkaWZmIC0tZ2l0IGEvd2ViL3Bn YWRtaW4vdG9vbHMvc3FsZWRpdG9yL2NvbW1hbmQucHkgYi93ZWIvcGdhZG1p bi90b29scy9zcWxlZGl0b3IvY29tbWFuZC5weQppbmRleCAyYmI5MGMyLi45 ZWQ5MTU0IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0 b3IvY29tbWFuZC5weQorKysgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0 b3IvY29tbWFuZC5weQpAQCAtMTAsNyArMTAsNyBAQAogIiIiIEltcGxlbWVu dGVkIGNsYXNzZXMgZm9yIHRoZSBkaWZmZXJlbnQgb2JqZWN0IHR5cGUgdXNl ZCBieSBkYXRhIGdyaWQgIiIiCiAKIGZyb20gYWJjIGltcG9ydCBBQkNNZXRh LCBhYnN0cmFjdG1ldGhvZAotCitmcm9tIGNvbGxlY3Rpb25zIGltcG9ydCBP cmRlcmVkRGljdAogaW1wb3J0IHNpeAogZnJvbSBmbGFzayBpbXBvcnQgcmVu ZGVyX3RlbXBsYXRlCiBmcm9tIGZsYXNrX2JhYmVsIGltcG9ydCBnZXR0ZXh0 CkBAIC0zNjgsNyArMzY4LDcgQEAgY2xhc3MgVGFibGVDb21tYW5kKEdyaWRD b21tYW5kKToKICAgICAgICAgY29ubiA9IG1hbmFnZXIuY29ubmVjdGlvbihk aWQ9c2VsZi5kaWQsIGNvbm5faWQ9c2VsZi5jb25uX2lkKQogCiAgICAgICAg IHBrX25hbWVzID0gJycKLSAgICAgICAgcHJpbWFyeV9rZXlzID0gZGljdCgp CisgICAgICAgIHByaW1hcnlfa2V5cyA9IE9yZGVyZWREaWN0KCkKIAogICAg ICAgICBpZiBjb25uLmNvbm5lY3RlZCgpOgogCg== --001a11491864ee471a05506a9547 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a11491864ee471a05506a9547--