Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ew0YQ-0004AK-Mn for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 07:10:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ew0YO-0002Yy-SL for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 07:10:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ew0YO-0002Ug-Gf for pgadmin-hackers@lists.postgresql.org; Wed, 14 Mar 2018 07:10:28 +0000 Received: from mail-ot0-x230.google.com ([2607:f8b0:4003:c0f::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ew0YF-0002qL-WE for pgadmin-hackers@postgresql.org; Wed, 14 Mar 2018 07:10:27 +0000 Received: by mail-ot0-x230.google.com with SMTP id y11-v6so2275602otg.0 for ; Wed, 14 Mar 2018 00:10:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hzsbtg3chvKXIo4/MYSmR1CgJEZCxvX/+lklT72My8Q=; b=r78q2N6yX0CK9nljpVF12D75rseT1u35C/2n3VB7QlsUn4VnuqYEqOzsqRKwa3X7Vy RwtonsDv3f6BCC86f6pu7w9Bc7ba022sSneFEl8DdW1/WIQqbtz3KZEjtDFdOgHfg5G3 PGoWNwt3ZKh/k2ZXtAgsDbVIZPQwAwpCG6PhDSBR5oJdf0qD9A6INdd1t4p420gDsJIG 3OiRUl/fppg1B0dNMcGqmv3Jyeb35OezaO0W96ZZjD0oqAvWCb2Ex2ogdXFSo+yuchFP vyC5dS/GzeLMKDBWVOqUXo1+3okx8iehdjvTTEfuuCnkrQLFWuAzXVkGKYoi2T6BNstZ tjjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hzsbtg3chvKXIo4/MYSmR1CgJEZCxvX/+lklT72My8Q=; b=EzoT9OmswQRqPKCB+iJ1Ifu7cNN9PplLs7EUtQoEyKmm6okDMyMa6SjjpBWh6Qmi2A dQlkoZW4XA27SXgQ+gYo+XycJIePnisd7UatJm9j4jjqpPGaIYKWtLvLCVdpXXseL/ux xWaFEdGaNN3x1rZdEMZoHBmACiwkz85Ja+jjC/iRiQrKqfGQsz+jJQyW3S827zrAZSOA Npiz1y780VEOuACk9OIspmfifK/2PBuvZWzjU5bXt8ycT9aQSZlFGj8Bn0g2uFJuiHel wEDETHpQZxNx24VkINxKmH+32B0FE4+06Y9qVDnVs/ippCUgl+uA+++D+y8yS7TjL/lz TzlA== X-Gm-Message-State: AElRT7EV5KCazQXdpWqd0gV040utxzU6uHDIpi9jXfi4NDrkf3CIrKPP /dORQmZlnmbHWiMbHrFDA7gevcDaEO+D/xQ7Ob1OFQ== X-Google-Smtp-Source: AG47ELvS9/zqZc9CABl9XwgZ2oCUasY6a3j2Y35A5xp9iNLQFcxDq4R88lBFHkDZk02LDT3cUR5kX4/gtq/FAmCFl0Y= X-Received: by 10.157.80.34 with SMTP id a34mr2170760oth.79.1521011417608; Wed, 14 Mar 2018 00:10:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Wed, 14 Mar 2018 00:09:57 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Wed, 14 Mar 2018 12:39:57 +0530 Message-ID: Subject: Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f4030435abd03f15f005675a116d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f4030435abd03f15f005675a116d Content-Type: text/plain; charset="UTF-8" Hi Khushboo, We can simplify this, we don't need to create any extra column, Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322 where we are setting ENV variable we can create common utility function (let say in ../tools/utils/__init__.py) which will set all required the environment variables and then we will pass that function in p.start(..) method. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Mar 14, 2018 at 11:03 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #3122 : Backup not working on > certificate (SSL) protected servers. > > The attached patch fixes the issue in the following modules: > > 1. Backup > 2. Restore > 3. Import/Export > 4. Maintenance > > Thanks, > Khushboo > > > --f4030435abd03f15f005675a116d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo,

=
We can simplify this, we don't need to create any extra = column,

Check: ../pgadmin4/web/pgadmin/tools/import_exp= ort/__init__.py +322 where we are setting ENV variable we can create= common utility function (let say in ../tools/utils/__init__.py) which will= set all required the environment variables and then we will pass that func= tion in p.start(..) method.


=
--=
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enter= prisedb.com
The Enterprise PostgreSQL Company
=

On Wed, Mar 14, 2018 at 11:03 AM, Khushboo V= ashi <khushboo.vashi@enterprisedb.com> wrote:<= br>
Hi,

P= lease find the attached patch to fix RM #3122 :=C2=A0Backup not working on = certificate (SSL) protected servers.

The attached = patch fixes the issue in the following modules:

1.= Backup
2. Restore
3. Import/Export
4. Mainte= nance

Thanks,
Khushboo



--f4030435abd03f15f005675a116d--