public inbox for [email protected]
help / color / mirror / Atom feedPATCH: Fixed select2 control template [pgAdmin4]
2+ messages / 2 participants
[nested] [flat]
* PATCH: Fixed select2 control template [pgAdmin4]
@ 2016-03-25 12:13 Murtuza Zabuawala <[email protected]>
2016-04-01 09:48 ` Re: PATCH: Fixed select2 control template [pgAdmin4] Ashesh Vashi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Murtuza Zabuawala @ 2016-03-25 12:13 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA minor patch to fix backform Select2 control template.
*Issue:* It was not rendering value properly.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] fixed_select2_template.patch (1019B, 3-fixed_select2_template.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/static/js/node.ui.js b/web/pgadmin/browser/static/js/node.ui.js
index f127d52..4d69e1f 100644
--- a/web/pgadmin/browser/static/js/node.ui.js
+++ b/web/pgadmin/browser/static/js/node.ui.js
@@ -50,7 +50,7 @@ function($, _, pgAdmin, Backbone, Backform, Alertify, Node) {
template: _.template([
'<label class="<%=Backform.controlLabelClassName%>"><%=label%></label>',
'<div class="<%=Backform.controlsClassName%> <%=extraClasses.join(\' \')%>">',
- ' <select class="pgadmin-node-select form-control" name="<%=name%>" style="width:100%;" value=<%-value%> <%=disabled ? "disabled" : ""%> <%=required ? "required" : ""%> >',
+ ' <select class="pgadmin-node-select form-control" name="<%=name%>" style="width:100%;" value="<%-value%>" <%=disabled ? "disabled" : ""%> <%=required ? "required" : ""%> >',
' <% if (first_empty) { %>',
' <option value="" <%="" === rawValue ? "selected" : "" %>><%- empty_value %></option>',
' <% } %>',
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: PATCH: Fixed select2 control template [pgAdmin4]
2016-03-25 12:13 PATCH: Fixed select2 control template [pgAdmin4] Murtuza Zabuawala <[email protected]>
@ 2016-04-01 09:48 ` Ashesh Vashi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Ashesh Vashi @ 2016-04-01 09:48 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
On Fri, Mar 25, 2016 at 5:43 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA minor patch to fix backform Select2 control template.
>
> *Issue:* It was not rendering value properly.
>
Thanks - committed.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-04-01 09:48 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-03-25 12:13 PATCH: Fixed select2 control template [pgAdmin4] Murtuza Zabuawala <[email protected]>
2016-04-01 09:48 ` Ashesh Vashi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox