Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fTl30-0005Ws-9m for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jun 2018 09:29:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fTl2y-0005g2-TA for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jun 2018 09:29:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fThq2-0000Ia-6d for pgadmin-hackers@lists.postgresql.org; Fri, 15 Jun 2018 06:03:58 +0000 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fThpy-0004V7-Qx for pgadmin-hackers@postgresql.org; Fri, 15 Jun 2018 06:03:57 +0000 Received: by mail-wm0-x22d.google.com with SMTP id r15-v6so1601288wmc.1 for ; Thu, 14 Jun 2018 23:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fLCYefHGV99pk13if1gPIzsPd++VGTbnyTvbVZcpj3c=; b=U24iNnaU0bo7lcpCELPjmKAq5GXGohQ0VcgDr/QCXh+eZhqLwvQ4/czuRu8RhGdpPE XbfCE4WhMk3sCIT4xszbhw9gGkwgSxxmkJ2wpgJUFi3V/eltekyq3bQ3DX1i9u6wqFBa vklLjsqglKwPNRfl97gMr8+ou/NRjn05Nq0s45mZ2uc0Br+5sYdYPwO1f7s6aPkM9Mhs iKJCkljRYCPn5PkrnK8FCVn5yl6HUYw3gy81l/0tjRnnZ2+topJLOhd4An64cNLpxxqi UOv0bVh5QvY9BFgXmK+ygIcPpfqwmKQrr67pKMtmuRGIumJFaeukIuaGp4KsuEa8BPYj F1yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fLCYefHGV99pk13if1gPIzsPd++VGTbnyTvbVZcpj3c=; b=tTydBxjh3hxY56QHriGMR+4mYrNBXRZW8i1X/NBBRjw+qFcKIfzFwWAi9RfIocJiPf ZInkPuk1nbf4Q66SKeVUjCW6vufXiW4Ibjig/q5pv3ljQ1pBL5Zq5jwKnR0FSn4TME3e /tRkqWY4gonteeiKFqrHE9bgYCcqAOJVXSQ2t6XePDiml+rPVIiawgWvawwj8V4EGhk+ GKHNVdaP41RxUaAsTRCoKycyCr0utpqu720Sd2gRGBj8hbG0Ft3yYGjoWYl74ZrqLbd/ RX75eeEO4V40rXm3mtTgT1BGanXpNFOu4Mf+QqLmOqrGh/Kb/PUwzbqjRygsYiQ+Oyia HMOw== X-Gm-Message-State: APt69E34n/Q9Ht7RSdtde5LWr1c4t3BbPHmFeEH69aYNZv+vAK8v+TyF fEp2K6uMgHzkh5qA8+xVlpSSS4G3KLdBXGLbJgY0zg== X-Google-Smtp-Source: ADUXVKJ7DVqBWlCLnm85EUBfDxAqtfAzFdGSGhm+nj5evFAXcYOsJXlN3xCThyWXp17a/OX3Vulqh2/cqN16KXT5R18= X-Received: by 2002:a1c:800e:: with SMTP id b14-v6mr66719wmd.83.1529042632930; Thu, 14 Jun 2018 23:03:52 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:972a:0:0:0:0:0 with HTTP; Thu, 14 Jun 2018 23:03:32 -0700 (PDT) In-Reply-To: References: From: Shubham Agarwal Date: Fri, 15 Jun 2018 11:33:32 +0530 Message-ID: Subject: Re: pgadmin_page functions updated To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000fb933f056ea7fa41" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000fb933f056ea7fa41 Content-Type: text/plain; charset="UTF-8" Hi Khushboo, Yes i agree, currently we are not changing the functions that are already written but will use css selectors in all the upcoming new test cases. Thanks and regards, Shubham Agarwal On Fri, Jun 15, 2018 at 11:02 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Shubham, > > On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal < > shubham.agarwal@enterprisedb.com> wrote: > >> Hi Team, >> >> I have modified following two functions in pgadmin_page.py :- >> >> 1. click_tab() -> Added wait till element is clickable, test cases are >> failing since the function attempts to click the tab which is not yet in >> the state to be clicked. >> >> 2. add_server() -> Replaced the sleep statement with wait till element to >> be clickable. >> >> Please find the attached patch. >> >> We should start using CSS selectors instead of xpath, otherwise the patch > works fine and also changes look good to me. > >> -- >> Thanks & Regards, >> Shubham Agarwal >> EnterpriseDB Corporation >> >> The Postgres Database Company >> > > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company --000000000000fb933f056ea7fa41 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo,

Yes i agree, currently we = are not changing the functions that are already written but will use css se= lectors in all the upcoming new test cases.

Thanks= and regards,
Shubham Agarwal

On Fri, Jun 15, 2018 at 11:02 AM, Khushbo= o Vashi <khushboo.vashi@enterprisedb.com> wrot= e:
Hi Shubham,

On Thu= , Jun 14, 2018 at 3:25 PM, Shubham Agarwal <shubham.agarwal= @enterprisedb.com> wrote:
Hi Team,

I have modified following = two functions in pgadmin_page.py :-

1. click_tab()= -> Added wait till element is clickable, test cases are failing since t= he function attempts to click the tab which is not yet in the state to be c= licked.

2. add_server() -> Replaced the sleep s= tatement with wait till element to be clickable.=C2=A0

=
Please find the attached patch.

We should start using CSS selectors i= nstead of xpath, otherwise the patch works fine and also changes look good = to me.
=
--
Thanks &= Regards,
Shubham Agarwal
EnterpriseDB Corporat= ion

The Postgres Data= base Company




--
Thanks = & Regards,
Shubham Agarwal
EnterpriseDB Cor= poration

The Postgres D= atabase Company
--000000000000fb933f056ea7fa41--