MIME-Version: 1.0
From: Shubham Agarwal <shubham.agarwal@enterprisedb.com>
Date: Thu, 14 Jun 2018 15:25:33 +0530
Message-ID: 
 <CAKbCA9Rk0PKsMxC95MJhqK=WeDWoizDKiXBZar+uuRe42obq3Q@mail.gmail.com>
Subject: pgadmin_page functions updated
To: pgadmin-hackers@postgresql.org
Content-Type: multipart/mixed; boundary="000000000000e7737e056e971aed"
Precedence: bulk

--000000000000e7737e056e971aed
Content-Type: multipart/alternative; boundary="000000000000e7737b056e971aeb"

--000000000000e7737b056e971aeb
Content-Type: text/plain; charset="UTF-8"

Hi Team,

I have modified following two functions in pgadmin_page.py :-

1. click_tab() -> Added wait till element is clickable, test cases are
failing since the function attempts to click the tab which is not yet in
the state to be clicked.

2. add_server() -> Replaced the sleep statement with wait till element to
be clickable.

Please find the attached patch.

-- 
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company

--000000000000e7737b056e971aeb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Team,<div><br></div><div>I have modified following two =
functions in pgadmin_page.py :-</div><div><br></div><div>1. click_tab() -&g=
t; Added wait till element is clickable, test cases are failing since the f=
unction attempts to click the tab which is not yet in the state to be click=
ed.</div><div><br></div><div>2. add_server() -&gt; Replaced the sleep state=
ment with wait till element to be clickable.=C2=A0</div><div><br></div><div=
>Please find the attached patch.<br clear=3D"all"><div><br></div>-- <br><di=
v class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div dir=3D"=
ltr"><div dir=3D"ltr"><span style=3D"color:rgb(38,38,38);line-height:16px">=
Thanks &amp; Regards,</span><br style=3D"color:rgb(38,38,38);line-height:16=
px"><font color=3D"#262626">Shubham Agarwal</font></div><div dir=3D"ltr"><d=
iv style=3D"color:rgb(80,0,80);font-size:12.8px"><font size=3D"2">Enterpris=
eDB Corporation</font></div><div style=3D"color:rgb(80,0,80);font-size:12.8=
px"><font size=3D"2"><img src=3D"https://docs.google.com/uc?export=3Ddownlo=
ad&amp;id=3D0B-_HQksrSBCJWUhucjJiNHF3WUk&amp;revid=3D0B-_HQksrSBCJby9kamhhT=
mlVNFhwRUlJS1YzcFoxVWVXeXZjPQ" width=3D"96" height=3D"54"><br></font></div>=
<div style=3D"color:rgb(80,0,80);font-size:12.8px"><font size=3D"2">The Pos=
tgres Database Company</font></div></div></div></div>
</div></div>

--000000000000e7737b056e971aeb--

--000000000000e7737e056e971aed
Content-Type: application/octet-stream; name="pgadmin_page.patch"
Content-Disposition: attachment; filename="pgadmin_page.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_jiedb5fw0

ZGlmZiAtLWdpdCBhL3dlYi9yZWdyZXNzaW9uL2ZlYXR1cmVfdXRpbHMvcGdhZG1pbl9wYWdlLnB5
IGIvd2ViL3JlZ3Jlc3Npb24vZmVhdHVyZV91dGlscy9wZ2FkbWluX3BhZ2UucHkKaW5kZXggNzg1
NzhhMi4uODBmMGNhNyAxMDA2NDQKLS0tIGEvd2ViL3JlZ3Jlc3Npb24vZmVhdHVyZV91dGlscy9w
Z2FkbWluX3BhZ2UucHkKKysrIGIvd2ViL3JlZ3Jlc3Npb24vZmVhdHVyZV91dGlscy9wZ2FkbWlu
X3BhZ2UucHkKQEAgLTYwLDggKzYwLDggQEAgY2xhc3MgUGdhZG1pblBhZ2U6CiAgICAgICAgIHNl
bGYuZmlsbF9pbnB1dF9ieV9maWVsZF9uYW1lKCJwb3J0Iiwgc2VydmVyX2NvbmZpZ1sncG9ydCdd
KQogICAgICAgICBzZWxmLmZpbGxfaW5wdXRfYnlfZmllbGRfbmFtZSgidXNlcm5hbWUiLCBzZXJ2
ZXJfY29uZmlnWyd1c2VybmFtZSddKQogICAgICAgICBzZWxmLmZpbGxfaW5wdXRfYnlfZmllbGRf
bmFtZSgicGFzc3dvcmQiLCBzZXJ2ZXJfY29uZmlnWydkYl9wYXNzd29yZCddKQotICAgICAgICAj
IFJlcXVpcmVkIHNsZWVwIHRvIGF2b2lkICJmZV9zZW5kYXV0aCIgcGFzc3dvcmQgZXJyb3IuCi0g
ICAgICAgIHRpbWUuc2xlZXAoMC41KQorICAgICAgICBXZWJEcml2ZXJXYWl0KHNlbGYuZHJpdmVy
LCAxMCkudW50aWwoRUMuZWxlbWVudF90b19iZV9jbGlja2FibGUoCisgICAgICAgICAgICAoQnku
WFBBVEgsICIvL2J1dHRvbltjb250YWlucyguLCdTYXZlJyldIikpKQogICAgICAgICBzZWxmLmZp
bmRfYnlfeHBhdGgoIi8vYnV0dG9uW2NvbnRhaW5zKC4sJ1NhdmUnKV0iKS5jbGljaygpCiAKICAg
ICAgICAgc2VsZi5maW5kX2J5X3hwYXRoKApAQCAtMjQ1LDYgKzI0NSwxMSBAQCBjbGFzcyBQZ2Fk
bWluUGFnZToKICAgICAgICAgYWN0aW9uLnBlcmZvcm0oKQogCiAgICAgZGVmIGNsaWNrX3RhYihz
ZWxmLCB0YWJfbmFtZSk6CisgICAgICAgIFdlYkRyaXZlcldhaXQoc2VsZi5kcml2ZXIsIDEwKS51
bnRpbChFQy5lbGVtZW50X3RvX2JlX2NsaWNrYWJsZSgKKyAgICAgICAgICAgIChCeS5YUEFUSCwg
Ii8vKltjb250YWlucyhAY2xhc3MsJ3djVGFiVG9wJyldLy8iCisgICAgICAgICAgICAgICAgICAg
ICAgICIqW2NvbnRhaW5zKEBjbGFzcywnd2NQYW5lbFRhYicpICIKKyAgICAgICAgICAgICAgICAg
ICAgICAgImFuZCBjb250YWlucyguLCciICsgdGFiX25hbWUgKyAiJyldIikpKQorCiAgICAgICAg
IHRhYiA9IHNlbGYuZmluZF9ieV94cGF0aCgiLy8qW2NvbnRhaW5zKEBjbGFzcywnd2NUYWJUb3An
KV0vLyIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIqW2NvbnRhaW5zKEBjbGFz
cywnd2NQYW5lbFRhYicpICIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJhbmQg
Y29udGFpbnMoLiwnIiArIHRhYl9uYW1lICsgIicpXSIpCg==
--000000000000e7737e056e971aed--