Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iXjPZ-00025Z-Pw for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Nov 2019 10:10:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iXjPX-0006VG-FN for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Nov 2019 10:10:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iXjPW-0006Uo-S3 for pgadmin-hackers@lists.postgresql.org; Thu, 21 Nov 2019 10:10:03 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iXjPP-00021s-Sm for pgadmin-hackers@postgresql.org; Thu, 21 Nov 2019 10:10:01 +0000 Received: by mail-lj1-x22e.google.com with SMTP id g3so2501802ljl.11 for ; Thu, 21 Nov 2019 02:09:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=/PBjugnSY5HfQ3GBi+jmC6jVu4qFcr3+ptQ6tfxreds=; b=dJClv3ppX4WDnmwhZSmQLpH/DvKDDOVcZ4dCYMsTel//ELa1o9HNU1sLKdgl3CWsIL BdU8+I2JoW155k0TYxX/0e12/CUX0smmczvPnaILF+E/Vffi2TrMiTA2oO5SxHjhrA2m ZCu6f+hwRP/sWXVMUxG2X8XpWetv7/fPmPwsDo6/f6U0g9IU+1YPGnItsebrvfXuQzZs hIBbBMuEXzJWa/s497eX1pZEHsLViI6Obg9PQA4XIN+zrnpkZafAenblzL1WsXao/cqe KBWpxwTC02Shv2R04XMZoSNG8TqBw1FvptnWAEGtjOPq4IDVHC9Z5XEM0EBJI1Q+rIUt ACpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=/PBjugnSY5HfQ3GBi+jmC6jVu4qFcr3+ptQ6tfxreds=; b=uRdExCT9wNbZtDk7t9YR1RbztlCQZGvYQq9lcYO0bQ9djeGowD949ovoAx5TUHxpts G563Y6i+r6nFapiFX8/NZJ9Ddxe4jilNMFi/rY8vCyQZIdX5pr4SPrnMxWVIA+UdieXM B1zhMShWL1GzIwQhgA89VChIxxqweizo03coA5gYaMBI4TE6x5DB27VviEatkToSiEE8 PeB6gRDxC5/AWxqDWECke4+HnDFlfU86tzQlXskBL+xpa7WyuOLSYiX2SgCYctYrXEUL ApvaPCatUQNWXVIeIjZwER+rGNrYWsuYs8T1ZqdGNi4xqwxH56WK94YAStsaxihWArAF VkpA== X-Gm-Message-State: APjAAAX2y6YgJly+VbgwEoZMz/8QJTekw5Agd7zof8Ycaz/Bt/p8tvLr 6ZkXstbb5CxsshDDqoBpkRY9VuaYX6RfnARBDL5/kLmYxOV4mrMl5CoMOJI9pnvx+UOHOMQuA1f w5KhbVCsGPthXqPsua/oPLrzk7An8DnGZDB7ErNksEVmmKFM17Ge89qf/Il2cRKMOHJKnj2BE9C BASb0ZW+WuKEgrpMkow3xS8cHkWrPAq9TyAwsm2q6SzQrIYjD5w2T8nw== X-Google-Smtp-Source: APXvYqwQJSNlaKVZin7+9TdfOEd9zvTGq2RAb0EmZAfsBPghGLPJ6wQPXQWxIzLfT8X26ZMZ1QA94JsC+A+WKE9VGx8= X-Received: by 2002:a2e:7a07:: with SMTP id v7mr6702989ljc.208.1574330993621; Thu, 21 Nov 2019 02:09:53 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Shubham Agarwal Date: Thu, 21 Nov 2019 15:39:42 +0530 Message-ID: Subject: Re: Fixes for pgAdmin feature tests To: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000a272810597d87f4f" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a272810597d87f4f Content-Type: multipart/alternative; boundary="000000000000a2727e0597d87f4d" --000000000000a2727e0597d87f4d Content-Type: text/plain; charset="UTF-8" Hi Team, Attach is the patch for feature test fix containing the following: 1. Handled click event in query tool due to intermediate clicking issue. 2. Observed that the database is not getting created in a test case, so failed the test case there only. On Wed, Nov 20, 2019 at 1:09 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Nov 20, 2019 at 12:34 PM Shubham Agarwal < > shubham.agarwal@enterprisedb.com> wrote: > >> Hi Team, >> PFA feature test fixture patch containing the following things: >> >> 1. Added an attribute 'data-click-counter' in query execute button which >> gets incremented once query button is clicked up to 9 and then reset to 0. >> This is added just to support automation. >> 2. Locator for login_group_role is added and used to expand tree. >> 3. Functions for enabling and disable auto_commit and auto_rollback are >> made more precise. >> 4. Some scrolling problem is addressed in view_data_dml_query test. >> 5. Handled the stale element reference exception in >> query_tool_journey_test >> >> Regards, >> Shubham Agarwal >> >> On Fri, Nov 15, 2019 at 6:03 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, patch applied >>> >>> On Fri, Nov 15, 2019 at 5:59 PM Shubham Agarwal < >>> shubham.agarwal@enterprisedb.com> wrote: >>> >>>> Hi Team, >>>> >>>> PFA feature test fixture patch containing the following fixes: >>>> 1. Process watcher loading logs fix >>>> 2. Auto commit/rollback issue in query_tool_tests >>>> 3. Fixed the scrolling issue while verifying values in a table. >>>> 4. Modified some functions in pgadmin_page.py >>>> >>>> On Wed, Nov 13, 2019 at 11:19 AM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Thanks, patch applied. >>>>> >>>>> On Tue, Nov 12, 2019 at 6:27 PM Shubham Agarwal < >>>>> shubham.agarwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi Team, >>>>>> PFA patch containing some more fixes for random feature test failures. >>>>>> >>>>>> Thanks and regards, >>>>>> Shubham Agarwal >>>>>> >>>>>> On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> Thanks, patch applied with a minor change. Menu for 'Delete Drop' >>>>>>> server has been changed to 'Remove Server' which causes all the test cases >>>>>>> failing on my machine. >>>>>>> >>>>>>> On Mon, Nov 11, 2019 at 10:18 AM Shubham Agarwal < >>>>>>> shubham.agarwal@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Team, >>>>>>>> >>>>>>>> Attached is the patch containing fixes for the failed feature test >>>>>>>> cases. >>>>>>>> This patch contains- >>>>>>>> 1. Newly created function for traversing the browser tree. >>>>>>>> 2. Some synchronization issue fixes. >>>>>>>> 3. Modified locators. >>>>>>>> 4. Test cases fix for the recent commits. >>>>>>>> >>>>>>>> -- >>>>>>>> Thanks & Regards, >>>>>>>> Shubham Agarwal >>>>>>>> EnterpriseDB Corporation >>>>>>>> >>>>>>>> The Postgres Database Company >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Thanks & Regards* >>>>>>> *Akshay Joshi* >>>>>>> >>>>>>> *Sr. Software Architect* >>>>>>> *EnterpriseDB Software India Private Limited* >>>>>>> *Mobile: +91 976-788-8246* >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks & Regards, >>>>>> Shubham Agarwal >>>>>> EnterpriseDB Corporation >>>>>> >>>>>> The Postgres Database Company >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect* >>>>> *EnterpriseDB Software India Private Limited* >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> Shubham Agarwal >>>> EnterpriseDB Corporation >>>> >>>> The Postgres Database Company >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks & Regards, >> Shubham Agarwal >> EnterpriseDB Corporation >> >> The Postgres Database Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company --000000000000a2727e0597d87f4d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Team,
Attach is the patch for feature test fix = containing the following:
1. Handled click event in query tool du= e to intermediate clicking issue.
2. Observed that the database i= s not getting created in a test case, so failed the test case there only.

On Wed, Nov 20, 2019 at 1:09 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Th= anks, patch applied.

On Wed, Nov 20, 2019 at 12:34 PM Shubham Agarwal <shubham= .agarwal@enterprisedb.com> wrote:
Hi Team,
PFA feature test fix= ture=C2=A0patch containing the following things:

1= . Added an attribute 'data-click-counter' in query execute button w= hich gets incremented once query button is clicked up to 9 and then reset t= o 0. This is added just to support automation.
2. Locator for log= in_group_role is added and used to expand tree.
3. Functions for = enabling and disable auto_commit and auto_rollback are made more precise.
4. Some scrolling problem is addressed in view_data_dml_query test= .
5. Handled the stale element reference exception in query_tool_= journey_test

Regards,
Shubham Agarwal

On Fri, Nov 15, 2019 at 6:03 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied

On Fri, Nov 15, 2019 at 5:59 PM Shubham= Agarwal <shubham.agarwal@enterprisedb.com> wrote:
Hi Team,

<= div>PFA feature test fixture patch containing the following fixes:
1. Process watcher loading logs fix
2. Auto commit/rollback iss= ue in query_tool_tests
3. Fixed the scrolling issue while verifyi= ng values in a table.
4. Modified some functions in pgadmin_page.= py

On Wed, Nov 13, 2019 at 11:19 AM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Thanks, patch applied.

On Tue, Nov 12, 2019= at 6:27 PM Shubham Agarwal <shubham.agarwal@enterprisedb.com> wrote:<= br>
Hi Team,
PFA patch containing some more fixes for random feature t= est failures.

Thanks and regards,
Shubha= m Agarwal

On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Thanks, patch applied with a minor change. M= enu for 'Delete Drop' server has been changed to 'Remove Server= ' which causes all the test cases failing on my machine.

On Mon, Nov 11,= 2019 at 10:18 AM Shubham Agarwal <shubham.agarwal@enterprisedb.com> w= rote:
Hi Team,

Attached is the patch containing fixes for t= he failed feature test cases.
This patch contains-
1. N= ewly created function for traversing the browser tree.
2. Some sy= nchronization issue fixes.
3. Modified locators.
4. Tes= t cases fix for the recent commits.

--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company
=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

=
The Postgres Database Company


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

=
The Postgres Database Company


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

=
The Postgres Database Company


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards,
Shubham = Agarwal
EnterpriseDB Corporation

The Postgres Database Company
<= /div>
--000000000000a2727e0597d87f4d-- --000000000000a272810597d87f4f Content-Type: application/octet-stream; name="feature_test_fix_v5.patch" Content-Disposition: attachment; filename="feature_test_fix_v5.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k38k0laf0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMvcGdfdXRpbGl0aWVzX2JhY2t1 cF9yZXN0b3JlX3Rlc3QucHkgYi93ZWIvcGdhZG1pbi9mZWF0dXJlX3Rlc3RzL3BnX3V0aWxpdGll c19iYWNrdXBfcmVzdG9yZV90ZXN0LnB5CmluZGV4IDVhZTg2NzM0Yy4uMjJjNGE5OWRmIDEwMDY0 NAotLS0gYS93ZWIvcGdhZG1pbi9mZWF0dXJlX3Rlc3RzL3BnX3V0aWxpdGllc19iYWNrdXBfcmVz dG9yZV90ZXN0LnB5CisrKyBiL3dlYi9wZ2FkbWluL2ZlYXR1cmVfdGVzdHMvcGdfdXRpbGl0aWVz X2JhY2t1cF9yZXN0b3JlX3Rlc3QucHkKQEAgLTE3LDYgKzE3LDcgQEAgZnJvbSByZWdyZXNzaW9u LmZlYXR1cmVfdXRpbHMuYmFzZV9mZWF0dXJlX3Rlc3QgaW1wb3J0IEJhc2VGZWF0dXJlVGVzdAog ZnJvbSByZWdyZXNzaW9uLnB5dGhvbl90ZXN0X3V0aWxzIGltcG9ydCB0ZXN0X3V0aWxzCiBmcm9t IHJlZ3Jlc3Npb24ucHl0aG9uX3Rlc3RfdXRpbHMgaW1wb3J0IHRlc3RfZ3VpX2hlbHBlcgogZnJv bSByZWdyZXNzaW9uLmZlYXR1cmVfdXRpbHMubG9jYXRvcnMgaW1wb3J0IE5hdk1lbnVMb2NhdG9y cworZnJvbSByZWdyZXNzaW9uLmZlYXR1cmVfdXRpbHMudHJlZV9hcmVhX2xvY2F0b3JzIGltcG9y dCBUcmVlQXJlYUxvY2F0b3JzCiAKIAogY2xhc3MgUEdVdGlsaXRpZXNCYWNrdXBGZWF0dXJlVGVz dChCYXNlRmVhdHVyZVRlc3QpOgpAQCAtNTUsNyArNTYsMTAgQEAgY2xhc3MgUEdVdGlsaXRpZXNC YWNrdXBGZWF0dXJlVGVzdChCYXNlRmVhdHVyZVRlc3QpOgogICAgICAgICAgICAgc2VsZi5zZXJ2 ZXJbJ3NzbG1vZGUnXQogICAgICAgICApCiAgICAgICAgIHRlc3RfdXRpbHMuZHJvcF9kYXRhYmFz ZShjb25uZWN0aW9uLCBzZWxmLmRhdGFiYXNlX25hbWUpCi0gICAgICAgIHRlc3RfdXRpbHMuY3Jl YXRlX2RhdGFiYXNlKHNlbGYuc2VydmVyLCBzZWxmLmRhdGFiYXNlX25hbWUpCisgICAgICAgIGRi X2lkID0gdGVzdF91dGlscy5jcmVhdGVfZGF0YWJhc2Uoc2VsZi5zZXJ2ZXIsIHNlbGYuZGF0YWJh c2VfbmFtZSkKKyAgICAgICAgaWYgbm90IGRiX2lkOgorICAgICAgICAgICAgc2VsZi5hc3NlcnRU cnVlKEZhbHNlLCAiRGF0YWJhc2Uge30gaXMgbm90ICIKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgImNyZWF0ZWQiLmZvcm1hdChzZWxmLmRhdGFiYXNlX25hbWUpKQogICAgICAg ICB0ZXN0X2d1aV9oZWxwZXIuY2xvc2VfYmdwcm9jZXNzX3BvcHVwKHNlbGYpCiAgICAgICAgIHNl bGYucGFnZS5hZGRfc2VydmVyKHNlbGYuc2VydmVyKQogCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1p bi9mZWF0dXJlX3Rlc3RzL3ZpZXdfZGF0YV9kbWxfcXVlcmllcy5weSBiL3dlYi9wZ2FkbWluL2Zl YXR1cmVfdGVzdHMvdmlld19kYXRhX2RtbF9xdWVyaWVzLnB5CmluZGV4IDM4MWJlMjJkYy4uNjJh YTA5ODU4IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9mZWF0dXJlX3Rlc3RzL3ZpZXdfZGF0YV9k bWxfcXVlcmllcy5weQorKysgYi93ZWIvcGdhZG1pbi9mZWF0dXJlX3Rlc3RzL3ZpZXdfZGF0YV9k bWxfcXVlcmllcy5weQpAQCAtMzM4LDkgKzMzOCw3IEBAIENSRUFURSBUQUJMRSBwdWJsaWMubm9u aW50cGtleQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyh0ZXh0LCBtZXNzYWdlc19lbGUudGV4 dCkKIAogICAgIGRlZiBfdmVyaWZ5X3Jvd19kYXRhKHNlbGYsIGlzX25ld19yb3csIGNvbmZpZ19j aGVja19kYXRhKToKLSAgICAgICAgc2VsZi5wYWdlLmZpbmRfYnlfY3NzX3NlbGVjdG9yKAotICAg ICAgICAgICAgUXVlcnlUb29sTG9jYXRvcnMuYnRuX2V4ZWN1dGVfcXVlcnlfY3NzKS5jbGljaygp Ci0KKyAgICAgICAgc2VsZi5wYWdlLmNsaWNrX2V4ZWN1dGVfcXVlcnlfYnV0dG9uKCkKICAgICAg ICAgIyBGaXJzdCByb3cgaWYgcm93IGhlaWdodCA9IDAsIHNlY29uZCByb3cgaWYgaXRzIDI1CiAg ICAgICAgIHJvd19oZWlnaHQgPSAwIGlmIGlzX25ld19yb3cgZWxzZSAyNQogCmRpZmYgLS1naXQg YS93ZWIvcmVncmVzc2lvbi9mZWF0dXJlX3V0aWxzL3BnYWRtaW5fcGFnZS5weSBiL3dlYi9yZWdy ZXNzaW9uL2ZlYXR1cmVfdXRpbHMvcGdhZG1pbl9wYWdlLnB5CmluZGV4IGE3NTRhM2UyNS4uOGJl YzFhNzRiIDEwMDY0NAotLS0gYS93ZWIvcmVncmVzc2lvbi9mZWF0dXJlX3V0aWxzL3BnYWRtaW5f cGFnZS5weQorKysgYi93ZWIvcmVncmVzc2lvbi9mZWF0dXJlX3V0aWxzL3BnYWRtaW5fcGFnZS5w eQpAQCAtMTcxLDEwICsxNzEsNyBAQCBjbGFzcyBQZ2FkbWluUGFnZToKIAogICAgIGRlZiBleGVj dXRlX3F1ZXJ5KHNlbGYsIHF1ZXJ5KToKICAgICAgICAgc2VsZi5maWxsX2NvZGVtaXJyb3JfYXJl YV93aXRoKHF1ZXJ5KQotICAgICAgICBleGVjdXRlX2J1dHRvbiA9IHNlbGYuZmluZF9ieV9jc3Nf c2VsZWN0b3IoCi0gICAgICAgICAgICBRdWVyeVRvb2xMb2NhdG9ycy5idG5fZXhlY3V0ZV9xdWVy eV9jc3MpCi0gICAgICAgIGV4ZWN1dGVfYnV0dG9uLmNsaWNrKCkKLSAgICAgICAgc2VsZi53YWl0 X2Zvcl9xdWVyeV90b29sX2xvYWRpbmdfaW5kaWNhdG9yX3RvX2Rpc2FwcGVhcigpCisgICAgICAg IHNlbGYuY2xpY2tfZXhlY3V0ZV9xdWVyeV9idXR0b24oKQogCiAgICAgZGVmIGNsaWNrX2V4ZWN1 dGVfcXVlcnlfYnV0dG9uKHNlbGYpOgogICAgICAgICByZXRyeSA9IDUK --000000000000a272810597d87f4f--