Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qRBCw-000oG2-WC for pgadmin-hackers@arkaria.postgresql.org; Wed, 02 Aug 2023 12:44:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qRBCu-0057jQ-Qo for pgadmin-hackers@arkaria.postgresql.org; Wed, 02 Aug 2023 12:44:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qRBCu-0057jH-IZ for pgadmin-hackers@lists.postgresql.org; Wed, 02 Aug 2023 12:44:04 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qRBCs-0008t8-AB for pgadmin-hackers@postgresql.org; Wed, 02 Aug 2023 12:44:04 +0000 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-267f870e6ffso3986879a91.0 for ; Wed, 02 Aug 2023 05:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690980240; x=1691585040; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qfKGXjjqI/T91bTxhZZpTXNso0Aze6RWxei1fLTbRFA=; b=aemgQYcb+00IxPBuNvYNWCpitzdMP0kuh/UHbcIGS0+nfMdy/VO5beHJNm6vj8ZhVi RgOiyGismslwpyaMVSdRbl4+kG+qdTRgRQ9TY1GsllYgumVF/dFtTyZF28+8KibZSHdE onUShJfDDSWzfZAsLAxroaKovtYtkUVQxARHUFqiaUxxgFaRpt4QGBIEDk6HVQaSVo5R gTUiyYEkUIxAagFCVUYBbFZ2AQzZhdOVzu7zsozzENxS9HEBSwz5FE70Ufzc28TxIQ7K LPwfxSWVNAw2VBLKMGFyiUU0+wxBiDG0CZ3A3WPO7dhUYPkUbwVEVan4sicxP1XMiYTS +KZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690980240; x=1691585040; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qfKGXjjqI/T91bTxhZZpTXNso0Aze6RWxei1fLTbRFA=; b=i1vUZ2RLbh75SbNH8GA2VuGRxmCJfEeKYuCZxJgfriJOFmuaof9luDDFohwT3D5pO4 xqePTqliHcq8QSA6nhrc5KNmwFwOCrwy3jyuVHa/sqn/KlqMHjvZ9pHUtNgaCP+MoBYy ym9Ps6U2s71PZEa8xfS5gXuNvxSV0MXVoADAMNDAnUlEjt4XsKCU7pfuMNZSTY6oWvsf eUp4aaKp3CEWZsYL5s2G/n8rmKWKIt1h3fUeCuQpB6VWamww586Dxw5nFEv1rhAdAjET 6L1nFI1e/ytZiG/qwAzJbtyYJEDzw7gqUvdT85bC+QIwScny6rEEQhJZOUzq158HYT/o +pAA== X-Gm-Message-State: ABy/qLYwGkmDkUHJxHzrvIlUqaOgwCMf8QOvTiUFLp0J0YzDhadfqm9t GZjewOSi0359iW6ALCS+8dQre50uynZiGYc2mWc= X-Google-Smtp-Source: APBJJlFgBD5f0R5vIqClyBg9geN8mvd1abI/hPVKaJNn7OX45YvxjxuRAezI03wB4RKkx0F5lrLwy00ZbTDsDZ3gH9s= X-Received: by 2002:a17:90a:f284:b0:268:36c1:4204 with SMTP id fs4-20020a17090af28400b0026836c14204mr13701385pjb.4.1690980239847; Wed, 02 Aug 2023 05:43:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sahil Harpal Date: Wed, 2 Aug 2023 18:13:46 +0530 Message-ID: Subject: Re: Pgadmin4 System Stats Extension Design To: Khushboo Vashi Cc: pgadmin-hackers@postgresql.org, Aditya Toshniwal , Ashesh Vashi , Dave Page , Akshay Joshi Content-Type: multipart/alternative; boundary="00000000000084b5d60601f0048b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000084b5d60601f0048b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Khushboo, On Thu, 27 Jul 2023 at 16:26, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > You have made different files tab-wise; it would be more manageable if yo= u > could put them under a subfolder OR start a name with system_state or > something like that. > On Thu, Jul 27, 2023 at 1:59=E2=80=AFPM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Some initial review comments. >> - While applying the patch, I got warnings; please fix those. >> - Fix PEP-8 errors (yarn run pep8) >> - Fix the linter errors. Run *yarn run bundle:dev* instead of *yarn run >> webpacker so* you will get the linter errors on every run. >> - If the System Stat extension does not exist, display the appropriate >> message instead of blank graphs. >> - For the first time, graphs start from the opposite side, and after the >> following API call, those get adjusted; please fix that. >> - Please consider the refresh rate for the API calls (preferences >> settings > Dashboards > Refresh rates) >> >>> Thank you for the feedback. I have made all the changes as you have suggested, except for the issue where graphs are starting from opposite sides. I am using the same StreamingChart component that is already there. I just made a few changes to handle multiple Y-axes. I tried debugging it, but haven't found a solution yet. However, I also checked the pgAdmin4 desktop application, and I observed a similar behavior there. The initial graphs start from the opposite side and then get adjusted automatically, but the transition is a little faster there. Could you please help identify what might be causing this issue? Thank you, Sahil --00000000000084b5d60601f0048b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo,

On = Thu, 27 Jul 2023 at 16:26, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
3D""
You have made differ= ent files tab-wise; it would be more manageable=C2=A0if you could put them = under a subfolder OR start a name with system_state or something like that.=
On Thu= , Jul 27, 2023 at 1:59=E2=80=AFPM Khushboo Vashi <khushboo.vashi@enterprisedb.= com> wrote:
<= div dir=3D"ltr">
Some initial review comment= s.
- While applying the patch, I got warnings; please fix those.<= /div>
- Fix PEP-8 errors (yarn run pep8)
- Fix the linter err= ors. Run yarn run bundle:dev=C2=A0instead of yarn run webpacker s= o=C2=A0you will get the linter errors on every run.
- If the = System Stat extension does not exist, display the appropriate message inste= ad of blank graphs.
- For the first time, graphs start from the o= pposite side, and after the following API call, those get adjusted; please = fix that.
- Please consider the refresh rate for the API calls (p= references settings > Dashboards > Refresh rates)

Thank you for the feedback. I have m= ade all the changes as you have suggested, except for the issue where graph= s are starting from opposite sides. I am using the same StreamingChart comp= onent that is already there. I just made a few changes to handle multiple Y= -axes. I tried debugging it, but haven't found a solution yet. However,= I also checked the pgAdmin4 desktop application, and I observed a similar = behavior there. The initial graphs start from the opposite side and then ge= t adjusted automatically, but the transition is a little faster there. Coul= d you please help identify what might be causing this issue?
=
Thank you,
Sahil

--00000000000084b5d60601f0048b--