Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYPMZ-001boh-S9 for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Aug 2023 11:15:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qYPMX-0008Gs-Ib for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Aug 2023 11:15:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYPMX-0008Gk-8d for pgadmin-hackers@lists.postgresql.org; Tue, 22 Aug 2023 11:15:53 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qYPMT-000KLt-SU for pgadmin-hackers@postgresql.org; Tue, 22 Aug 2023 11:15:51 +0000 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-564b6276941so2791552a12.3 for ; Tue, 22 Aug 2023 04:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692702948; x=1693307748; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DEnwAGzvgtdvzUlAW34ZwOE7EaTgi8oJCxQSe3oXXzc=; b=FF3dc0B6STeLjUTQPkg7gQ5sxAGX9b8tcVmR/n+z1Wn9rpgjpIaumcylGaFdYpM9tM Bo7j9hjgRExTG04oS4Q4NYe8XGBvx6e4sMuJbHGy8t/tywg3Pwcu7VHE0Kr92SJKFfCy xNLuSqICgTIfq/mSYdpAI5n+L4eVMFxJxWlHV5qCXWs8vy2S9WgzQPnaLWtjX9RoPP1W 7imJJQmu4W4+PxojVapLx1edQ/nNCAO5qXPoIdLjTArfe23wo2jMuYQDlq/SS7lCRMpT CZp4YbHBkxR6exMQHcLuoo2Xtsln9271zA8fjQcQGPZ9/WQEyqWYDEi+8w0zjcHieyac EPgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692702948; x=1693307748; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DEnwAGzvgtdvzUlAW34ZwOE7EaTgi8oJCxQSe3oXXzc=; b=FGFyia1t03HvUMfLNl8hKijcMc0upzIGcM8Sb+UhO6129H9hnMLYrGqBcl/j2+a6mW 2qnCxVzuxBHbx18of8X3lDnzwXp/qMGBupkgn6LEagEO2++Svad/6FFrvr+weRFNa45D qlMHGBnMyDMMPy1wAj53RIpzJ54J6keDH5BGlQAelzfSa913iMVaM+7ifrZh9dim2iqc pPd8A+MJB45qDz5hGcxWmWUkpNV6samQMXDEUuoeWFHcOrcwBxZnQFCBwNha6SH265Nw IrMZTKDceh8UueFSRJmFZ4+pu9fWNzCTDE2ZovPZccEiJSwu3RoDKlXhkZvBE8qa6uTr M75w== X-Gm-Message-State: AOJu0YzNQSyy33didPjzE7bYefdqNjCLWFoHb5+ia5tgetkMzGhaPWfc xuIkia+2VvnX4gPFf0vP6TPC4GeQQuEQDHkJebM= X-Google-Smtp-Source: AGHT+IE+LYKkG+NuNjaJAtk9JppZb889beDdWGFDvoITT7OzhlJhsV75S4CR6kcqXiAF8hCg6AC2emFoz/k+s49ffDc= X-Received: by 2002:a17:90a:883:b0:26f:2c5a:bbb3 with SMTP id v3-20020a17090a088300b0026f2c5abbb3mr7178318pjc.40.1692702948251; Tue, 22 Aug 2023 04:15:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sahil Harpal Date: Tue, 22 Aug 2023 16:45:34 +0530 Message-ID: Subject: Re: Pgadmin4 System Stats Extension Design To: Khushboo Vashi Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="000000000000f0e4d60603811d32" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000f0e4d60603811d32 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 22 Aug 2023 at 16:02, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Sahil, > > On Tue, Aug 22, 2023 at 1:19=E2=80=AFPM Sahil Harpal > wrote: > >> Hello Khushboo, >> >> Thank you for sharing this with me. As you can see, towards the end, whe= n >> you encountered the tooltip issue, the size of the graph container was >> changing. I even found this bug in the actual pgAdmin4 application >> installed on my system. Please see the attached video. >> >> Here's what I believe is happening: When the container's size changes, i= t >> seems that tooltips continue to accumulate without being properly remove= d. >> The method we use to display tooltips involves inserting a new element >> into the DOM with the class name "uplot-tooltip". So, if we remove all t= he >> existing tooltip elements before inserting a new one, it could potential= ly >> resolve the issue. Would like to know your thoughts on this. >> >> It would be good if you fix this issue as you already investigated and > found the root cause. But if you have other things to complete as the > deadline is approaching you can create this issue at pgAdmin repo as it i= s > an existing one. > Sure, I'll try to fix this. --000000000000f0e4d60603811d32 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, 22 Aug 2023 at 16:02, Khushboo Va= shi <khushboo.vashi@e= nterprisedb.com> wrote:
3D""
=
Hi Sahil,

On Tue, Aug 22, 2023 at 1:19=E2=80=AFPM Sahi= l Harpal <sahilharpal1234@gmail.com> wrote:
Hello Khus= hboo,

Thank you for sharing this with me. As you can see, towards th= e end, when you encountered the tooltip issue, the size of the graph contai= ner was changing. I even found this bug in the actual pgAdmin4 application = installed on my system. Please see the attached video.

Here's wh= at I believe is happening: When the container's size changes, it seems = that tooltips continue to accumulate without being properly removed.
The= method we use to display tooltips involves inserting a new element into th= e DOM with the class name "uplot-tooltip". So, if we remove all t= he existing tooltip elements before inserting a new one, it could potential= ly resolve the issue. Would like to know your thoughts on this.
It would be good if you fix this issue as y= ou already investigated and found the root cause. But if you have other thi= ngs to complete as the deadline is approaching you can create this issue at= pgAdmin repo as it is an existing one.
=
Sure, I'll try to fix this.
--000000000000f0e4d60603811d32--