Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjmXh-0006w7-QL for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Sep 2016 12:10:26 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bjmXh-0006qj-84 for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Sep 2016 12:10:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bjmXT-0006aA-HG for pgadmin-hackers@postgresql.org; Tue, 13 Sep 2016 12:10:11 +0000 Received: from mail-yw0-x229.google.com ([2607:f8b0:4002:c05::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bjmXN-0005ET-Th for pgadmin-hackers@postgresql.org; Tue, 13 Sep 2016 12:10:09 +0000 Received: by mail-yw0-x229.google.com with SMTP id u82so38099496ywc.2 for ; Tue, 13 Sep 2016 05:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NQEvQjI645M6mZyzKzyLdxgumQPuOUtpjwxm1br7R2I=; b=M4MGE0ZpnMF4LZNpEQ60iF6EOCfMt2Wp6XnCNhP0lv5f6fPHj5IjPEQ6bAqVlDvTPW 6PYO3QS0gS/eMKwz5IUwPoWJwK64EfAchoF+AldQ7ok3h/stioaAd1YZtzpzqd24Bp4g 3bXMPNFVW7lLOUbb0BJLz1hTiRR7kGZIr6p1+HSuKia/oBSIgK6DwRlbu94br4PSnt33 23wMC0/BIJfq+CViZJfNoR1gi3w54Ed7m7OnMg+XlriPF2E5LiEjn+ZIF3NWNfWhEscM UugQwcRnIOgqxvwFPWis4UjXN1WPDQ5D32f8Pbxn+mlocwSRNnP49N8JUUdT0wJXEWYl W5kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NQEvQjI645M6mZyzKzyLdxgumQPuOUtpjwxm1br7R2I=; b=TkAlimzex7wuPGQba6wuaG5dK9Kvo8W7EmxMWaIlY1NlfhqeRaR2S92/3GbdvbK8K3 hqYZL0Ip9bB16jFK5Yx0D2lPSTNbvhC9RliJfRj7hTQMbT+VYhxAAZ20hdUW023XMPK6 /Qt5mUXlyzXi6H8TZZl7fTOygsXMV9OqMUaerZ2yVumv/7N4sw9AYb+ZAeiLOfolRtgc GFViZ4WZnPxiXyx7I80ApjcJL+Q34M1aYxqEFHbpklvHcjQ3xCjgU0633mQshC3mqaLo XwSqJMNb9zBNKh88NINzEt3v5oyeHgQZpshP+UDTEsHopwiEXUSlZy8WD+FefepzIjNz bqcw== X-Gm-Message-State: AE9vXwMTZ5R2dPUvwps01QAQ2kVWR0k1G0RZH9SNzhmdn/R4YH7HqUyiyBoRMqzhjJ8dLJUK+4Cc2wv1H4mL+0NL X-Received: by 10.129.91.84 with SMTP id p81mr328018ywb.25.1473768603958; Tue, 13 Sep 2016 05:10:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.196.4 with HTTP; Tue, 13 Sep 2016 05:09:43 -0700 (PDT) In-Reply-To: References: From: Priyanka Shendge Date: Tue, 13 Sep 2016 17:39:43 +0530 Message-ID: Subject: Re: Server specific advanced config file for testsuite To: Dave Page Cc: Navnath Gadakh , Kanchan Mohitey , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114c7b401ef251053c627e20 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114c7b401ef251053c627e20 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 13 September 2016 at 14:18, Dave Page wrote= : > Hi > > On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh > wrote: > > Hi Dave, > > As we know that, we are using two JSON files one is for basic > > configuration of server(test_config.json) and second for detailed > > configuration of server(test_advanced_config.json). > > In test_advanced_config.json, we give detail for database, schema, > > extension, collation etc. These details are generic I mean these detail= s > are > > not server specific. > > - Do we need to allow user to give server specific details? > > I don't see any reason to do so. Honestly I don't see much need for > test_advanced_config.json at all - I can't see anyone ever customising > the tests. I certainly doubt I will. > As per your suggestion, I have added test data to test_advanced_config.json which will be used/changed by advanced user. test_advanced_config.json contain test data for all nodes (i.e. database, schema, tablespace etc..) except server. If we dont use test_advanced_config.json file, from where we can fetch test data for all nodes? We wants to edit test_advanced_config.json as per server type and version as there are 2 types of servers available i.e. PostgreSQL and EPAS which might have different test data as per server type. e.g. "owner": in case of PG it can be owner: "postgres" which may not be available for EPAS, for EPAS it can be "enterprisedb" or vice versa. If we do not modify the tests and run testsuite it will fail for multiple servers. > > If yes, there should be some identification(like =E2=80=98server_type= =E2=80=99, > =E2=80=98version=E2=80=99) > > for each detail so that we can read server appropriate details. > > We have one approach in mind, to attach 'server_type' & 'version' to ea= ch > > detail > > So, modified test_advanced_config.json can be like this, > > { > > "add_database_data=E2=80=9D:[ > > { > > "conn_limit": -1, > > =E2=80=9Cowner=E2=80=9D: =E2=80=9Cpostres=E2=80=9D, > > . > > . > > . > > . > > =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cpg=E2=80=9D, > > =E2=80=9Cversion=E2=80=9D: =E2=80=9Cpg9.4=E2=80=9D > > }, > > { > > { > > "conn_limit": -1, > > =E2=80=9Cowner=E2=80=9D: =E2=80=9Centerprisedb=E2=80=9D, > > . > > . > > . > > . > > =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cppas=E2=80=9D, > > =E2=80=9Cversion=E2=80=9D: =E2=80=9Cppas9.6=E2=80=9D > > } > > }], > > =E2=80=9Cschema_credentials=E2=80=9D: > > [{"func_acl": [], > > "seq_acl": [], > > . > > . > > . > > . > > =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cpg=E2=80=9D, > > =E2=80=9Cversion=E2=80=9D: =E2=80=9Cpg9.4=E2=80=9D > > }] > > . > > . > > . > > . > > . > > } > > > > Any suggestions? > > > > For multiple server currently we used 'owner' to identify the server, b= ut > > that fails if two servers have the same owner. > > > > > > -- > > Thanks, > > Navnath Gadakh > > Software Engineer > > EnterpriseDB Corporation > > Mobile: +91 9975389878 > > > > > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --=20 Best, Priyanka EnterpriseDB Corporation The Enterprise PostgreSQL Company --001a114c7b401ef251053c627e20 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 13 September 2016 at 14:18, Dave Page <dave.page@enterpri= sedb.com> wrote:
Hi

On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
<navnath.gadakh@enter= prisedb.com> wrote:
> Hi Dave,
>=C2=A0 =C2=A0 =C2=A0 As we know that, we are using two JSON files one i= s for basic
> configuration of server(test_config.json) and second for detailed
> configuration of server(test_advanced_config.json).
> In test_advanced_config.json, we give detail for database, schema,
> extension, collation etc. These details are generic I mean these detai= ls are
> not server specific.
> - Do we need to allow user to give server specific details?

I don't see any reason to do so. Honestly I don't see much n= eed for
test_advanced_config.json at all - I can't see anyone ever customising<= br> the tests. I certainly doubt I will.

As= per your suggestion, I have added test data to test_advanced_config.json w= hich will be=C2=A0used/changed by=C2=A0adv= anced user.
test_advanced_config.json contain test data fo= r all nodes (i.e. database, schema, tablespace etc..) except server.
If we dont use test_advance= d_config.json file, from where we can fetch test data for all nodes?
<= div>We wants to edit test_advanced_config.json as per server type and versi= on as there are 2 types of=C2=A0
servers available i.e. PostgreSQ= L and EPAS which might have different test data as per server type.
e.g. "owner": in case of PG it can be owner: "postgres&qu= ot;=C2=A0
which may not be available for EPAS, for EPAS it can be= "enterprisedb" or vice versa.
If we do not modify the = tests and run testsuite it will fail for multiple servers.


> If yes, there should be some identification(like =E2=80=98server_type= =E2=80=99, =E2=80=98version=E2=80=99)
> for each detail so that we can read server appropriate details.
> We have one approach in mind, to attach 'server_type' & &#= 39;version' to each
> detail
> So, modified test_advanced_config.json can be like this,
> {
> "add_database_data=E2=80=9D:[
> {
>=C2=A0 "conn_limit": -1,
>=C2=A0 =E2=80=9Cowner=E2=80=9D: =E2=80=9Cpostres=E2=80=9D,
>=C2=A0 =C2=A0.
>=C2=A0 =C2=A0.
>=C2=A0 =C2=A0.
>=C2=A0 =C2=A0.
>=C2=A0 =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cpg=E2=80=9D,
>=C2=A0 =E2=80=9Cversion=E2=80=9D: =E2=80=9Cpg9.4=E2=80=9D
> },
> {
> {
>=C2=A0 "conn_limit": -1,
>=C2=A0 =E2=80=9Cowner=E2=80=9D: =E2=80=9Centerprisedb=E2=80=9D,
>=C2=A0 =C2=A0.
>=C2=A0 =C2=A0.
>=C2=A0 =C2=A0.
>=C2=A0 =C2=A0.
>=C2=A0 =E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cppas=E2=80=9D,
>=C2=A0 =E2=80=9Cversion=E2=80=9D: =E2=80=9Cppas9.6=E2=80=9D
> }
> }],
> =E2=80=9Cschema_credentials=E2=80=9D:
> [{"func_acl": [],
>=C2=A0 =C2=A0"seq_acl": [],
>=C2=A0 =C2=A0.
>=C2=A0 =C2=A0.
>=C2=A0 =C2=A0.
>=C2=A0 =C2=A0.
>=C2=A0 =C2=A0=E2=80=9Cserver_type=E2=80=9D: =E2=80=9Cpg=E2=80=9D,
>=C2=A0 =C2=A0=E2=80=9Cversion=E2=80=9D: =E2=80=9Cpg9.4=E2=80=9D
> }]
> .
> .
> .
> .
> .
> }
>
> Any suggestions?
>
> For multiple server currently we used 'owner' to identify the = server, but
> that fails if two servers have the same owner.
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878
>
>



--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers



--
Best,
Priyanka=

EnterpriseDB Co= rporation
The Enterprise PostgreSQL Company
--001a114c7b401ef251053c627e20--