Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG4ty-0006RG-Py for pgadmin-hackers@arkaria.postgresql.org; Thu, 23 Jun 2016 13:42:38 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bG4ty-00070r-DB for pgadmin-hackers@arkaria.postgresql.org; Thu, 23 Jun 2016 13:42:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bG4tl-0006mx-6D for pgadmin-hackers@postgresql.org; Thu, 23 Jun 2016 13:42:25 +0000 Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bG4tc-0005PS-JK for pgadmin-hackers@postgresql.org; Thu, 23 Jun 2016 13:42:24 +0000 Received: by mail-qk0-x22a.google.com with SMTP id t127so107040781qkf.1 for ; Thu, 23 Jun 2016 06:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TdgnaN3riJTPDUn/wgT2U7uByQCG9XEE5+Juk0uFNrY=; b=CU/5IS+eduYN8FzbsE8iBPPRR7Okb0J58LL9h4ygcT2+j9cdzWh1hVXgEQhbbCK4au lVPs07Yij8lbr2YEZMuL3zEmzE1fcTaYfdCKHhxDAGruGKQiFi8l5/pENksMHMllENtY /ulYj7QJuKd2Y/+9ydDqdiCFfWS7/aXQTiIFF/v7FqwAo76J0e8FWVOX0R8sYRLEd4mI +DwYxEOFwfvLnncQNd5Rpy/WexaE0W8tio+73+xd6TOGTQGpws8gSxNumIcN8dhAnmvN 977xWNU6bzHeaAR3MuppL16TwdSaZ0P5NEwWGTYhecwrktYomZAAEgKxquHA/7Pof2pv V59w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TdgnaN3riJTPDUn/wgT2U7uByQCG9XEE5+Juk0uFNrY=; b=F6h3eZug7akivdxFc72xgvrWl8zQBAEDpLJ/rNZX8gUILYuQbeJufz+9kESvTE1H3u 7E+OyKgT+y6UcYIUtL8SjnJWipqR+4Mf/KSPjPPzCmyRQjJyH93R5lha8tsICb9McNkX VQa6Rjd7GOSBz/1vzILMT2LiUt84jDtcJ28IwItrrf97aP9L5gRaq/gttN5FqvFrNyNJ PmdLqzRcc68b0AZQJQ0JnRgb4/9UhLrRUCrp80cIMmqzfGjCFb9W4EZpSfQPtkGKv69H ZjFOkbBZhgRCJrn1Ut5VO1SsV58vmcZ9DgxfPlZrGx7wh25JntEK6JdFxwwRwPB3Y+NM 6Bkg== X-Gm-Message-State: ALyK8tKMNv3t3/qM4Tn766MAhHj9CNwyX1urk5b5q/ftG72/tbTqhs09sYj/VcGRrYo9b5omOceeb+2r8pxXF5Sf X-Received: by 10.55.207.74 with SMTP id e71mr44521269qkj.64.1466689334542; Thu, 23 Jun 2016 06:42:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.45.165 with HTTP; Thu, 23 Jun 2016 06:41:55 -0700 (PDT) In-Reply-To: References: From: Priyanka Shendge Date: Thu, 23 Jun 2016 19:11:55 +0530 Message-ID: Subject: Re: pgAdmin IV API test cases patch To: Dave Page Cc: pgadmin-hackers , Kanchan Mohitey Content-Type: multipart/alternative; boundary=001a1145b84ac85c6a0535f2381f X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1145b84ac85c6a0535f2381f Content-Type: text/plain; charset=UTF-8 On 15 June 2016 at 15:05, Priyanka Shendge < priyanka.shendge@enterprisedb.com> wrote: > Thanks a lot Dave. > > On 15 June 2016 at 14:09, Dave Page wrote: > >> Hi >> >> On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge >> wrote: >> > Hi Dave, >> > >> > PFA updated patch. I have made changes suggested by you. >> > >> > Kindly, review and let me know for more changes. >> >> OK, I got a bit further this time, but not there yet. >> >> 1) The patch overwrote my test_config.json file. That should never >> happen (that file shouldn't be in the source tree). >> test_config.json.in should be the file that's included in the patch. >> > > OK. > >> >> 2) The updated test_config.json file is huge. > > Current configuration file web/regression/test_config.json contains test data(credentials) for each tree node; which is used while adding and updating the respective node. > I should only need to >> define one or more connections, then be able to run the tests. If you >> need to keep configuration info for "advanced users", let's put it in >> a different file to avoid confusing/scaring everyone else. Maybe split >> it into config.json for the stuff the user needs to edit >> (config.json.in would go in git), and test_config.json for the test >> configuration. > > Should i keep login and server credentials into web/regression/test_config.json file and put respective node details into config.json file of respective node's tests directory? e.g. for database node: I'll create config.json file into .../databases/tests/ directory put database add and update credentials into config.json > >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Best, > Priyanka > > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > -- Best, Priyanka EnterpriseDB Corporation The Enterprise PostgreSQL Company --001a1145b84ac85c6a0535f2381f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 15 June 2016 at 15:05, Priyanka Shendge <priyanka.s= hendge@enterprisedb.com> wrote:
Thanks a lot Dave.=C2=A0

On 15 June 2016 at 14:09, Dave Page <dpa= ge@pgadmin.org> wrote:
Hi

On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge
<= priyanka.shendge@enterprisedb.com> wrote:
> Hi Dave,
>
> PFA updated patch. I have made changes suggested by you.
>
> Kindly, review and let me know for more changes.

OK, I got a bit further this time, but not there yet.

1) The patch overwrote my test_config.json file. That should never
happen (that file shouldn't be in the source tree).
test_config.json.in should be the file that's included in the patc= h.

OK.=C2=A0

2) The updated test_config.json file is huge.

Current configuration file web/reg= ression/test_config.json contains test data(credentials) for each tree node= ;
which is used while adding and updating the respective node.=C2= =A0
=C2=A0
= I should only need to
define one or more connections, then be able to run the tests. If you
need to keep configuration info for "advanced users", let's p= ut it in
a different file to avoid confusing/scaring everyone else. Maybe split
it into config.json for the stuff the user needs to edit
(con= fig.json.in would go in git), and test_config.json for the test
configuration.=C2=A0

Should i keep login and server credentials into =C2=A0web/r= egression/test_config.json file and
put respective node details i= nto config.json file of respective node's tests directory?
e.g. for database node:
I'll create config.json = file into .../databases/tests/ directory
put database add and upd= ate credentials into config.json

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Best,
Priyanka

EnterpriseDB Corporation
The Enterprise PostgreSQL Compa= ny



--
Best,
Priyanka

EnterpriseDB Corporation
The Enterprise PostgreSQL Company
--001a1145b84ac85c6a0535f2381f--