Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brfku-0004qU-Tm for pgadmin-hackers@arkaria.postgresql.org; Wed, 05 Oct 2016 06:32:41 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1brfku-00064L-Bs for pgadmin-hackers@arkaria.postgresql.org; Wed, 05 Oct 2016 06:32:40 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1brfkg-0005q0-R3 for pgadmin-hackers@postgresql.org; Wed, 05 Oct 2016 06:32:26 +0000 Received: from mail-yb0-x22e.google.com ([2607:f8b0:4002:c09::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1brfkZ-0008W2-A8 for pgadmin-hackers@postgresql.org; Wed, 05 Oct 2016 06:32:25 +0000 Received: by mail-yb0-x22e.google.com with SMTP id 184so28471794yby.2 for ; Tue, 04 Oct 2016 23:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=J24ej22nikxJ855phJdBL7upp0g+B8HG5H2L72ikVA0=; b=yj+XEGSgLXP4tgczqZpF6wKRIgXosaaFvC5JEprNWEAxR6pI7VomnrVUI8Dx153PBk sjU5+nIxID6ecLywmGi/nRcHNGtOaCVIDrh86gAERtsw+HBUXlBnUeBUXNS277mu00wj BoFl4+znSLv1upDxxcZRIse90SbfoACEoX+e9BtZZ9X0gPR3IjfuukFyBZelT6aLIUYR w2K0wqkWpoOhuCnlUYcflx8m9L9wxf+TBpMeiCgiW4vTfb7FD72ZsyRzbtYpSPeoW5gE 21ydcilntkMvE3ORNi1v+RLFtoeEgUP4gBFkuA5aU3Z+7utFsCYM5bUk0NqLRDcyOg4U Kd+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=J24ej22nikxJ855phJdBL7upp0g+B8HG5H2L72ikVA0=; b=NEO7w92x3FQUz2CZvFni2HafFAk2KTXvRRcM1kSP9CUFjkkf12ou+/7e7QncA7r02X zbAHz8a5NnHHbG1insd+SGzUmQn2DAyQ7JQGKRlH4kb5XBLbFlujrTI2FP6IsM7RjOwK OaRNLmRWbIXoBICNvPQkTc+ZlMsMgPJqBQjq3nkMXd4r/b557NIIajH93i5TbEGQWhJp /OT1e3t0VzAAbtIxKdsO8J0Cb3Fv8OkQeCz4KSFZd9jiN5BTBb6VNU1E5XYIel1hv4Pk wcq1HqHgF0tY3x+RtCrnpMxDDnBEe8SJ0BHEXolyWkqcqyqoG/f1nH6I2rqYwiSYyPzZ /Srw== X-Gm-Message-State: AA6/9Rm86t8RRL6OQbIqGqa7FkDelvT8gG/Kpc6SkBoge3aqkZQrRZauR6iawuRmDoYSUv5Jyl4hvBYTEm8HRD5A X-Received: by 10.37.170.70 with SMTP id s64mr3824101ybi.35.1475649138287; Tue, 04 Oct 2016 23:32:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.196.4 with HTTP; Tue, 4 Oct 2016 23:31:57 -0700 (PDT) In-Reply-To: References: From: Priyanka Shendge Date: Wed, 5 Oct 2016 12:01:57 +0530 Message-ID: Subject: Re: Database child node: Cast node patch To: Dave Page Cc: pgadmin-hackers , Kanchan Mohitey Content-Type: multipart/alternative; boundary=94eb2c19bb1cb3ad8c053e18562c X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c19bb1cb3ad8c053e18562c Content-Type: text/plain; charset=UTF-8 On 4 October 2016 at 19:36, Dave Page wrote: > Hi > > On Tue, Oct 4, 2016 at 9:01 AM, Priyanka Shendge > wrote: > > I applied this patch on clean machine and executed testsuite only for > "cast" > > node, i did not face any issue. > > When i tried to execute testsuite for all nodes, i get same output as you > > mentioned above e-mail. (As few variable name > > have changed later on in test_utils.py file and those are yet to change > in > > server and database API cases. So while importing > > those variables its throwing import error.) Also, me and Navnath have > > verified that this output is not related to setup.py changes. > > (7175929cab984e070d15eb13625ab50459edf9ca) > > > > Could you please try running testsuite only for cast node (python > > regression/runtests.py --pkg browser.server_groups.servers. > databases.casts) > > and let me know if there are any issues. > > No, I don't see the issue if I only run the cast tests. > Correct. > > I'm not sure how this helps though - I still see the problem if I run > all tests with the patch applied. If I revert the patch, it goes away. > Therefore it's definitely being triggered by the cast patch, if not, > caused by it. > Yes, the import errors you are getting its because "Cast" patch, as i have changed the variables name from ../regression/__init__.py and test_setup.py file. In code cleanup we have removed variables(like picke_path, advanced_config_path) from test_setup.py. Those variables have reference to all API cases, which are need to change (except cast). We are integrating these changes along with new code to other API cases. For now you can you please ignore these errors? Once all API cases are in place there wont be any issues seen. Thank you. > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- Best, Priyanka EnterpriseDB Corporation The Enterprise PostgreSQL Company --94eb2c19bb1cb3ad8c053e18562c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

= On 4 October 2016 at 19:36, Dave Page <dave.page@enterprisedb.com= > wrote:
Hi

On Tue, Oct 4, 2016 at 9:01 AM, Priyanka Shendge
<priyanka.shendge@<= wbr>enterprisedb.com> wrote:
> I applied this patch on clean machine and executed testsuite only for = "cast"
> node, i did not face any issue.
> When i tried to execute testsuite for all nodes, i get same output as = you
> mentioned above e-mail. (As few variable name
> have changed later on in test_utils.py file and those are yet to chang= e in
> server and database API cases. So while importing
> those variables its throwing import error.)=C2=A0 Also, me and Navnath= have
> verified that this output is not related to setup.py changes.
> (7175929cab984e070d15eb13625ab50459edf9ca)
>
> Could you please try running testsuite only for cast node (python
> regression/runtests.py --pkg browser.server_groups.servers.databa= ses.casts)
> and let me know if there are any issues.

No, I don't see the issue if I only run the cast tests.

Correct.=C2=A0

I'm not sure how this helps though - I still see the problem if I run all tests with the patch applied. If I revert the patch, it goes away.
Therefore it's definitely being triggered by the cast patch, if not, caused by it.

Yes, the import errors yo= u are getting its because "Cast" patch, as i=C2=A0
have= changed the variables name from ../regression/__init__.py and test_setup.p= y=C2=A0file.
In code cleanup we have removed variables(like picke= _path, advanced_config_path) from test_setup.py.=C2=A0
Those vari= ables have reference to all API cases, which are need to change (except cas= t).
We are integrating these changes along with new code to o= ther API cases. For now you can you please=C2=A0
ignore these err= ors?=C2=A0Once all API cases are in place there wont be any issues seen.=C2= =A0

Thank you.

--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



--
=
Best,
Priyanka

EnterpriseDB Corp= oration
The Enterprise PostgreSQL Company
--94eb2c19bb1cb3ad8c053e18562c--