MIME-Version: 1.0
In-Reply-To: 
 <CA+OCxoyqfK8pUGGmeO=5pyC=MOizNMOnfshAfgQ5NjMRnkjgmA@mail.gmail.com>
References: 
 <CAKmZXFQ2Hj1-OZpSGFEBB-vOypQ_=1b4Yr_VytZ-E1=CBw9Yhw@mail.gmail.com>
 <CA+OCxow8Q83e7Tm+BC2bxq=oqwd-m4JS3y2KpzgFemc=wX=f=A@mail.gmail.com>
 <CAKmZXFTX9D_qOXGrvPa9sfFjc1A6VPebcpBn7vyzPEOH4pWfEg@mail.gmail.com>
 <CAKmZXFRj8yY91TTxwQQ01eOQE8Rc7FPWuxGcjxaVY+QcWpgWDg@mail.gmail.com>
 <CA+OCxoyqfK8pUGGmeO=5pyC=MOizNMOnfshAfgQ5NjMRnkjgmA@mail.gmail.com>
From: Priyanka Shendge <priyanka.shendge@enterprisedb.com>
Date: Wed, 15 Jun 2016 15:05:19 +0530
Message-ID: 
 <CAKmZXFSgdtd9NDE=TysR68_tcwqFB2Sv-h+qK4K4i1HjxOd5ng@mail.gmail.com>
Subject: Re: pgAdmin IV API test cases patch
To: Dave Page <dpage@pgadmin.org>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
	Kanchan Mohitey <kanchan.mohitey@enterprisedb.com>
Content-Type: multipart/alternative; boundary=001a1149e70027780605354dd8ca
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a1149e70027780605354dd8ca
Content-Type: text/plain; charset=UTF-8

Thanks a lot Dave.

On 15 June 2016 at 14:09, Dave Page <dpage@pgadmin.org> wrote:

> Hi
>
> On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge
> <priyanka.shendge@enterprisedb.com> wrote:
> > Hi Dave,
> >
> > PFA updated patch. I have made changes suggested by you.
> >
> > Kindly, review and let me know for more changes.
>
> OK, I got a bit further this time, but not there yet.
>
> 1) The patch overwrote my test_config.json file. That should never
> happen (that file shouldn't be in the source tree).
> test_config.json.in should be the file that's included in the patch.
>

OK.

>
> 2) The updated test_config.json file is huge. I should only need to
> define one or more connections, then be able to run the tests. If you
> need to keep configuration info for "advanced users", let's put it in
> a different file to avoid confusing/scaring everyone else. Maybe split
> it into config.json for the stuff the user needs to edit
> (config.json.in would go in git), and test_config.json for the test
> configuration.
>

Sure, i'll do that.

>
> 3) It fails on my machine, for what looks like a coding error
> initially, then a lot of issues where it can't find parent_id.pkl.
> I've attached the log.
>

I'll check and send you  an updated patch.

>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Best,
Priyanka

EnterpriseDB Corporation
The Enterprise PostgreSQL Company

--001a1149e70027780605354dd8ca
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks a lot Dave.=C2=A0<div class=3D"gmail_extra"><br><di=
v class=3D"gmail_quote">On 15 June 2016 at 14:09, Dave Page <span dir=3D"lt=
r">&lt;<a href=3D"mailto:dpage@pgadmin.org" target=3D"_blank">dpage@pgadmin=
.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<span class=3D""><br>
On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge<br>
&lt;<a href=3D"mailto:priyanka.shendge@enterprisedb.com">priyanka.shendge@e=
nterprisedb.com</a>&gt; wrote:<br>
&gt; Hi Dave,<br>
&gt;<br>
&gt; PFA updated patch. I have made changes suggested by you.<br>
&gt;<br>
&gt; Kindly, review and let me know for more changes.<br>
<br>
</span>OK, I got a bit further this time, but not there yet.<br>
<br>
1) The patch overwrote my test_config.json file. That should never<br>
happen (that file shouldn&#39;t be in the source tree).<br>
<a href=3D"http://test_config.json.in" rel=3D"noreferrer" target=3D"_blank"=
>test_config.json.in</a> should be the file that&#39;s included in the patc=
h.<br></blockquote><div><br></div><div>OK.=C2=A0</div><blockquote class=3D"=
gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-=
left:1ex">
<br>
2) The updated test_config.json file is huge. I should only need to<br>
define one or more connections, then be able to run the tests. If you<br>
need to keep configuration info for &quot;advanced users&quot;, let&#39;s p=
ut it in<br>
a different file to avoid confusing/scaring everyone else. Maybe split<br>
it into config.json for the stuff the user needs to edit<br>
(<a href=3D"http://config.json.in" rel=3D"noreferrer" target=3D"_blank">con=
fig.json.in</a> would go in git), and test_config.json for the test<br>
configuration.<br></blockquote><div>=C2=A0</div><div>Sure, i&#39;ll do that=
.=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;b=
order-left:1px #ccc solid;padding-left:1ex">
<br>
3) It fails on my machine, for what looks like a coding error<br>
initially, then a lot of issues where it can&#39;t find parent_id.pkl.<br>
I&#39;ve attached the log.<br></blockquote><div><br></div><div>I&#39;ll che=
ck and send you =C2=A0an updated patch.</div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"=
>
<br>
Thanks.<br>
<div class=3D"HOEnZb"><div class=3D"h5"><br>
--<br>
Dave Page<br>
Blog: <a href=3D"http://pgsnake.blogspot.com" rel=3D"noreferrer" target=3D"=
_blank">http://pgsnake.blogspot.com</a><br>
Twitter: @pgsnake<br>
<br>
EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" rel=3D"noreferrer"=
 target=3D"_blank">http://www.enterprisedb.com</a><br>
The Enterprise PostgreSQL Company<br>
</div></div></blockquote></div><br><br clear=3D"all"><div><br></div>-- <br>=
<div class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div dir=
=3D"ltr"><font face=3D"tahoma, sans-serif">Best,</font><div><font face=3D"t=
ahoma, sans-serif">Priyanka</font></div><div><br></div><div><font face=3D"t=
ahoma, sans-serif">EnterpriseDB Corporation<br>The Enterprise PostgreSQL Co=
mpany</font><br></div></div></div>
</div></div>

--001a1149e70027780605354dd8ca--