Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSQkk-0004rZ-UR for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Jul 2016 15:28:11 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bSQkk-0001IV-CY for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Jul 2016 15:28:10 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bSQkW-00014j-Vt for pgadmin-hackers@postgresql.org; Wed, 27 Jul 2016 15:27:57 +0000 Received: from mail-qt0-x230.google.com ([2607:f8b0:400d:c0d::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bSQkT-0003xW-RF for pgadmin-hackers@postgresql.org; Wed, 27 Jul 2016 15:27:55 +0000 Received: by mail-qt0-x230.google.com with SMTP id u25so31510049qtb.1 for ; Wed, 27 Jul 2016 08:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3hfH7AxQfG0aWuPuNprP3mEuK+1gzrzb4JybcSbnSO8=; b=Rna37LSKMRJ7FmV508wGbShV3NyPiD39MAsE48ZmZ6tSME3gmimDQvH6B40PhbqsZc VZLQ7Y4Cu17Sk2N2P2rcnL0a7krTxfnnCHssngLaV7tLXC2qkEfOBcMzGNeERzLJNLtG ogrWWgP7fwVa1wX9Bd+RWlBMWf+aOhbIBEHhsoQMIClMj0iGqTodb5gW/0plYqtsahLu RS9KpgizCLrUDJKUvJtxUvSx8bwH8ydy+YCzrvkeTbH3JmzWK8As6Ez2meQ57pfIKa33 SlwnW7L/ovd9dcIDmtEHLOD8o8LgjdXY8TV+TcoVE/FXzTbR7IssCIMXuFv/0OA52wFa n6tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3hfH7AxQfG0aWuPuNprP3mEuK+1gzrzb4JybcSbnSO8=; b=TJ5MwXeXhes5RpKRkiJy2jGEWvpWnl6WsYsNx4aycGHnGia6W5XmRKjGwp4FuWwvtJ 5VtKyKSS3t1HC2trQF9io9qJX0gGnVHnir+Ng+opB2Ns8WeKFLXZM4iIlnjLAIAvRcND c3gCpZEFsxS+uqZFmLe2W7j1mwu5JZvjcVBUGFhEVuyObo2XcwZcSerFxQ5sH/M4LEyR O0t3pbuT/xqL+hP0/TiBbBh+w0lSnEjd+a6umE41Htt70hsenTcyjf4yUd758vDLt7bP PFUs/6ZybPqAvnoUqmqfC1MjOPIXiAzb1DVTooVbusANbEjMpis/f2YJNOuuVjA0jRTG xXng== X-Gm-Message-State: AEkoouvqAQnaRnVj/0xDHPsLMRcSqZPS/S51M2aQE/XnY+FL9pchpwBhwRywAnt5A3rTLGQhjJQz19yOmurg1z7C X-Received: by 10.237.60.112 with SMTP id u45mr48825767qte.27.1469633272576; Wed, 27 Jul 2016 08:27:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.51.174 with HTTP; Wed, 27 Jul 2016 08:27:33 -0700 (PDT) In-Reply-To: References: From: Priyanka Shendge Date: Wed, 27 Jul 2016 20:57:33 +0530 Message-ID: Subject: Re: pgAdmin IV : Unittest modular patch To: Dave Page Cc: Navnath Gadakh , pgadmin-hackers , Kanchan Mohitey , Khushboo Vashi Content-Type: multipart/alternative; boundary=94eb2c1902fe298e8905389fa9c3 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c1902fe298e8905389fa9c3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 27 July 2016 at 20:12, Dave Page wrote: > Ahh, that explains it. Nice catch! It's working in both server and > desktop modes now :-). > Great. Thanks to Khushboo for helping Navnath in this task. Thank you. > On Wed, Jul 27, 2016 at 1:19 PM, Navnath Gadakh > wrote: > > Hi Dave, > > We have reproduced the issue you mentioned in the previous > > email. We need to skip the login related test cases when SERVER_MODE = =3D > > False in the web/config_local.py. > > > > Please find the revised patch for the same. > > > > Thanks! > > > > > > On Fri, Jul 22, 2016 at 9:48 PM, Dave Page > wrote: > >> Hi > >> > >> On Fri, Jul 22, 2016 at 2:22 PM, Navnath Gadakh > >> wrote: > >>> Hi Dave, > >>> > >>> Please find the attached patch for pgAdmin4 unittest(Support of AP= I > >>> testing with different servers i.e. PG and PPAS). > >>> > >>> This patch includes- > >>> > >>> Test framework support API testing with multiple server for this we > need to > >>> modify test_config.json(for user it=E2=80=99s test_config.json.in) an= d > >>> test_advanced_config.json(for user it=E2=80=99s test_advanced_config.= json.in). > >>> Server details of PG and PPAS are included in both .in files. > >>> > >>> Removed the logic of logging in the test client on each test > scenario(As > >>> per Khushboo's comment in previous email). We need this logic in tes= t > cases > >>> under =E2=80=98browser/tests/=E2=80=99 as for test scenarios like cha= nge password and > >>> invalid login test cases as test client should be logged out first. > So, as > >>> per this the code is slightly modified in =E2=80=98browser/tests/=E2= =80=99. > >> > >> OK in principle, but it doesn't seem to work: > >> > >> This function will add the server under default server group. (Default > >> Server Node url) ... ok > >> > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> FAIL: runTest > (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) > >> This function checks reset password functionality. (TestCase for > >> Validating Empty Email) > >> ---------------------------------------------------------------------- > >> Traceback (most recent call last): > >> File > "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_reset_password.= py", > >> line 44, in runTest > >> 'utf-8')) > >> AssertionError: 'Recover pgAdmin 4 Password' not found in u' >> HTML PUBLIC "-//W3C//DTD HTML 3.2 > >> > Final//EN">\nRedirecting...\n

Redirecting...

\n

Y= ou > >> should be redirected automatically to target URL: /. > >> If not click the link.' > >> > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> FAIL: runTest > (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) > >> This function checks reset password functionality. (TestCase for > >> Validating Invalid_Email) > >> ---------------------------------------------------------------------- > >> Traceback (most recent call last): > >> File > "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_reset_password.= py", > >> line 44, in runTest > >> 'utf-8')) > >> AssertionError: 'Recover pgAdmin 4 Password' not found in u' >> HTML PUBLIC "-//W3C//DTD HTML 3.2 > >> > Final//EN">\nRedirecting...\n

Redirecting...

\n

Y= ou > >> should be redirected automatically to target URL: /. > >> If not click the link.' > >> > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> FAIL: runTest > (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) > >> This function checks reset password functionality. (TestCase for > >> Validating Valid_Email) > >> ---------------------------------------------------------------------- > >> Traceback (most recent call last): > >> File > "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_reset_password.= py", > >> line 44, in runTest > >> 'utf-8')) > >> AssertionError: 'Recover pgAdmin 4 Password' not found in u' >> HTML PUBLIC "-//W3C//DTD HTML 3.2 > >> > Final//EN">\nRedirecting...\n

Redirecting...

\n

Y= ou > >> should be redirected automatically to target URL: /. > >> If not click the link.' > >> > >> ---------------------------------------------------------------------- > >> Ran 26 tests in 30.109s > >> > >> FAILED (failures=3D3) > >> > >> It's very far from obvious what's wrong here (/reset looks just fine > >> to me). How can we get more useful info out of the framework? > >> > >> -- > >> Dave Page > >> VP, Chief Architect, Tools & Installers > >> EnterpriseDB: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > >> > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > > > > > > > > -- > > Thanks, > > Navnath Gadakh > > Software Engineer > > EnterpriseDB Corporation > > Mobile: +91 9975389878 > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --=20 Best, Priyanka EnterpriseDB Corporation The Enterprise PostgreSQL Company --94eb2c1902fe298e8905389fa9c3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable



On 27 July 2016 at 20:12, Dave Page <dave.page@enterprisedb.c= om> wrote:
Ahh, that explai= ns it. Nice catch! It's working in both server and
desktop modes now :-).

Great. Thanks to= Khushboo for helping Navnath in this task.

Thank = you.
=C2=A0
On Wed, Jul 27, 2016 at 1:19 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0We have reproduced the issue you mentioned i= n the previous
> email. We need to skip the login related test cases when SERVER_MODE = =3D
> False in the web/config_local.py.
>
> Please find the revised patch for the same.
>
> Thanks!
>
>
> On Fri, Jul 22, 2016 at 9:48 PM, Dave Page <dave.page@enterprisedb.com> wrote:
>> Hi
>>
>> On Fri, Jul 22, 2016 at 2:22 PM, Navnath Gadakh
>> <navnath.gad= akh@enterprisedb.com> wrote:
>>> Hi Dave,
>>>
>>>=C2=A0 =C2=A0 Please find the attached patch for pgAdmin4 unitt= est(Support of API
>>> testing with different servers i.e. PG and PPAS).
>>>
>>> This patch includes-
>>>
>>> Test framework support API testing with multiple server for th= is we need to
>>> modify test_config.json(for user it=E2=80=99s test_config.jso= n.in) and
>>> test_advanced_config.json(for user it=E2=80=99s test= _advanced_config.json.in).
>>> Server details of PG and=C2=A0 PPAS are included in both .in f= iles.
>>>
>>> Removed the logic of logging in=C2=A0 the test client on each = test scenario(As
>>> per Khushboo's comment in previous email).=C2=A0 We need t= his logic in test cases
>>> under =E2=80=98browser/tests/=E2=80=99 as for test scenarios l= ike change password and
>>> invalid login test cases as test client should be logged out f= irst. So, as
>>> per this the code is slightly modified in =E2=80=98browser/tes= ts/=E2=80=99.
>>
>> OK in principle, but it doesn't seem to work:
>>
>> This function will add the server under default server group. (Def= ault
>> Server Node url) ... ok
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> FAIL: runTest (pgadmin.browser.tests.test_reset_password.ResetPass= wordTestCase)
>> This function checks reset password functionality. (TestCase for >> Validating Empty Email)
>> ------------------------------------------------------------------= ----
>> Traceback (most recent call last):
>>=C2=A0 =C2=A0File "/Users/dpage/git/pgadmin4/web/pgadmin/brows= er/tests/test_reset_password.py",
>> line 44, in runTest
>>=C2=A0 =C2=A0 =C2=A0'utf-8'))
>> AssertionError: 'Recover pgAdmin 4 Password' not found in = u'<!DOCTYPE
>> HTML PUBLIC "-//W3C//DTD HTML 3.2
>> Final//EN">\n<title>Redirecting...</title>\n&l= t;h1>Redirecting...</h1>\n<p>You
>> should be redirected automatically to target URL: <a href=3D&qu= ot;/">/</a>.
>> If not click the link.'
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> FAIL: runTest (pgadmin.browser.tests.test_reset_password.ResetPass= wordTestCase)
>> This function checks reset password functionality. (TestCase for >> Validating Invalid_Email)
>> ------------------------------------------------------------------= ----
>> Traceback (most recent call last):
>>=C2=A0 =C2=A0File "/Users/dpage/git/pgadmin4/web/pgadmin/brows= er/tests/test_reset_password.py",
>> line 44, in runTest
>>=C2=A0 =C2=A0 =C2=A0'utf-8'))
>> AssertionError: 'Recover pgAdmin 4 Password' not found in = u'<!DOCTYPE
>> HTML PUBLIC "-//W3C//DTD HTML 3.2
>> Final//EN">\n<title>Redirecting...</title>\n&l= t;h1>Redirecting...</h1>\n<p>You
>> should be redirected automatically to target URL: <a href=3D&qu= ot;/">/</a>.
>> If not click the link.'
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> FAIL: runTest (pgadmin.browser.tests.test_reset_password.ResetPass= wordTestCase)
>> This function checks reset password functionality. (TestCase for >> Validating Valid_Email)
>> ------------------------------------------------------------------= ----
>> Traceback (most recent call last):
>>=C2=A0 =C2=A0File "/Users/dpage/git/pgadmin4/web/pgadmin/brows= er/tests/test_reset_password.py",
>> line 44, in runTest
>>=C2=A0 =C2=A0 =C2=A0'utf-8'))
>> AssertionError: 'Recover pgAdmin 4 Password' not found in = u'<!DOCTYPE
>> HTML PUBLIC "-//W3C//DTD HTML 3.2
>> Final//EN">\n<title>Redirecting...</title>\n&l= t;h1>Redirecting...</h1>\n<p>You
>> should be redirected automatically to target URL: <a href=3D&qu= ot;/">/</a>.
>> If not click the link.'
>>
>> ------------------------------------------------------------------= ----
>> Ran 26 tests in 30.109s
>>
>> FAILED (failures=3D3)
>>
>> It's very far from obvious what's wrong here (/reset looks= just fine
>> to me). How can we get more useful info out of the framework?
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878



--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--
Sent via pgadmin-hacker= s mailing list (pgadmin-h= ackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=



--
=
Best,
Priyanka

EnterpriseDB Corporation
The Enterprise PostgreSQL Co= mpany
--94eb2c1902fe298e8905389fa9c3--