Re: Database child node: Cast node patch

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Priyanka Shendge <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Kanchan Mohitey <[email protected]>
Subject: Re: Database child node: Cast node patch
Date: Tue, 4 Oct 2016 13:31:50 +0530
Message-ID: <CAKmZXFTv6rOMoktLiw-wWNaNzH6N0Z-3DxJm9+N5b5h6Q6y_8g@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozZVXSNV1wkHn5Ef-hkvukh+s+QXV-6UbRs4YR7EgjWcw@mail.gmail.com>
References: <CAKmZXFTmr2DphVBEKR-bGHQVK2MHZHUea0fhxiWGDwWfVHy+Bg@mail.gmail.com>
	<CA+OCxozZVXSNV1wkHn5Ef-hkvukh+s+QXV-6UbRs4YR7EgjWcw@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

I applied this patch on clean machine and executed testsuite only for
"cast" node, i did not face any issue.
When i tried to execute testsuite for all nodes, i get same output as you
mentioned above e-mail. (As few variable name
have changed later on in test_utils.py file and those are yet to change in
server and database API cases. So while importing
those variables its throwing import error.)  Also, me and Navnath have
verified that this output is not related to setup.py changes.
(7175929cab984e070d15eb13625ab50459edf9ca)

Could you please try running testsuite only for cast node (python
regression/runtests.py --pkg browser.server_groups.servers.databases.casts)
and let me know if there are any issues.

Thank you.

On 3 October 2016 at 18:16, Dave Page <[email protected]> wrote:

> Hi
>
> On Wed, Sep 28, 2016 at 8:47 AM, Priyanka Shendge
> <[email protected]> wrote:
> > Hi Dave,
> >
> > Please find the attached patch for Cast node. (Changes required due to
> drop
> > objects functionality).
> >
> > To run test cases please enter following command:
> >
> > python regression/runtests.py --pkg
> > browser.server_groups.servers.databases.casts
> >
> > Let me know if any changes required.
>
> Whilst the tests pass, I get the following output immediately after
> the config database is created:
>
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
>
> Perhaps this is related to the setup.py change I had to revert in
> 7175929cab984e070d15eb13625ab50459edf9ca?
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>



-- 
Best,
Priyanka

EnterpriseDB Corporation
The Enterprise PostgreSQL Company

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Database child node: Cast node patch
  In-Reply-To: <CAKmZXFTv6rOMoktLiw-wWNaNzH6N0Z-3DxJm9+N5b5h6Q6y_8g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox