MIME-Version: 1.0
From: Rahul Shirsat <rahul.shirsat@enterprisedb.com>
Date: Thu, 26 Nov 2020 18:47:56 +0530
Message-ID: 
 <CAKtn9dM=dEKHahvsVKfvUrMPVY+r9iOkEtXHi2tUJpuzF3Nd-Q@mail.gmail.com>
Subject: Unable to download macros query results (reference #RM5965)
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000066ebc705b50261d2"
Precedence: bulk

--00000000000066ebc705b50261d2
Content-Type: text/plain; charset="UTF-8"

Hi Team,

Users are unable to download macros query results.

*Lets look out how download query result button works:*

For pgadmin4, always downloads the latest query result when the user makes
n-number of sql changes in the query tool, no need to execute, download
takes care of it. Does not work with macros as query is needed in the query
tool, which macros does not provide (While feature implementation, it was
decided that macros query won't be added to the query tool, as users may
lose any important queries in it).

In pgadmin3, always the last executed query result gets downloaded even if
the user makes n-number of sql changes in the query tool. Works with
macros. For the latest query change results, the user has to first execute
before every download.

For Macros, with the pgadmin4 approach, even if we implement a download
option, it would be difficult to decide whether to download the already ran
macros or to download the query result present in the query tool.

Please suggest.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.

--00000000000066ebc705b50261d2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Team,<div><br></div><div>Users are unable to download m=
acros query results.</div><div><br></div><div><b><u>Lets look out how downl=
oad query result button works:</u></b></div><br>For pgadmin4,=C2=A0always d=
ownloads the latest query result when the user makes n-number of sql change=
s=C2=A0in the query tool, no need to execute, download takes care of it. Do=
es not work with macros as query is needed in the query tool, which macros =
does not provide (While feature implementation, it was decided that macros =
query won&#39;t be added to the query tool, as users may lose any important=
 queries in it).<div><br></div><div><div>In pgadmin3, always the last execu=
ted query result gets downloaded even if the user makes n-number of sql cha=
nges=C2=A0in the query tool. Works with macros. For the latest query change=
 results, the user has to first execute before every download.</div><div><b=
r></div><div>For Macros, with the pgadmin4 approach, even if we implement a=
 download option, it would be difficult=C2=A0to decide whether to download =
the already ran macros or to download the query=C2=A0result present in the =
query tool.</div><div><br></div><div>Please suggest.</div><div><div><br></d=
iv>-- <br><div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmai=
l_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div s=
tyle=3D"color:rgb(0,0,0);font-family:Helvetica;font-size:12px"><b style=3D"=
color:rgb(96,96,97)">Rahul Shirsat</b><br></div><div style=3D"color:rgb(0,0=
,0);font-family:Helvetica;font-size:12px"><font color=3D"#5f5e5f">Senior So=
ftware Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.</font></div></di=
v></div></div></div></div></div></div></div>

--00000000000066ebc705b50261d2--