public inbox for [email protected]
help / color / mirror / Atom feedFrom: Rahul Shirsat <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
Date: Tue, 31 Mar 2020 14:15:47 +0530
Message-ID: <CAKtn9dM=z1nskBHmLJUUc5H-PucOMFuhqk2V_DGsqXpYL2wcvw@mail.gmail.com> (raw)
In-Reply-To: <CAKtn9dMak0bU7pR0jgb1tH=oBshrf08Ca9Xbcs_4rV+OhGiPgQ@mail.gmail.com>
References: <CAKtn9dMZd3Ff_bUXke==VJieAGs_XKL60us4LrYR4qqRv=ioog@mail.gmail.com>
<CANxoLDedBbZ-7T=ddnbmb0uCaM1tCmReq3fdMo48fYeboPguMg@mail.gmail.com>
<CAM9w-_k6iA7_-SxYaNY75X4bqhyK_GFun=uRrOUMD70oe=JT+A@mail.gmail.com>
<CAKtn9dMak0bU7pR0jgb1tH=oBshrf08Ca9Xbcs_4rV+OhGiPgQ@mail.gmail.com>
Hi,
Ignore the previous mail, find the latest patch attached.
On Tue, Mar 31, 2020 at 2:14 PM Rahul Shirsat <
[email protected]> wrote:
> Thanks Aditya for reviewing.
>
> I have made the relevant changes, please find the inclusive patch attached
> here.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
> On Tue, Mar 31, 2020 at 11:48 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Rahul,
>>
>> The patch looks good to me. But can you please remove the placeholder in
>> the properties tab. It looks like some value is set, but I kept it empty.
>> Refer below screenshot:
>>
>> [image: image.png]
>>
>> On Tue, Mar 31, 2020 at 11:24 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Aditya
>>>
>>> Can you please review it.
>>>
>>> On Mon, Mar 30, 2020 at 5:57 PM Rahul Shirsat <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the patch for pgagents schedules dates issue.
>>>>
>>>> --
>>>> *Rahul Shirsat*
>>>> Software Engineer | EnterpriseDB Corporation.
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Attachments:
[image/png] image.png (138.6K, 3-image.png)
download | view image
[application/octet-stream] RM3645_v2.patch (1.4K, 4-RM3645_v2.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index a57f70ebc..ec491096e 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -2977,7 +2977,7 @@ define([
data.cId = data.cId || _.uniqueId('pgC_');
- if (!data.disabled) {
+ if (!data.disabled && data.mode != 'properties') {
data.placeholder = data.placeholder || this.defaults.placeholder;
}
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index b05e1422f..cb45c2d6e 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -1804,15 +1804,11 @@ define([
this.$el.datetimepicker('destroy');
this.is_closing = false;
- if (_.isUndefined(newValue)) {
- model.trigger('backgrid:error', model, column, val);
- } else {
- model.set(column.get('name'), newValue);
- let command = new Backgrid.Command(ev);
- setTimeout(() => {
- model.trigger('backgrid:edited', model, column, command);
- }, 20);
- }
+ model.set(column.get('name'), newValue);
+ let command = new Backgrid.Command(ev);
+ setTimeout(() => {
+ model.trigger('backgrid:edited', model, column, command);
+ }, 20);
},
});
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
In-Reply-To: <CAKtn9dM=z1nskBHmLJUUc5H-PucOMFuhqk2V_DGsqXpYL2wcvw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox