public inbox for [email protected]
help / color / mirror / Atom feedFrom: Rahul Shirsat <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Dave Page <[email protected]>
Subject: Re: pgAdmin 4 commit: Fixed an issue where the validation error message is
Date: Thu, 3 Dec 2020 12:28:37 +0530
Message-ID: <CAKtn9dMD_U1fFFyNX2zUsfdQdbfJ_VzzBhTpOd_BngQebS2vOg@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQHFgKwkJQj3d+=VVnxmF_EgnT-26i6WO9zEJ86+x+DTQ@mail.gmail.com>
References: <[email protected]>
<CAKKotZRhwwSOBgtMSrgyFAqweMW8nVBhTQrLB9np0BDrM6e4wQ@mail.gmail.com>
<CAKKotZQHFgKwkJQj3d+=VVnxmF_EgnT-26i6WO9zEJ86+x+DTQ@mail.gmail.com>
On Thu, Dec 3, 2020 at 11:18 AM Murtuza Zabuawala <
[email protected]> wrote:
> Hello,
>
> Another observation,
>
> + if(msg && handler) {
> + msg = msg || _.values(handler.errorModel.attributes)[0];
> +
> + handler.trigger('pgadmin-session:model:invalid', msg, handler);
> + $(parentTr).addClass('error-in-grid');
> + }
> + return this;
> + }, 120);
> + },
>
> Here we are only making the model invalid, there is no logic to make it
> valid again.
>
If there are multiple model errors in the list, and if user changes any of
them, it used to clear every other invalid models in the list. To avoid
this to happen, only invalid models are highlighted, rest others are taken
care of by the child valid events running in parallel.
>
>
>
> On Thu, Dec 3, 2020 at 11:09 AM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hello,
>>
>> What is the reason for adding delay *setTimeout(<func>, 120)*?
>>
>> This is causing issues in automation testing and makes buttons
>> enable/disable with slight delay.
>>
>> Timeout was added for the reason that, even if the current changed
model is valid, it should also check the rest of the invalid models in the
list. Slight delay was added, so even if the current model becomes valid,
it should highlight the invalid one iterating over the inner model list.
> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>>
>> On Fri, Oct 30, 2020 at 3:10 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Fixed an issue where the validation error message is shown twice. Fixes
>>> #5736
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>>
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=183c83f0d2b2cb8dd33f9e8c41a030bc4cda...
>>> Author: Rahul Shirsat <[email protected]>
>>>
>>> Modified Files
>>> --------------
>>> docs/en_US/release_notes_4_28.rst | 1 +
>>> web/pgadmin/browser/static/js/datamodel.js | 75
>>> +++++++++++++++++++++++++++++-
>>> web/pgadmin/static/js/backform.pgadmin.js | 24 ++++------
>>> web/pgadmin/static/scss/_alert.scss | 6 +++
>>> 4 files changed, 90 insertions(+), 16 deletions(-)
>>>
>>>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
view thread (56+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Fixed an issue where the validation error message is
In-Reply-To: <CAKtn9dMD_U1fFFyNX2zUsfdQdbfJ_VzzBhTpOd_BngQebS2vOg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox