Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSDrE-0003Pf-Mr for pgadmin-hackers@arkaria.postgresql.org; Mon, 20 Sep 2021 07:36:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mSDrD-0004rc-Jz for pgadmin-hackers@arkaria.postgresql.org; Mon, 20 Sep 2021 07:36:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSDrD-0004rN-A9 for pgadmin-hackers@lists.postgresql.org; Mon, 20 Sep 2021 07:36:55 +0000 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mSDrB-0002tW-3i for pgadmin-hackers@postgresql.org; Mon, 20 Sep 2021 07:36:54 +0000 Received: by mail-il1-x12a.google.com with SMTP id b6so17681425ilv.0 for ; Mon, 20 Sep 2021 00:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GSbfh60IGrI2KJ//8jhBmoFgAaMKE4LGQ9/x+l15OQk=; b=OAPoFHXszGnn65r2WKaX3NpR3DVTGDUc6Kc6Owme9bQWeU2M//q7PXJQp0MKr7hi2N 9IaFc3RT7EkJPTrBNtccJrmHJgwgSHyz5CpfYF1eEKbQ2e4XjUGN0L3z6F5/SALtoL2i Su+gpW0cGVz+r66ZsdkuV0XEsS1fdSvIMhCB/0L8YeQrmMPVpZaQgrQtanzls88fTeGR w/8gy47QBMPkgqXoQUjiNc4PjgbdDjaBquFJhixy7UrG6MWOEoedb458LjO8liY7BeDA SpT/Eaiz+FCLBNTfeSxTaAhspLgshhXmsAxoA7vOJYzSqb6lonCyIMxTOlQAMhU2pUIB ddRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GSbfh60IGrI2KJ//8jhBmoFgAaMKE4LGQ9/x+l15OQk=; b=D5oO84hZGPCaPScjrgYtx9hyvjm3LE566hXH64F8ObJ3kZsKESS0Awq0ogxU02dmXh VHI3c0/02uwx2TyMBf+l//QhE26BTIfQTRrGJ4tAW6nzFB1qNc0qKwL8d3gF9+Vukhvf QUv61punsAJAcaL6EaZQXrHnQYuDhiIL6na/9X4HxK9d2fdoMHj5IdKi04OGY8SBwDi5 sxDdjc/vcOO+kJBMxghtdoqXJLcm1JdiYhtyL+42Syhg4iS4zgvHTBv/GedMJBlpL0Eo BFAB5YdtXCtrurUDUjLkzUmMIghZT7OjZyZRZosclZmon4UHixSEvIl94jNDUmoLJ8kW kQpw== X-Gm-Message-State: AOAM5329lXYlWQrSTS13/USv/ZtVmxOWu5SG8yf6MoNBgn211S6zMlti LoEJKi+f/+lpi1TZFmKZDAr0fxF9t+y8w+BRxQQ4HDOfnEE02KMhHk5HkDGdW15lixmgJoU5wWO tOc3Z4Gy2of4xgPCslVp9BK92WfBzqygqJe9ufUw7AZZxz0WMO7M5d97fcTsUHsPHqGb+PrUOhn 1SjYdvNFPPozVwfOTWMwk8D5tb23jGPWphOo4kpqqlrbjuWexM8MXbK3FCyvpS8Co= X-Google-Smtp-Source: ABdhPJykuxdLe+Q1ydKYH0VTIIN2Zy+9rXUMhkBLmG0HiV6GtXY7OnImrrnlGqBa7zs9LgllXBvTDH6FVmLfkz/X4aw= X-Received: by 2002:a05:6e02:1c0d:: with SMTP id l13mr9783060ilh.7.1632123412277; Mon, 20 Sep 2021 00:36:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rahul Shirsat Date: Mon, 20 Sep 2021 13:06:16 +0530 Message-ID: Subject: Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000038d75405cc68586a" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000038d75405cc68586a Content-Type: multipart/alternative; boundary="00000000000038d74f05cc685868" --00000000000038d74f05cc685868 Content-Type: text/plain; charset="UTF-8" Hi Akshay, Please find the updated patch. On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi wrote: > Hi Rahul > > Patch not applied, rebase and send the patch again. > > On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat < > rahul.shirsat@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which resolves the below issue: >> >> 1. Enum Type - Unable to delete rows for Enum type in Create Type >> dialogue. >> 2. Range Type - Loading icons are shown in different drop down tabs. >> >> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. --00000000000038d74f05cc685868 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

Please find the updated patc= h.

On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:=
Hi=C2=A0Rahul

Patch not applied, rebase and send the p= atch=C2=A0again.

On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat <rahul.shir= sat@enterprisedb.com> wrote:
Hi Hackers,

Please = find the attached patch which resolves the below issue:

1. Enum Type - Unable to delete rows for Enum type in Create Type dia= logue.
2. Range Type - Loading icons are shown in different drop = down tabs.

--
= Rahul Shirsat
Senior Software Engineer=C2=A0= |=C2=A0EnterpriseDB=C2=A0Corporation.
<= /div>


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.=
--00000000000038d74f05cc685868-- --00000000000038d75405cc68586a Content-Type: application/x-patch; name="RM6744_v2.patch" Content-Disposition: attachment; filename="RM6744_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ktsc06i50 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zY2hlbWFzL3R5cGVzL3N0YXRpYy9qcy90eXBlLnVpLmpzIGIvd2ViL3BnYWRtaW4v YnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdHlwZXMvc3Rh dGljL2pzL3R5cGUudWkuanMKaW5kZXggMTZkMTM4MTZiLi5kOTg5Y2U2ZTIgMTAwNjQ0Ci0tLSBh L3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hl bWFzL3R5cGVzL3N0YXRpYy9qcy90eXBlLnVpLmpzCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIv c2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3R5cGVzL3N0YXRpYy9qcy90 eXBlLnVpLmpzCkBAIC01NCw2ICs1NCw4IEBAIGZ1bmN0aW9uIGdldFJhbmdlU2NoZW1hKG5vZGVP YmosIHRyZWVOb2RlSW5mbywgaXRlbU5vZGVEYXRhKSB7CiAgICAgICAgICAgICB9KS5jYXRjaCgo ZXJyKT0+ewogICAgICAgICAgICAgICByZWplY3QoZXJyKTsKICAgICAgICAgICAgIH0pOworICAg ICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICByZXNvbHZlKGRhdGEpOwogICAgICAgICAgIH0K ICAgICAgICAgfSk7CiAgICAgICB9LApAQCAtODAsNiArODIsOCBAQCBmdW5jdGlvbiBnZXRSYW5n ZVNjaGVtYShub2RlT2JqLCB0cmVlTm9kZUluZm8sIGl0ZW1Ob2RlRGF0YSkgewogICAgICAgICAg ICAgfSkuY2F0Y2goKGVycik9PnsKICAgICAgICAgICAgICAgcmVqZWN0KGVycik7CiAgICAgICAg ICAgICB9KTsKKyAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgcmVzb2x2ZShkYXRhKTsK ICAgICAgICAgICB9CiAgICAgICAgIH0pOwogICAgICAgfSwKQEAgLTEwNyw2ICsxMTEsOCBAQCBm dW5jdGlvbiBnZXRSYW5nZVNjaGVtYShub2RlT2JqLCB0cmVlTm9kZUluZm8sIGl0ZW1Ob2RlRGF0 YSkgewogICAgICAgICAgICAgfSkuY2F0Y2goKGVycik9PnsKICAgICAgICAgICAgICAgcmVqZWN0 KGVycik7CiAgICAgICAgICAgICB9KTsKKyAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAg cmVzb2x2ZShkYXRhKTsKICAgICAgICAgICB9CiAgICAgICAgIH0pOwogICAgICAgfSwKQEAgLTE1 NywxMSArMTYzLDEwIEBAIGNsYXNzIEVudW1lcmF0aW9uU2NoZW1hIGV4dGVuZHMgQmFzZVVJU2No ZW1hIHsKICAgICByZXR1cm4gWwogICAgICAgewogICAgICAgICBpZDogJ2xhYmVsJywgbGFiZWw6 IGdldHRleHQoJ0xhYmVsJyksCi0gICAgICAgIHR5cGU6ICd0ZXh0JywgIGNlbGw6ICd0ZXh0JywK LSAgICAgICAgY2VsbEhlYWRlckNsYXNzZXM6ICd3aWR0aF9wZXJjZW50Xzk5JywKLSAgICAgICAg cmVhZG9ubHk6IGZ1bmN0aW9uIChzdGF0ZSkgewotICAgICAgICAgIHJldHVybiAhb2JqLmlzTmV3 KHN0YXRlKTsKLSAgICAgICAgfSwKKyAgICAgICAgdHlwZTogJ3RleHQnLCBjZWxsOiAndGV4dCcs IG1pbldpZHRoOiA2NDAsCisgICAgICAgIGVkaXRhYmxlOiAoc3RhdGUpID0+IHsKKyAgICAgICAg ICByZXR1cm4gXy5pc1VuZGVmaW5lZChvYmouaXNOZXcpID8gdHJ1ZSA6IG9iai5pc05ldyhzdGF0 ZSk7CisgICAgICAgIH0KICAgICAgIH0KICAgICBdOwogICB9CkBAIC0xMzEzLDYgKzEzMTgsMjQg QEAgZXhwb3J0IGRlZmF1bHQgY2xhc3MgVHlwZVNjaGVtYSBleHRlbmRzIEJhc2VVSVNjaGVtYSB7 CiAgICAgdGhpcy5ub2RlSW5mbyA9IHRoaXMuZmllbGRPcHRpb25zLm5vZGVfaW5mbzsKICAgfQog CisgIGlzSW52YWxpZENvbHVtbkFkZGVkKHN0YXRlKSB7CisKKyAgICBsZXQgdGVtcENvbCA9IF8u bWFwKHN0YXRlLmVudW0sICdsYWJlbCcpOworICAgIGxldCBkb250QWRkQ29sdW1uID0gZmFsc2U7 CisKKyAgICBpZih0ZW1wQ29sLmxlbmd0aCA9PSAxICYmIHRlbXBDb2xbMF0gPT0gdW5kZWZpbmVk KSB7CisgICAgICBkb250QWRkQ29sdW1uID0gdHJ1ZTsKKyAgICB9IGVsc2UgeworICAgICAgdGVt cENvbC5mb3JFYWNoKGZ1bmN0aW9uKGVudW1WYWwpIHsKKyAgICAgICAgaWYoZW51bVZhbCA9PSB1 bmRlZmluZWQpIHsKKyAgICAgICAgICBkb250QWRkQ29sdW1uID0gdHJ1ZTsKKyAgICAgICAgICBy ZXR1cm47CisgICAgICAgIH0KKyAgICAgIH0pOworICAgIH0KKyAgICByZXR1cm4gZG9udEFkZENv bHVtbjsKKyAgfQorCiAgIHNjaGVtYUNoZWNrKHN0YXRlKSB7CiAgICAgaWYodGhpcy5maWVsZE9w dGlvbnMubm9kZV9pbmZvICYmICdzY2hlbWEnIGluIHRoaXMuZmllbGRPcHRpb25zLm5vZGVfaW5m bykKICAgICB7CkBAIC0xNDIwLDE0ICsxNDQzLDE3IEBAIGV4cG9ydCBkZWZhdWx0IGNsYXNzIFR5 cGVTY2hlbWEgZXh0ZW5kcyBCYXNlVUlTY2hlbWEgewogICAgIHsKICAgICAgIGlkOiAnZW51bScs IGxhYmVsOiBnZXR0ZXh0KCdFbnVtZXJhdGlvbiB0eXBlJyksCiAgICAgICBzY2hlbWE6IG5ldyBF bnVtZXJhdGlvblNjaGVtYSgpLAotICAgICAgZWRpdGFibGU6IHRydWUsCiAgICAgICB0eXBlOiAn Y29sbGVjdGlvbicsCiAgICAgICBncm91cDogZ2V0dGV4dCgnRGVmaW5pdGlvbicpLCBtb2RlOiBb J2VkaXQnLCAnY3JlYXRlJ10sCi0gICAgICBjYW5BZGQ6IHRydWUsICBjYW5FZGl0OiBmYWxzZSwK LSAgICAgIGNhbkRlbGV0ZTogZnVuY3Rpb24oc3RhdGUpIHsKKyAgICAgIGNhbkFkZFJvdzogZnVu Y3Rpb24oc3RhdGUpIHsKKyAgICAgICAgcmV0dXJuICFvYmouaXNJbnZhbGlkQ29sdW1uQWRkZWQo c3RhdGUpOworICAgICAgfSwKKyAgICAgIGNhbkVkaXQ6IGZhbHNlLAorICAgICAgY2FuRGVsZXRl Um93OiBmdW5jdGlvbihzdGF0ZSkgewogICAgICAgICAvLyBXZSB3aWxsIGRpc2FibGUgaXQgaWYg aXQncyBpbiAnZWRpdCcgbW9kZQotICAgICAgICByZXR1cm4gIW9iai5pc05ldyhzdGF0ZSk7Cisg ICAgICAgIHJldHVybiBvYmouaXNOZXcoc3RhdGUpOwogICAgICAgfSwKKyAgICAgIGNhbkVkaXRS b3c6IGZhbHNlLAogICAgICAgZGlzYWJsZWQ6ICgpID0+IG9iai5pbkNhdGFsb2coKSwKICAgICAg IGRlcHM6IFsndHlwdHlwZSddLAogICAgICAgdW5pcXVlQ29sIDogWydsYWJlbCddLAo= --00000000000038d75405cc68586a--