public inbox for [email protected]
help / color / mirror / Atom feedFrom: Rahul Shirsat <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue
Date: Mon, 4 Oct 2021 18:34:13 +0530
Message-ID: <CAKtn9dNL0ji2Vi+fTqxnf82BCHCkGQg4rrMyr4kQLVw7mpeWzw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcqQOtfEouOBUqkJ7fmTNwEa4_-ZPSyNrrypndveCRFYA@mail.gmail.com>
References: <CAKtn9dNS_sLM2VUr3Ea5uPH2Pn9JjpCA1UWHRrAhtv6zLqFHYg@mail.gmail.com>
<CANxoLDdc-kod3WuyL-_P_8=TGNv-cqB-c=vsxMNqu4xQUj3pZg@mail.gmail.com>
<CAKtn9dMxhneUpidx2DeXG_76vf=oOWHNz5uekBDiqNaFECeHbQ@mail.gmail.com>
<CANxoLDexum5jPaYi6P6y7efXy-BPi7f96Wza=qCwNRtwQp2EpA@mail.gmail.com>
<CAKtn9dOZBftTQNZ-YQB2R8u2hxLC8oXvE2TZwGAHNeh3a9GMOA@mail.gmail.com>
<CANxoLDcqQOtfEouOBUqkJ7fmTNwEa4_-ZPSyNrrypndveCRFYA@mail.gmail.com>
Hi Hackers,
Please find the attached patch which resolves one more additional issue
reported by Aditya.
On Thu, Sep 30, 2021 at 3:32 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, the patch applied.
>
> On Thu, Sep 30, 2021 at 1:46 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for fixing some additional issues.
>>
>> On Mon, Sep 20, 2021 at 1:13 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks, the patch applied.
>>>
>>> On Mon, Sep 20, 2021 at 1:06 PM Rahul Shirsat <
>>> [email protected]> wrote:
>>>
>>>> Hi Akshay,
>>>>
>>>> Please find the updated patch.
>>>>
>>>> On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Rahul
>>>>>
>>>>> Patch not applied, rebase and send the patch again.
>>>>>
>>>>> On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Please find the attached patch which resolves the below issue:
>>>>>>
>>>>>> 1. Enum Type - Unable to delete rows for Enum type in Create Type
>>>>>> dialogue.
>>>>>> 2. Range Type - Loading icons are shown in different drop down tabs.
>>>>>>
>>>>>> --
>>>>>> *Rahul Shirsat*
>>>>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>> *pgAdmin Hacker | Principal Software Architect*
>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> *Rahul Shirsat*
>>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM6744_v4.patch (724B, 3-RM6744_v4.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js
index 14e385f76..bb9f82a7f 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js
@@ -1640,7 +1640,7 @@ export default class TypeSchema extends BaseUISchema {
if (state.typtype === 'p') {
var acl = state.typacl;
if(acl && acl.length > 0)
- acl.reset();
+ acl.splice(0, acl.length);
}
return (state.typtype !== 'p');
},
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue
In-Reply-To: <CAKtn9dNL0ji2Vi+fTqxnf82BCHCkGQg4rrMyr4kQLVw7mpeWzw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox