public inbox for [email protected]  
help / color / mirror / Atom feed
From: Rahul Shirsat <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin] RM5973 Option to Never Expire a user account is unintuitive
Date: Wed, 16 Dec 2020 18:40:09 +0530
Message-ID: <CAKtn9dNLm_LS5MsQKUOEqsNehWS6gG0SMMws6Pyuov_LEprRWA@mail.gmail.com> (raw)

Hi Hackers,

Please find the attached patch which adds more information for letting
users know about the account password expiry for Login/Group Role.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


Attachments:

  [application/octet-stream] RM5973.patch (1.0K, 3-RM5973.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js b/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
index e92741ba8..8b96053e2 100644
--- a/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
+++ b/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
@@ -413,7 +413,9 @@ define('pgadmin.node.role', [
           id: 'rolvaliduntil', readonly: 'readonly', type: 'text',
           group: gettext('Definition'), label: gettext('Account expires'),
           mode: ['properties', 'edit', 'create'], control: 'datetimepicker',
-          deps: ['rolcanlogin'], options: {format: 'YYYY-MM-DD HH:mm:ss Z'},
+          deps: ['rolcanlogin'],
+          placeholder: gettext('No Expiry'),
+          helpMessage: gettext('Please note that if you leave this field blank, then password will never expire.'),
         },{
           id: 'rolconnlimit',  type: 'int', group: gettext('Definition'),
           label: gettext('Connection limit'), cell: 'integer', min : -1,


view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin] RM5973 Option to Never Expire a user account is unintuitive
  In-Reply-To: <CAKtn9dNLm_LS5MsQKUOEqsNehWS6gG0SMMws6Pyuov_LEprRWA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox