public inbox for [email protected]
help / color / mirror / Atom feedFrom: Rahul Shirsat <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin] RM4892 pgAdmin "Inception"
Date: Tue, 12 Jan 2021 19:00:49 +0530
Message-ID: <CAKtn9dNn7cQaspHaxL95uaK3TY-KSmSvp9GD9NMyp13c-o1Anw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdne1MFtw1DA8Fu14FPayCUVcDUNAbqiP9CvDFOdhLOFw@mail.gmail.com>
References: <CAKtn9dMus8pTVv5p9o4PNQccZ04Pk0wAFRD=akpS5g5O2PDV7Q@mail.gmail.com>
<CAKtn9dM+LXgfi3iVtJ7LmsPzyqHsfw5jVUWqLL8qmvnrwEGV-g@mail.gmail.com>
<CANxoLDdne1MFtw1DA8Fu14FPayCUVcDUNAbqiP9CvDFOdhLOFw@mail.gmail.com>
Hi Hackers,
Please find the patch which reverts the previous changes. Code changes do
not solve the issue, so a workaround is mentioned in the RM to cater the
issue.
On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, patch applied.
>
> On Wed, Dec 23, 2020 at 8:23 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Just forgot to mention, patch consists of one more fix of a schema not
>> loading on several refresh of browser or startup of application - *FIXED*
>>
>> [image: image.png]
>>
>> On Wed, Dec 23, 2020 at 8:16 PM Rahul Shirsat <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch which resolves the issue of pgadmin
>>> Inception in Firefox browser.
>>>
>>> The fix is tested on:
>>>
>>> 1. MacOS 10.13.6 Firefox Browser 84.0 (64-bit)
>>> 2. Windows 2016 Firefox Browser 84.0.1 (64-bit)
>>>
>>> --
>>> *Rahul Shirsat*
>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[image/png] image.png (85.9K, 3-image.png)
download | view image
[application/octet-stream] RM4892_v2.patch (1.8K, 4-RM4892_v2.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/datagrid/static/js/datagrid.js b/web/pgadmin/tools/datagrid/static/js/datagrid.js
index 18cfb8cc2..a7d056683 100644
--- a/web/pgadmin/tools/datagrid/static/js/datagrid.js
+++ b/web/pgadmin/tools/datagrid/static/js/datagrid.js
@@ -299,7 +299,7 @@ define('pgadmin.datagrid', [
).set({'title': gettext('Rename Panel')});
});
- var openQueryToolURL = function(j, panel_url) {
+ var openQueryToolURL = function(j) {
// add spinner element
let $spinner_el =
$(`<div class="pg-sp-container">
@@ -315,20 +315,9 @@ define('pgadmin.datagrid', [
if (frameInitialized) {
clearInterval(init_poller_id);
var frame = $(j).data('embeddedFrame');
-
if (frame) {
frame.onLoaded(()=>{
$spinner_el.remove();
- // Fix for firefox backspace click causes pgadmin Inception - RM4892
- // start of code
- var current_browser = pgAdmin.Browser.get_browser();
- if (current_browser.name === 'Firefox') {
- frame.$iFrame[0].contentWindow.history.pushState(null, null, panel_url);
- frame.$iFrame[0].contentWindow.onpopstate = function () {
- frame.$iFrame[0].contentWindow.history.go(1);
- };
- }
- // end of code
});
frame.openHTML(queryToolForm);
}
@@ -336,7 +325,7 @@ define('pgadmin.datagrid', [
}, 100);
};
- openQueryToolURL(queryToolPanel, panel_url);
+ openQueryToolURL(queryToolPanel);
}
return true;
},
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin] RM4892 pgAdmin "Inception"
In-Reply-To: <CAKtn9dNn7cQaspHaxL95uaK3TY-KSmSvp9GD9NMyp13c-o1Anw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox