public inbox for [email protected]  

help / color / mirror / Atom feed

From: Rahul Shirsat <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [patch][pgAdmin] RM6949 When user Clicking on Reassign/Drop owned no dialog box opens
Date: Fri, 22 Oct 2021 14:05:23 +0530
Message-ID: <CAKtn9dO9yqtXeTyfB_L-AsE+kHw2suWfhPzi=C9pb0SVh_M37w@mail.gmail.com> (raw)

Hi Hackers,

Please find the attached patch which resolves the issue of not opening a
reassign/drop owned dialog box.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


Attachments:

  [application/octet-stream] RM6949.patch (1.1K, 3-RM6949.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js b/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
index c18e7c2c1..1d343012d 100644
--- a/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
+++ b/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
@@ -129,7 +129,7 @@ define('pgadmin.node.role', [
 
         var tree = pgBrowser.tree,
           _i = tree.selected(),
-          _d = _i && _i.length == 1 ? tree.itemData(_i) : undefined,
+          _d = _i ? tree.itemData(_i) : undefined,
           obj = this, finalUrl, old_role_name;
 
         //RoleReassign Model (Objects like role, database)
@@ -435,7 +435,7 @@ define('pgadmin.node.role', [
                 // Find current/selected node
                 var tree = pgBrowser.tree,
                   _i = tree.selected(),
-                  _d = _i && _i.length == 1 ? tree.itemData(_i) : undefined,
+                  _d = _i ? tree.itemData(_i) : undefined,
                   node = _d && pgBrowser.Nodes[_d._type];
 
                 finalUrl = obj.generate_url(_i, 'reassign' , _d, true);

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [patch][pgAdmin] RM6949 When user Clicking on Reassign/Drop owned no dialog box opens
  In-Reply-To: <CAKtn9dO9yqtXeTyfB_L-AsE+kHw2suWfhPzi=C9pb0SVh_M37w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox