public inbox for [email protected]
help / color / mirror / Atom feedFrom: Rahul Shirsat <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: [patch][pgAdmin] RM6858 Types collection properties tab delete issue
Date: Tue, 19 Oct 2021 16:45:05 +0530
Message-ID: <CAKtn9dOC_qzm2FGViAC=gYyMRNCyqJ3udyjXsjACv2pVWPVuVw@mail.gmail.com> (raw)
In-Reply-To: <CAKtn9dNCfJ_kO3anBnf=G3K+2Tr4bX_OvWApvEC4VYSYN_o+DA@mail.gmail.com>
References: <CAKtn9dNCfJ_kO3anBnf=G3K+2Tr4bX_OvWApvEC4VYSYN_o+DA@mail.gmail.com>
Hackers,
Please ignore the above mail. Find the updated patch attached.
On Tue, Oct 19, 2021 at 2:26 PM Rahul Shirsat <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the attached patch which resolves the Type collection delete
> issue.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM6858_v2.patch (2.2K, 3-RM6858_v2.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/static/js/constraints.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/static/js/constraints.js
index a3fd3030d..fa3f7e486 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/static/js/constraints.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/static/js/constraints.js
@@ -44,6 +44,7 @@ define('pgadmin.node.constraints', [
pgBrowser.add_menus([]);
},
model: pgAdmin.Browser.Node.Model.extend({
+ idAttribute: 'oid',
defaults: {
name: undefined,
oid: undefined,
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/static/js/partition.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/static/js/partition.js
index 210c333d2..146e004b4 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/static/js/partition.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/static/js/partition.js
@@ -319,6 +319,7 @@ function(
return getNodePartitionTableSchema(treeNodeInfo, itemNodeData, pgBrowser);
},
model: pgBrowser.Node.Model.extend({
+ idAttribute: 'oid',
defaults: {
name: undefined,
oid: undefined,
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js
index 314c9c187..d2374b126 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js
@@ -79,9 +79,9 @@ define('pgadmin.node.type', [
yet migrated to new react schema. Once the properties for collection
is removed, remove this model */
model: pgBrowser.Node.Model.extend({
+ idAttribute: 'oid',
defaults: {
name: undefined,
- oid: undefined,
is_sys_type: false,
typtype: undefined,
},
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [patch][pgAdmin] RM6858 Types collection properties tab delete issue
In-Reply-To: <CAKtn9dOC_qzm2FGViAC=gYyMRNCyqJ3udyjXsjACv2pVWPVuVw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox