public inbox for [email protected]  
help / color / mirror / Atom feed
From: Rahul Shirsat <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin] Bug #5831 Internal server error displayed if user open query tool window inside view data
Date: Mon, 14 Sep 2020 14:28:26 +0530
Message-ID: <CAKtn9dOL5Rc2XzphArET6z-isQBQOTQNvmu-tOKft-XzKme5uQ@mail.gmail.com> (raw)

Hi Hackers,

Please find the attached patch which fixes the open query tool window
inside view data.

-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.


Attachments:

  [application/octet-stream] RM5831.patch (631B, 3-RM5831.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
index ce02a53cb..8ff666393 100644
--- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
@@ -4302,7 +4302,7 @@ define('tools.querytool', [
           'trans_id': transId,
         });
 
-        url_endpoint += `?is_query_tool=${that.url_params.is_query_tool}`
+        url_endpoint += `?is_query_tool=${true}`
           +`&sgid=${that.url_params.sgid}`
           +`&sid=${that.url_params.sid}`
           +`&server_type=${that.url_params.server_type}`


view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin] Bug #5831 Internal server error displayed if user open query tool window inside view data
  In-Reply-To: <CAKtn9dOL5Rc2XzphArET6z-isQBQOTQNvmu-tOKft-XzKme5uQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox