MIME-Version: 1.0
From: Rahul Shirsat <rahul.shirsat@enterprisedb.com>
Date: Thu, 17 Dec 2020 19:07:25 +0530
Message-ID: 
 <CAKtn9dOhhQRniOZ1Wtd6bfapp+yxsy1Kxc+u=b_fdAAQRdJEWw@mail.gmail.com>
Subject: [pgAdmin] RM6084 Uncaught TypeError exception displayed on schema
 diff identical option
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000c2437305b6a9192a"
Precedence: bulk

--000000000000c2437305b6a9192a
Content-Type: multipart/alternative; boundary="000000000000c2437205b6a91928"

--000000000000c2437205b6a91928
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Please find the attached patch which resolves 2 issues:

   1. When the user applies the "Identical" filter before hitting the
   Compare button. (All Browsers)
   2. When comparing data is loaded, and when the user selects identical
   table comparison, infinite loader "Comparing objects..." shows up in
   Firefox.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.

--000000000000c2437205b6a91928
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Hackers,<div><br></div><div>Please find the attached pa=
tch which resolves 2 issues:</div><div><ol><li>When the user applies the &q=
uot;Identical&quot; filter before=C2=A0hitting the Compare button. (All Bro=
wsers)</li><li>When comparing data is loaded, and when the user selects ide=
ntical table comparison, infinite loader &quot;Comparing objects...&quot; s=
hows up in Firefox.</li></ol></div><div>-- <br><div dir=3D"ltr" class=3D"gm=
ail_signature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><div><di=
v dir=3D"ltr"><div dir=3D"ltr"><div style=3D"color:rgb(0,0,0);font-family:H=
elvetica;font-size:12px"><b style=3D"color:rgb(96,96,97)">Rahul Shirsat</b>=
<br></div><div style=3D"color:rgb(0,0,0);font-family:Helvetica;font-size:12=
px"><font color=3D"#5f5e5f">Senior Software Engineer=C2=A0|=C2=A0Enterprise=
DB=C2=A0Corporation.</font></div></div></div></div></div></div></div></div>

--000000000000c2437205b6a91928--

--000000000000c2437305b6a9192a
Content-Type: application/octet-stream; name="RM6084.patch"
Content-Disposition: attachment; filename="RM6084.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kisvs9320>
X-Attachment-Id: f_kisvs9320

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NjaGVtYV9kaWZmL3N0YXRpYy9qcy9zY2hl
bWFfZGlmZl91aS5qcyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NjaGVtYV9kaWZmL3N0YXRpYy9qcy9z
Y2hlbWFfZGlmZl91aS5qcwppbmRleCAxZjQ5OWU1Y2QuLjY3MzhhNjRiNCAxMDA2NDQKLS0tIGEv
d2ViL3BnYWRtaW4vdG9vbHMvc2NoZW1hX2RpZmYvc3RhdGljL2pzL3NjaGVtYV9kaWZmX3VpLmpz
CisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NjaGVtYV9kaWZmL3N0YXRpYy9qcy9zY2hlbWFfZGlm
Zl91aS5qcwpAQCAtNDU2LDcgKzQ1Niw5IEBAIGV4cG9ydCBkZWZhdWx0IGNsYXNzIFNjaGVtYURp
ZmZVSSB7CiAKICAgICBncmlkLm9uU2VsZWN0ZWRSb3dzQ2hhbmdlZC5zdWJzY3JpYmUoc2VsZi5o
YW5kbGVEZXBlbmRlbmNpZXMuYmluZCh0aGlzKSk7CiAKLSAgICBzZWxmLm1vZGVsLm9uKCdjaGFu
Z2U6ZGlmZl9kZGwnLCBzZWxmLmhhbmRsZURlcGVuZGVuY2llcy5iaW5kKHNlbGYpKTsKKyAgICBz
ZWxmLm1vZGVsLm9uKCdjaGFuZ2U6ZGlmZl9kZGwnLCBmdW5jdGlvbihldmVudCkgeworICAgICAg
c2VsZi5oYW5kbGVEZXBlbmRlbmNpZXMuYmluZChldmVudCwgc2VsZik7CisgICAgfSk7CiAKICAg
ICAkKCcjc2NoZW1hLWRpZmYtZ3JpZCcpLm9uKCdrZXl1cCcsIGZ1bmN0aW9uKCkgewogICAgICAg
aWYgKChldmVudC5rZXlDb2RlID09IDM4IHx8IGV2ZW50LmtleUNvZGUgPT00MCkgJiYgdGhpcy5n
cmlkLmdldEFjdGl2ZUNlbGwoKS5yb3cpIHsKQEAgLTgzMSw4ICs4MzMsMTIgQEAgZXhwb3J0IGRl
ZmF1bHQgY2xhc3MgU2NoZW1hRGlmZlVJIHsKICAgICAgICAgfQogICAgICAgfQogICAgIH0pOwot
ICAgIC8vIFJlZnJlc2ggdGhlIGdyaWQKLSAgICBzZWxmLmRhdGFWaWV3LnJlZnJlc2goKTsKKwor
ICAgIC8vIENoZWNrIHdoZXRoZXIgY29tcGFyaXNvbiBkYXRhIGlzIGxvYWRlZCBvciBub3QKKyAg
ICBpZighXy5pc1VuZGVmaW5lZChzZWxmLmRhdGFWaWV3KSAmJiAhXy5pc051bGwoc2VsZi5kYXRh
VmlldykpIHsKKyAgICAgIC8vIFJlZnJlc2ggdGhlIGdyaWQKKyAgICAgIHNlbGYuZGF0YVZpZXcu
cmVmcmVzaCgpOworICAgIH0KICAgfQogCiAgIGNvbm5lY3RfZGF0YWJhc2Uoc2VydmVyX2lkLCBk
Yl9pZCwgY2FsbGJhY2spIHsK
--000000000000c2437305b6a9192a--