MIME-Version: 1.0
References: 
 <CAKtn9dOL5Rc2XzphArET6z-isQBQOTQNvmu-tOKft-XzKme5uQ@mail.gmail.com>
In-Reply-To: 
 <CAKtn9dOL5Rc2XzphArET6z-isQBQOTQNvmu-tOKft-XzKme5uQ@mail.gmail.com>
From: Rahul Shirsat <rahul.shirsat@enterprisedb.com>
Date: Mon, 14 Sep 2020 17:37:19 +0530
Message-ID: 
 <CAKtn9dOoZWZB0MxUAjH_WLd91aAFsneZ4GcPbzF3EXp-C_NeCw@mail.gmail.com>
Subject: Re: [pgAdmin] Bug #5831 Internal server error displayed if user open
 query tool window inside view data
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000007c6a0e05af44e20c"
Precedence: bulk

--0000000000007c6a0e05af44e20c
Content-Type: multipart/alternative; boundary="0000000000007c6a0d05af44e20a"

--0000000000007c6a0d05af44e20a
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Please find below fixes :

   1. Query editor via view/edit data - fixed panel title issue.
   2. Fixed Schema diff panel title on new tab.


On Mon, Sep 14, 2020 at 2:28 PM Rahul Shirsat <
rahul.shirsat@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch which fixes the open query tool window
> inside view data.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>


-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.

--0000000000007c6a0d05af44e20a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Hackers,<div><br></div><div>Please find below fixes :</=
div><ol><li>Query editor via view/edit data - fixed panel title issue.</li>=
<li>Fixed Schema diff panel title on new tab.</li></ol></div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Sep 14, 2020=
 at 2:28 PM Rahul Shirsat &lt;<a href=3D"mailto:rahul.shirsat@enterprisedb.=
com">rahul.shirsat@enterprisedb.com</a>&gt; wrote:<br></div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Hackers,<div><br></d=
iv><div>Please find the attached patch which fixes the open query tool wind=
ow inside view data.<br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr=
"><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div style=3D"col=
or:rgb(0,0,0);font-family:Helvetica;font-size:12px"><b style=3D"color:rgb(9=
6,96,97)">Rahul Shirsat</b><br></div><div style=3D"color:rgb(0,0,0);font-fa=
mily:Helvetica;font-size:12px"><font color=3D"#5f5e5f">Software Engineer=C2=
=A0|=C2=A0EnterpriseDB=C2=A0Corporation.</font></div></div></div></div></di=
v></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=
=3D"ltr"><div style=3D"color:rgb(0,0,0);font-family:Helvetica;font-size:12p=
x"><b style=3D"color:rgb(96,96,97)">Rahul Shirsat</b><br></div><div style=
=3D"color:rgb(0,0,0);font-family:Helvetica;font-size:12px"><font color=3D"#=
5f5e5f">Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.</font>=
</div></div></div></div></div></div>

--0000000000007c6a0d05af44e20a--

--0000000000007c6a0e05af44e20c
Content-Type: application/octet-stream; name="RM5831_v2.patch"
Content-Disposition: attachment; filename="RM5831_v2.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kf2hesoo0>
X-Attachment-Id: f_kf2hesoo0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NjaGVtYV9kaWZmL3RlbXBsYXRlcy9zY2hl
bWFfZGlmZi9pbmRleC5odG1sIGIvd2ViL3BnYWRtaW4vdG9vbHMvc2NoZW1hX2RpZmYvdGVtcGxh
dGVzL3NjaGVtYV9kaWZmL2luZGV4Lmh0bWwKaW5kZXggZWY2ODdiOGU4Li43ZmE3NjgzZDMgMTAw
NjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NjaGVtYV9kaWZmL3RlbXBsYXRlcy9zY2hlbWFf
ZGlmZi9pbmRleC5odG1sCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NjaGVtYV9kaWZmL3RlbXBs
YXRlcy9zY2hlbWFfZGlmZi9pbmRleC5odG1sCkBAIC0yMSw2ICsyMSw3IEBAIHRyeSB7CiB7JSBi
bG9jayBjc3NfbGluayAlfQogPGxpbmsgdHlwZT0idGV4dC9jc3MiIHJlbD0ic3R5bGVzaGVldCIg
aHJlZj0ie3sgdXJsX2ZvcignYnJvd3Nlci5icm93c2VyX2NzcycpfX0iLz4KIHslIGVuZGJsb2Nr
ICV9Cit7JSBibG9jayB0aXRsZSAlfXt7ZWRpdG9yX3RpdGxlfX17JSBlbmRibG9jayAlfQogeyUg
YmxvY2sgYm9keSAlfQogPGRpdiBpZD0ic2NoZW1hLWRpZmYtY29udGFpbmVyIj4KICAgICA8ZGl2
IGlkPSJkaWZmX2ZldGNoaW5nX2RhdGEiIGNsYXNzPSJwZy1zcC1jb250YWluZXIgc2NoZW1hLWRp
ZmYtYnVzeS1mZXRjaGluZyBkLW5vbmUiPgpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vdG9vbHMv
c3FsZWRpdG9yL3N0YXRpYy9qcy9zcWxlZGl0b3IuanMgYi93ZWIvcGdhZG1pbi90b29scy9zcWxl
ZGl0b3Ivc3RhdGljL2pzL3NxbGVkaXRvci5qcwppbmRleCBjZTAyYTUzY2IuLjM2NDZhOTc1MCAx
MDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9qcy9zcWxlZGl0
b3IuanMKKysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9qcy9zcWxlZGl0
b3IuanMKQEAgLTQzMDIsMTMgKzQzMDIsMjQgQEAgZGVmaW5lKCd0b29scy5xdWVyeXRvb2wnLCBb
CiAgICAgICAgICAgJ3RyYW5zX2lkJzogdHJhbnNJZCwKICAgICAgICAgfSk7CiAKLSAgICAgICAg
dXJsX2VuZHBvaW50ICs9IGA/aXNfcXVlcnlfdG9vbD0ke3RoYXQudXJsX3BhcmFtcy5pc19xdWVy
eV90b29sfWAKKyAgICAgICAgdXJsX2VuZHBvaW50ICs9IGA/aXNfcXVlcnlfdG9vbD0ke3RydWV9
YAogICAgICAgICAgICtgJnNnaWQ9JHt0aGF0LnVybF9wYXJhbXMuc2dpZH1gCiAgICAgICAgICAg
K2Amc2lkPSR7dGhhdC51cmxfcGFyYW1zLnNpZH1gCi0gICAgICAgICAgK2Amc2VydmVyX3R5cGU9
JHt0aGF0LnVybF9wYXJhbXMuc2VydmVyX3R5cGV9YAotICAgICAgICAgICtgJmRpZD0ke3RoYXQu
dXJsX3BhcmFtcy5kaWR9YDsKKyAgICAgICAgICArYCZzZXJ2ZXJfdHlwZT0ke3RoYXQudXJsX3Bh
cmFtcy5zZXJ2ZXJfdHlwZX1gOwogCi0gICAgICAgIGxhdW5jaERhdGFHcmlkKHBnV2luZG93LmRl
ZmF1bHQucGdBZG1pbi5EYXRhR3JpZCwgdHJhbnNJZCwgdXJsX2VuZHBvaW50LCB0aGF0LnVybF9w
YXJhbXMudGl0bGUsICcnLCBhbGVydGlmeSk7CisgICAgICAgIGlmKHRoYXQudXJsX3BhcmFtcy5k
aWQpIHsKKyAgICAgICAgICB1cmxfZW5kcG9pbnQgKz0gYCZkaWQ9JHt0aGF0LnVybF9wYXJhbXMu
ZGlkfWA7CisgICAgICAgIH0KKworICAgICAgICBsZXQgcGFuZWxfdGl0bGUgPSB0aGF0LnVybF9w
YXJhbXMudGl0bGU7CisgICAgICAgIGlmKHRoYXQudXJsX3BhcmFtcy5pc19xdWVyeV90b29sID09
ICdmYWxzZScpIHsvL2NoZWNrIHdoZXRoZXIgcXVlcnkgdG9vbCBpcyBoaXQgZnJvbSBWaWV3L0Vk
aXQKKyAgICAgICAgICB2YXIgc3BsaXRfdGl0bGUgPSB0aGF0LnVybF9wYXJhbXMudGl0bGUuc3Bs
aXQoJy8nKTsKKyAgICAgICAgICBpZihzcGxpdF90aXRsZS5sZW5ndGggPiAyKSB7CisgICAgICAg
ICAgICBwYW5lbF90aXRsZSA9IHNwbGl0X3RpdGxlW3NwbGl0X3RpdGxlLmxlbmd0aC0yXSArICcv
JyArIHNwbGl0X3RpdGxlW3NwbGl0X3RpdGxlLmxlbmd0aC0xXTsKKyAgICAgICAgICB9CisgICAg
ICAgIH0KKworICAgICAgICBsYXVuY2hEYXRhR3JpZChwZ1dpbmRvdy5kZWZhdWx0LnBnQWRtaW4u
RGF0YUdyaWQsIHRyYW5zSWQsIHVybF9lbmRwb2ludCwgcGFuZWxfdGl0bGUsICcnLCBhbGVydGlm
eSk7CiAgICAgICB9LAogCiAgICAgICAvKgo=
--0000000000007c6a0e05af44e20c--