public inbox for [email protected]
help / color / mirror / Atom feedFrom: Rahul Shirsat <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin] RM4847 & RM4849 Double % & Relation name issue Explain -> Statistics
Date: Thu, 11 Mar 2021 17:13:11 +0530
Message-ID: <CAKtn9dPMOPFhNv1+h+SFQUiex0S116rHHfVRqd0ftVKnWVe1VA@mail.gmail.com> (raw)
Hi Hackers,
Please find below patch which resolves:
RM4847 <https://redmine.postgresql.org/issues/4847; : If user select timing
under explain analyze the % displayed twice for query and table
RM4849 <https://redmine.postgresql.org/issues/4849; : Statistic per view
and materialized view should display for Explain Analyze
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM4849_RM4847.patch (2.0K, 3-RM4849_RM4847.patch)
download | inline diff:
diff --git a/web/pgadmin/misc/static/explain/js/explain.js b/web/pgadmin/misc/static/explain/js/explain.js
index 00e7a0ff6..e5dd542d9 100644
--- a/web/pgadmin/misc/static/explain/js/explain.js
+++ b/web/pgadmin/misc/static/explain/js/explain.js
@@ -206,27 +206,27 @@ define('pgadmin.misc.explain', [
' <th class="renderable timings d-none"><button disabled>',
gettext('Time spent') ,'</button></th>',
' <th class="renderable timings d-none"><button disabled>',
- gettext('%% of query') ,'</button></th>',
+ '% ', gettext('of query') ,'</button></th>',
' </tr>',
' </thead>',
' </table>',
' </div>',
' <div class="col-sm-6 col-xs-6">',
' <div class="col-xs-12 badge">',
- gettext('Statistics per Table'),
+ gettext('Statistics per Relation'),
' </div>',
' <table class="backgrid table presentation table-bordered ',
' table-hover" for="per_table">',
' <thead>',
' <tr>',
' <th class="renderable"><button disabled>',
- gettext('Table name') , '</button></th>',
+ gettext('Relation name') , '</button></th>',
' <th class="renderable"><button disabled>',
gettext('Scan count'), '</button></th>',
' <th class="renderable timings d-none"><button disabled>',
gettext('Total time') ,'</button></th>',
' <th class="renderable timings d-none"><button disabled>',
- gettext('%% of query') ,'</button></th>',
+ '% ', gettext('of query') ,'</button></th>',
' </tr>',
' <tr>',
' <th class="renderable"><button disabled>',
@@ -236,7 +236,7 @@ define('pgadmin.misc.explain', [
' <th class="renderable timings d-none"><button disabled>',
gettext('Sum of times') ,'</button></th>',
' <th class="renderable timings d-none"><button disabled>',
- gettext('%% of table') ,'</button></th>',
+ '% ', gettext('of relation') ,'</button></th>',
' </tr>',
' </thead>',
' </table>',
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin] RM4847 & RM4849 Double % & Relation name issue Explain -> Statistics
In-Reply-To: <CAKtn9dPMOPFhNv1+h+SFQUiex0S116rHHfVRqd0ftVKnWVe1VA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox