public inbox for [email protected]  

help / color / mirror / Atom feed

From: Rahul Shirsat <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][patch] RM4064 Window maximize/restore, standardize
Date: Mon, 24 May 2021 18:43:41 +0530
Message-ID: <CAKtn9dPwjVnWykoHnRPhKtEU0=Hu-1hMju5WTOq9psmeCLv7Kw@mail.gmail.com> (raw)

Hi Hackers,

Please find the attached patch for your reference, which adds the
functionality of window maximise/restore currently only for properties
dialog.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


Attachments:

  [application/octet-stream] RM4064.patch (3.4K, 3-RM4064.patch)
  download | inline diff:
diff --git a/web/package.json b/web/package.json
index 8ed32df9e..76ca44c02 100644
--- a/web/package.json
+++ b/web/package.json
@@ -122,7 +122,7 @@
     "tempusdominus-bootstrap-4": "^5.1.2",
     "tempusdominus-core": "^5.0.3",
     "underscore": "^1.13.1",
-    "webcabin-docker": "git+https://github.com/EnterpriseDB/wcDocker/#c4a3398b89588408dc705895675bce7bd7660d36",
+    "webcabin-docker": "git+https://github.com/EnterpriseDB/wcDocker/#89e006611f4d0fc24b0a098fa2041821d093be4f",
     "wkx": "^0.5.0"
   },
   "scripts": {
diff --git a/web/pgadmin/browser/static/js/node.js b/web/pgadmin/browser/static/js/node.js
index 1c5af3f57..ca3cb1e38 100644
--- a/web/pgadmin/browser/static/js/node.js
+++ b/web/pgadmin/browser/static/js/node.js
@@ -514,6 +514,7 @@ define('pgadmin.browser.node', [
         isCloseable: true,
         isPrivate: true,
         isLayoutMember: false,
+        canMaximise: true,
         elContainer: true,
         content: '<div class="obj_properties container-fluid"><div role="status" class="pg-panel-message">' + gettext('Please wait while we fetch information about the node from the server...') + '</div></div>',
         onCreate: function(myPanel, $container) {
diff --git a/web/pgadmin/browser/static/js/panel.js b/web/pgadmin/browser/static/js/panel.js
index c9e64132b..98dbc2a2a 100644
--- a/web/pgadmin/browser/static/js/panel.js
+++ b/web/pgadmin/browser/static/js/panel.js
@@ -18,7 +18,7 @@ define(
       var defaults = [
         'name', 'title', 'width', 'height', 'showTitle', 'isCloseable',
         'isPrivate', 'isLayoutMember', 'content', 'icon', 'events', 'onCreate', 'elContainer',
-        'canHide', 'limit', 'extraClasses',
+        'canHide', 'limit', 'extraClasses', 'canMaximise',
       ];
       _.extend(this, _.pick(options, defaults));
     };
@@ -37,6 +37,7 @@ define(
       panel: null,
       onCreate: null,
       elContainer: false,
+      canMaximise: false,
       limit: null,
       extraClasses: null,
       load: function(docker, title) {
@@ -69,6 +70,7 @@ define(
                 $container.addClass(that.extraClasses);
               }
 
+              myPanel.maximisable(!!that.canMaximise);
               myPanel.closeable(!!that.isCloseable);
               myPanel.layout().addItem($container);
               that.panel = myPanel;
diff --git a/web/pgadmin/static/scss/_webcabin.pgadmin.scss b/web/pgadmin/static/scss/_webcabin.pgadmin.scss
index c917c531d..444c7ff7e 100644
--- a/web/pgadmin/static/scss/_webcabin.pgadmin.scss
+++ b/web/pgadmin/static/scss/_webcabin.pgadmin.scss
@@ -64,6 +64,9 @@
   display: flex;
 }
 
+.wcFloating .wcFrameButtonBar {
+  flex-direction: row-reverse;
+}
 
 .wcLayout {
   display: block;
diff --git a/web/yarn.lock b/web/yarn.lock
index a5655468b..e517bf0fe 100644
--- a/web/yarn.lock
+++ b/web/yarn.lock
@@ -9002,9 +9002,9 @@ watchpack@^2.0.0:
     glob-to-regexp "^0.4.1"
     graceful-fs "^4.1.2"
 
-"webcabin-docker@git+https://github.com/EnterpriseDB/wcDocker/#c4a3398b89588408dc705895675bce7bd7660d36":
-  version "2.2.4-dev"
-  resolved "git+https://github.com/EnterpriseDB/wcDocker/#c4a3398b89588408dc705895675bce7bd7660d36"
+"webcabin-docker@git+https://github.com/EnterpriseDB/wcDocker/#89e006611f4d0fc24b0a098fa2041821d093be4f":
+  version "2.2.5"
+  resolved "git+https://github.com/EnterpriseDB/wcDocker/#89e006611f4d0fc24b0a098fa2041821d093be4f"
   dependencies:
     "@fortawesome/fontawesome-free" "^5.14.0"
     FileSaver "^0.10.0"

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][patch] RM4064 Window maximize/restore, standardize
  In-Reply-To: <CAKtn9dPwjVnWykoHnRPhKtEU0=Hu-1hMju5WTOq9psmeCLv7Kw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox