Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ez0TR-0000Oi-Es for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 13:41:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ez0TQ-0004Y4-9t for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 13:41:44 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ez0TO-0004Xu-WB for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 13:41:44 +0000 Received: from mail-it0-x243.google.com ([2607:f8b0:4001:c0b::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ez0TM-0004xb-2N for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 13:41:41 +0000 Received: by mail-it0-x243.google.com with SMTP id e195-v6so11394210ita.5 for ; Thu, 22 Mar 2018 06:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=0/R60qYZ+78FMDhXdlG05+6eNaIZbKdkVF53J/xUrJg=; b=iCO/pwPcHPviO97JBzvGT/7wO8AfPpW1VkVNtrtejoRMRN+6g8erf+tyopcD/NvJrL U+5tdWxQRDBQlDNC3DO0nWbAiMD/lltNKQprf6MYNIsbVw18zqDTKaJ2d0+dlBahAq/A hVRAvR6tyXytg9Eair9ZLkVInypsi6PtS9jCKqBZdXwS5oWLs5CYn72Da4X3gwKVarpX 2/cS8S6fbhY91SpxTD1JG1ytBQjGxERO7Wo920Xw/bWfAQafQv894LQjXNP69BFGLMNt CWvNeG7Fj8+SW4w91NQC6qOR7N7NMPJfzSp/z84U2EXCS7aVrvtXJ7+nyL2x4TQYqwqm ejIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=0/R60qYZ+78FMDhXdlG05+6eNaIZbKdkVF53J/xUrJg=; b=MUNQHYZfI0ftaWweEUT/94gAXEVHyUagbt+59lHGvxCjMNITkVJaFw1LY4LuzRcEVi ZkhvzZT4snqkIT6kMh9XUJQupoLyhNsgt4FyO7y0lZZTZ7fZL2SZWPugcxlZR6Y8igCM c1o7ZjwCIdBK6+ig7rultVtoAWd9vKEBOyOaQ+Md31/Y4qy2l9qYn5eUd674ysmpVgh2 WcXLYAEBlQ0G6Iw8I/R70GUlFIGcfnisKyBEVqxAwzFBGARk+Vxny1TroYQ7kWQqJJOk bBB5OWkexpx5ZTm5PYDG6paOUlsGTkbItihjSwd4X+3+OiuN+xgvb2GRwls4bPhpUxZZ mdig== X-Gm-Message-State: AElRT7H98A2dlewC0brK+jCWHIiBshH21RCmG/X9jyvRfw8nIE0AaVIS aRw3IsZyQ09p0SjfEaTEuMrdKdMkhRaSA/xZPgE= X-Google-Smtp-Source: AIpwx4+/yuF8tx/4J8bOELVRfV7yrcdliQO+8Q5h9IDgMw20KBHnXt0hNQBRcHzU/so2uK4FVZbExmvBNIPzN6/lLIE= X-Received: by 2002:a24:46cd:: with SMTP id j196-v6mr8497603itb.8.1521726099045; Thu, 22 Mar 2018 06:41:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.26.212 with HTTP; Thu, 22 Mar 2018 06:41:38 -0700 (PDT) In-Reply-To: References: From: Rahul Soshte Date: Thu, 22 Mar 2018 19:11:38 +0530 Message-ID: Subject: Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: Dave Page , pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="000000000000944e5d05680077c2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000944e5d05680077c2 Content-Type: text/plain; charset="UTF-8" there is a small typo in the target name "all" runtime-release needs to be changed runtime too. On Thu, Mar 22, 2018 at 4:50 PM, Dave Page wrote: > Thanks - patch applied with a minor change of the target name > "runtime-release" to "runtime" (runtime-debug remains the same). > > On Thu, Mar 22, 2018 at 9:28 AM, Rahul Soshte > wrote: > >> This is my first time trying to make a Patch. >> >> I am using Ubuntu 17.10. >> >> This patch is in reference to the Feature Added by Dave Page >> https://redmine.postgresql.org/issues/1305 >> >> I just added code to call makefile in runtime directory( >> $PGADMIN_SRC/runtime/Makefile ) from the top level directory's MakeFile ( >> $PGADMIN_SRC/Makefile ) >> >> >> I followed the checklist for submitting a patch sent by Murutuza Zabuawala >> >> <================================> >> Hello, >> >> Here is the common checklist to follow before sending patch to >> pgAdmin4-hackers group, >> >> 1) Get the latest pull from master branch. >> >> 2) Apply your patch and check if applies successfully on the latest code. >> >> 3) Check for PEP8 issues >> - activate virtual env >> - cd ../web >> - yarn run pep8 >> >> 4) Run regression test >> python regression/runtests.py >> >> - To run only UI/feature tests >> python regression/runtests.py --pkg feature_tests >> >> - To run regression test (without UI/Feature tests) >> python regression/runtests.py --exclude feature_tests >> >> 5) Run Jasmine tests >> - activate virtual env >> - cd ../web >> yarn run test:karma-once >> >> 6) Make sure to add or update help docs and screenshot(s) if you have >> added any new feature or changed any existing one. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> <===================================================> >> >> But I am facing some issues, >> Step 1,2,3 and 5 had no issues >> But when I tried step 4 it gave some errors >> I executed the following command >> >> *python regression/runtests.py * >> >> I got the following errors: >> 1)The screenshot attached show I wasnt able to connect to the server >> 2) the error ouput on the command line: >> =============Running the test cases for 'PostgreSQL 9.4'============= >> Traceback (most recent call last): >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 128, in create_database >> server['sslmode'] >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 36, in get_db_connection >> sslmode=sslmode >> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >> line 130, in connect >> conn = _connect(dsn, connection_factory=connection_factory, >> **kwasync) >> OperationalError: FATAL: password authentication failed for user >> "postgres" >> FATAL: password authentication failed for user "postgres" >> >> Traceback (most recent call last): >> File "regression/runtests.py", line 350, in >> server_information = test_utils.create_parent_server_node(server) >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 491, in create_parent_server_node >> server_info['sslmode'] >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 36, in get_db_connection >> sslmode=sslmode >> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >> line 130, in connect >> conn = _connect(dsn, connection_factory=connection_factory, >> **kwasync) >> psycopg2.OperationalError: FATAL: password authentication failed for >> user "postgres" >> FATAL: password authentication failed for user "postgres" >> >> Traceback (most recent call last): >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 619, in _cleanup >> connection = get_db_server(database["server_id"]) >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 593, in get_db_server >> db_name, username, db_password, host, db_port, ssl_mode >> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >> line 36, in get_db_connection >> sslmode=sslmode >> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >> line 130, in connect >> conn = _connect(dsn, connection_factory=connection_factory, >> **kwasync) >> OperationalError: FATAL: password authentication failed for user >> "postgres" >> FATAL: password authentication failed for user "postgres" >> >> I have no password authentication errors when I am connecting from the >> application.I had also changed password for postgres manually through the >> command line. >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000944e5d05680077c2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
there is a small typo in the target name "all" r= untime-release needs to be changed runtime too.

On Thu, Mar 22, 2018 at 4:50 PM, Da= ve Page <dpage@pgadmin.org> wrote:
Thanks - patch applied with a minor change of t= he target name "runtime-release" to "runtime" (runtime-= debug remains the same).

On Thu, Mar 22, 2018 at 9:28 AM, Rahul = Soshte <rahulsoshte360@gmail.com> wrote:
This is my first= time trying to make a Patch.

I am using Ubuntu 17.10.

= This patch is in reference to the Feature Added by Dave Page
https://redm= ine.postgresql.org/issues/1305

I just added code to c= all makefile in runtime directory( $PGADMIN_SRC/runtime/Makefile ) from the= top level directory's MakeFile=C2=A0 ( $PGADMIN_SRC/Makefile )

=

I followed the checklist for submitting a patch sent by Mur= utuza Zabuawala

<=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D&= gt;
Hello,

Here is the common checklist to follow before sending pa= tch to pgAdmin4-hackers group,

1) Get the latest pull from master branch.

<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:r= gb(68,68,68)">2) Apply your patch and check if applies successfully on the = latest code.

3) Check for PEP8= issues
- activate virtual env
- cd= ../web
- yarn run pep8

4) Run regres= sion test
python regression/r= untests.py=C2=A0

- To run only UI/feature tests
python regression/runtests.py --pkg feature_tests=C2=A0

- To run regression test (without UI/Feature tests)
<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:r= gb(68,68,68)">python regr= ession/runtests.py --exclude feature_tests=C2=A0

5) Run Jasmine tests
- activate virtual env
- cd ../web
yarn run=C2=A0test:k= arma-once

6) Make sure to add or update help docs and screenshot(s) if you= have added any new=C2=A0feature=C2=A0or= changed any existing one.

--
Regards,
= Murtuza Zabuawala
E= nterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise= PostgreSQL Company
=
<=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>

But I am facing some issues,
Step 1,2,3 and 5 had no issues
But when I tried step 4 it = gave some errors
I executed the following command
=C2=A0python regression/runtests.py=C2=A0

= I got the following errors:
1)The screenshot attached show I = wasnt able to connect to the server
2) the error ouput on the= command line:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the test c= ases for 'PostgreSQL 9.4'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DTraceback (most recent call last):
=C2=A0 File "/var/www/flask/pga= dmin4/pgadmin4/web/regression/python_test_utils/test_utils.py&quo= t;, line 128, in create_database
=C2=A0=C2=A0=C2=A0 server['sslmode&= #39;]
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regres= sion/python_test_utils/test_utils.py", line 36, in get_db_connect= ion
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/f= lask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__= .py", line 130, in connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn= , connection_factory=3Dconnection_factory, **kwasync)
OperationalEr= ror: FATAL:=C2=A0 password authentication failed for user "postgres&qu= ot;
FATAL:=C2=A0 password authentication failed for user "postgres&= quot;

Traceback (most recent call last):
=C2=A0 File "regres= sion/runtests.py", line 350, in <module>
=C2=A0=C2=A0=C2=A0 s= erver_information =3D test_utils.create_parent_server_node(server)
= =C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regression/pyth= on_test_utils/test_utils.py", line 491, in create_parent_server_n= ode
=C2=A0=C2=A0=C2=A0 server_info['sslmode']
=C2=A0 File &qu= ot;/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_ut= ils/test_utils.py", line 36, in get_db_connection
=C2=A0=C2=A0=C2= =A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", line 130, i= n connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory= =3Dconnection_factory, **kwasync)
psycopg2.OperationalError: FATAL:= =C2=A0 password authentication failed for user "postgres"
FATA= L:=C2=A0 password authentication failed for user "postgres"
Traceback (most recent call last):
=C2=A0 File "/var/www/flask/pg= admin4/pgadmin4/web/regression/python_test_utils/test_utils.py&qu= ot;, line 619, in _cleanup
=C2=A0=C2=A0=C2=A0 connection =3D get_db_serv= er(database["server_id"])
=C2=A0 File "/var/www/flas= k/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.p= y", line 593, in get_db_server
=C2=A0=C2=A0=C2=A0 db_name, username= , db_password, host, db_port, ssl_mode
=C2=A0 File "/var/www/flask/= pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py&= quot;, line 36, in get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmod= e
=C2=A0 File "/var/www/flask/pgadmin4/local/lib/python2.7/sit= e-packages/psycopg2/__init__.py", line 130, in connect
=C2=A0= =C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory=3Dconnection_fa= ctory, **kwasync)
OperationalError: FATAL:=C2=A0 password authentication= failed for user "postgres"
FATAL:=C2=A0 password authenticati= on failed for user "postgres"

I have no passwor= d authentication errors when I am connecting from the application.I had als= o changed password for postgres manually through the command line.



--
Dave Page
Blo= g: http://pgsnake= .blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--000000000000944e5d05680077c2--