Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyxVC-0005KJ-4k for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 10:31:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyxVB-0008Pk-1A for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 10:31:21 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyxVA-0008PU-KI for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 10:31:20 +0000 Received: from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyxV5-0000a6-2x for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 10:31:19 +0000 Received: by mail-io0-x244.google.com with SMTP id d5so10342983iob.9 for ; Thu, 22 Mar 2018 03:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=R4Ut0fvqhV1SgaolIPXSWmfMOI/FpL1h+D7s+Mt4gtI=; b=cva51TS7H3LLVMgDFGSt2Omcp/vJLvv/25Y5W3U1l3k9L/1Dc6y7sc8u13nNuZ74Rh zNK93AR6Or765ZToAr04GXuyoBqlxHzzTZOX57jg0ywdlj/o6V+mqHXFQsBKYin7Huk7 beDSfRb6lm++nZyFP4rLLV6/Cgi/xF+1UTuIv8xeIdZnWa1n0cwaPjOTr5glUyYKK+ho RMmwPHVNs1uzKuTqkfy5Nl94iEMDJC8NcqZFLMlnke524P1NVBErV6ag7uB4jJscc4L0 yGaGEeuqYbCRFu7LEMYDIw8VoF7xl2DyFDV77XnugxWYUwpbWqxBgoDBGdsg2WGUxdPJ aBtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=R4Ut0fvqhV1SgaolIPXSWmfMOI/FpL1h+D7s+Mt4gtI=; b=pvU4/lnX0I+BTBB2D6lFuSRNggykgsVuKKz/8fJNg9fri416hiBmlcejSE0q+NMPs3 wEqWr/hVdiGmQFZaEj8ZRzS12FHP+n5aMBh2gtiECOg4IPdyxvEQka91WXfapI/KmbDs Lb/Eb5CzeWy+91689IOZTAIXPuqeQkJZx4D2OM5s9Gbk3bX8ry2P6OQru86Pl7uBvvpe ASWk63JIGfow38VxMagT3xoXMAVgrosG48HySIOB5UtLRK4a1Q289PITGqorBoDvAZ7+ PFhkRqilK2rlkkD6JY80UdyAHYGv1fMe+gH/xy+Nw6PcTSAjfdXOSH0EhzjJu+/swcFo z9Fw== X-Gm-Message-State: AElRT7G0LYyiwb88dqN4ob6c5xnK+UKZwGb1QgE8n+mPSbOH98caLryX unjk2hUqaDUYuXtv/UAzCQdhue9Y8q24YD8UuSIRXA== X-Google-Smtp-Source: AG47ELsVAq5ZblebRXFaUdUO/9b/O0qKE0CNuFTyzdd81g4booQvLBJstjINVEnTp0e0UfmzUH2k5aiJ+kaSZ4sx9Bw= X-Received: by 10.107.179.134 with SMTP id c128mr24906796iof.278.1521714673698; Thu, 22 Mar 2018 03:31:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.26.212 with HTTP; Thu, 22 Mar 2018 03:31:12 -0700 (PDT) In-Reply-To: References: From: Rahul Soshte Date: Thu, 22 Mar 2018 16:01:12 +0530 Message-ID: Subject: Fwd: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="001a11485418934e0c0567fdce41" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a11485418934e0c0567fdce41 Content-Type: text/plain; charset="UTF-8" ---------- Forwarded message ---------- From: Rahul Soshte Date: Thu, Mar 22, 2018 at 4:01 PM Subject: Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: Murtuza Zabuawala I am still getting the same error even when I did SERVER_MODE = False. On Thu, Mar 22, 2018 at 3:05 PM, Murtuza Zabuawala wrote: > You need to make SERVER_MODE = False in config_local.py in order to run > feature tests. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Mar 22, 2018 at 3:00 PM, Rahul Soshte > wrote: > >> how do I resolve those errors in step 4 of the checklist? >> >> >> On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte >> wrote: >> >>> This is my first time trying to make a Patch. >>> >>> I am using Ubuntu 17.10. >>> >>> This patch is in reference to the Feature Added by Dave Page >>> https://redmine.postgresql.org/issues/1305 >>> >>> I just added code to call makefile in runtime directory( >>> $PGADMIN_SRC/runtime/Makefile ) from the top level directory's MakeFile ( >>> $PGADMIN_SRC/Makefile ) >>> >>> >>> I followed the checklist for submitting a patch sent by Murutuza >>> Zabuawala >>> >>> <================================> >>> Hello, >>> >>> Here is the common checklist to follow before sending patch to >>> pgAdmin4-hackers group, >>> >>> 1) Get the latest pull from master branch. >>> >>> 2) Apply your patch and check if applies successfully on the latest code. >>> >>> 3) Check for PEP8 issues >>> - activate virtual env >>> - cd ../web >>> - yarn run pep8 >>> >>> 4) Run regression test >>> python regression/runtests.py >>> >>> - To run only UI/feature tests >>> python regression/runtests.py --pkg feature_tests >>> >>> - To run regression test (without UI/Feature tests) >>> python regression/runtests.py --exclude feature_tests >>> >>> 5) Run Jasmine tests >>> - activate virtual env >>> - cd ../web >>> yarn run test:karma-once >>> >>> 6) Make sure to add or update help docs and screenshot(s) if you have >>> added any new feature or changed any existing one. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> <===================================================> >>> >>> But I am facing some issues, >>> Step 1,2,3 and 5 had no issues >>> But when I tried step 4 it gave some errors >>> I executed the following command >>> >>> *python regression/runtests.py * >>> >>> I got the following errors: >>> 1)The screenshot attached show I wasnt able to connect to the server >>> 2) the error ouput on the command line: >>> =============Running the test cases for 'PostgreSQL 9.4'============= >>> Traceback (most recent call last): >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 128, in create_database >>> server['sslmode'] >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 36, in get_db_connection >>> sslmode=sslmode >>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>> line 130, in connect >>> conn = _connect(dsn, connection_factory=connection_factory, >>> **kwasync) >>> OperationalError: FATAL: password authentication failed for user >>> "postgres" >>> FATAL: password authentication failed for user "postgres" >>> >>> Traceback (most recent call last): >>> File "regression/runtests.py", line 350, in >>> server_information = test_utils.create_parent_server_node(server) >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 491, in create_parent_server_node >>> server_info['sslmode'] >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 36, in get_db_connection >>> sslmode=sslmode >>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>> line 130, in connect >>> conn = _connect(dsn, connection_factory=connection_factory, >>> **kwasync) >>> psycopg2.OperationalError: FATAL: password authentication failed for >>> user "postgres" >>> FATAL: password authentication failed for user "postgres" >>> >>> Traceback (most recent call last): >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 619, in _cleanup >>> connection = get_db_server(database["server_id"]) >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 593, in get_db_server >>> db_name, username, db_password, host, db_port, ssl_mode >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 36, in get_db_connection >>> sslmode=sslmode >>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>> line 130, in connect >>> conn = _connect(dsn, connection_factory=connection_factory, >>> **kwasync) >>> OperationalError: FATAL: password authentication failed for user >>> "postgres" >>> FATAL: password authentication failed for user "postgres" >>> >>> I have no password authentication errors when I am connecting from the >>> application.I had also changed password for postgres manually through the >>> command line. >>> >> >> > --001a11485418934e0c0567fdce41 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

---------- Forwarded messag= e ----------
From: Rahul Soshte <rahulsoshte360@= gmail.com>
Date: Thu, Mar 22, 2018 at 4:01 PM
Subject: = Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) M= akeFile
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>


I am still getting the same error even when I did SERVER_MODE = =3D False.

On Thu, Mar 22, 2018 at 3:05 PM,= Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.c= om> wrote:
You need to ma= ke SERVER_MODE =3D False = in config_local.py in order to run feature tests.

--
Regards,
<= font size=3D"2">Murtuz= a Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.comThe Enterprise PostgreSQL Company


On Thu, Mar 22, 2018 at 3:00 PM, Rahul Sosht= e <rahulsoshte360@gmail.com> wrote:
how do I resolve those errors in step 4 = of the checklist?


On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte <rahuls= oshte360@gmail.com> wrote:
=
This is my first time trying to make a= Patch.

I am using Ubuntu 17.10.

This patch is in refer= ence to the Feature Added by Dave Page
https://redmine.postgresql.org/issues/1305

I just added code to call makefile in runtim= e directory( $PGADMIN_SRC/runtime/Makefile ) from the top level directory&#= 39;s MakeFile=C2=A0 ( $PGADMIN_SRC/Makefile )


I foll= owed the checklist for submitting a patch sent by Murutuza Zabuawala

<= ;=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D>
Hello,

Here i= s the common checklist to follow before sending patch to pgAdmin4-ha= ckers group,

1) Get the latest pull from master branch.

2) Apply your patch and c= heck if applies successfully on the latest code.

3) Check for PEP8 issues
- activa= te virtual env
- cd ../web
- yarn= run pep8

4) Run regression t= est
python regression/runtests.py=C2=A0
<= div style=3D"font-size:small;font-style:normal;font-variant-ligatures:norma= l;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align= :start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:= 0px;text-decoration-style:initial;text-decoration-color:initial;font-family= :verdana,sans-serif;color:rgb(68,68,68)">
- To run only UI/feature tests
python regression/runtests.py --pkg = feature_tests=C2=A0
<= span style=3D"background-color:rgb(243,243,243)">
- To r= un regression test (without UI/Feature tests)
python regression/runtests.py --exclude feature_tests=C2= =A0

5) Run Jasmine te= sts
=
- activate virtual env
- cd ../web
yarn run=C2=A0test:karma-once

6) Make s= ure to add or update help docs and screenshot(s) if you have added any new= =C2=A0feature=C2=A0or changed any existi= ng one.

--
Regards,
= Murtuza Zabuawala
E= nterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise= PostgreSQL Company
=
<=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>

But I am facing some issues,
Step 1,2,3 and 5 had no issues
But when I tried step 4 it = gave some errors
I executed the following command
=C2=A0python regressio= n/runtests.py=C2=A0

I got the following erro= rs:
1)The screenshot attached show I wasnt able to connect to= the server
2) the error ouput on the command line:
=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the test cases for 'PostgreSQL= 9.4'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Traceback (most recent = call last):
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/= regression/python_test_utils/test_utils.py", line 128, in create_= database
=C2=A0=C2=A0=C2=A0 server['sslmode']
=C2=A0 File &qu= ot;/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_ut= ils/test_utils.py", line 36, in get_db_connection
=C2=A0=C2=A0=C2= =A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", line 130, i= n connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory= =3Dconnection_factory, **kwasync)
OperationalError: FATAL:=C2=A0 pa= ssword authentication failed for user "postgres"
FATAL:=C2=A0 = password authentication failed for user "postgres"

Traceba= ck (most recent call last):
=C2=A0 File "regression/runtests.py&quo= t;, line 350, in <module>
=C2=A0=C2=A0=C2=A0 server_information = =3D test_utils.create_parent_server_node(server)
=C2=A0 File "= /var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils= /test_utils.py", line 491, in create_parent_server_node
=C2=A0=C2= =A0=C2=A0 server_info['sslmode']
=C2=A0 File "/var/www/flas= k/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.p= y", line 36, in get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslm= ode
=C2=A0 File "/var/www/flask/pgadmin4/local/lib/python2.7/s= ite-packages/psycopg2/__init__.py", line 130, in connect
=C2= =A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory=3Dconnection_factory, **kwasync)
psycopg2.OperationalError: FATAL:=C2=A0 password au= thentication failed for user "postgres"
FATAL:=C2=A0 password = authentication failed for user "postgres"

Traceback (most = recent call last):
=C2=A0 File "/var/www/flask/pgadmin4/pgadmi= n4/web/regression/python_test_utils/test_utils.py", line 619, in = _cleanup
=C2=A0=C2=A0=C2=A0 connection =3D get_db_server(database["= server_id"])
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", line 593,= in get_db_server
=C2=A0=C2=A0=C2=A0 db_name, username, db_password, hos= t, db_port, ssl_mode
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", line 36, in= get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2=A0 File &= quot;/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/ps= ycopg2/__init__.py", line 130, in connect
=C2=A0=C2=A0=C2=A0 conn = =3D _connect(dsn, connection_factory=3Dconnection_factory, **kwasync)<= br>OperationalError: FATAL:=C2=A0 password authentication failed for user &= quot;postgres"
FATAL:=C2=A0 password authentication failed for user= "postgres"

I have no password authentication e= rrors when I am connecting from the application.I had also changed password= for postgres manually through the command line.




--001a11485418934e0c0567fdce41--