Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eywYG-0001NA-K8 for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 09:30:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eywYF-0003DZ-Go for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 09:30:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eywYF-0003DH-3t for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 09:30:27 +0000 Received: from mail-io0-x22f.google.com ([2607:f8b0:4001:c06::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eywY7-0007UL-SA for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 09:30:25 +0000 Received: by mail-io0-x22f.google.com with SMTP id o4so10122316iod.3 for ; Thu, 22 Mar 2018 02:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=oyn+6JWIjNnj8WHn55vUkh7iBnNUYKEwybE2fFpIJoc=; b=OAMddmA+YAD1S/TPCXGDSHLpjXo6Y9yJePU7aqOzMJhRgTSKb3HbNgpTOHuivzBwvw jBNdEVU2fvwn+k+AumXLKei0hDtHT3oQrpQ8KTNaBDf7tgc7lsNJSfRs6FrgO8wG9RNX BfLmCDepx+EUpgB2M0Y+l7iIoLbYQ1Gi5HNDzlZJ1jVqZ3QdfFCpVQkm5RQy5APo6r+i 8yiPfP04tPGix7YD1R0A5fahZa+LUM04OTLI73GOn/wguUHRL1cmBEc4H0CJhT8KrLlr E7RXGfIXVAKWy0EF0Cau//8piwESqFoS1hKZHCa5Vk1mjKvoqEXq3M2PybMw6CK8S+0B nMyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=oyn+6JWIjNnj8WHn55vUkh7iBnNUYKEwybE2fFpIJoc=; b=TtZngPsnW4pPXtEm0+PAmVvokA3nyVLcMnDAvEpo0pvqAVeAkvjEl2sk9JAsbs0EXP S7tsLDr/9inIyHzgF70xVdUtqj107hRcHWCUuO/dj/9HyvkDYjuwjUjHgT8rrxG7gALt 8iBee4pUyLvE8hHfsIRqP+2WUiGvuOP0Wll5czUmMCBrTApxij2NHC5zbugwShlMfKfL rIzhV7xVNf+cjlu6Xj3o8hVK/iPYuYFOD+ND+yCDb5xjb0Ic6h8uR3rcyJ3Ouj9H8GJP O9tQNaAOu0zu2gH1rqSUdzIZSewOXhg47e18bdO6wkS2YcIT/YukN/oYII548TwNA7Pk AP3Q== X-Gm-Message-State: AElRT7FwkdFZBfGwzXs4F3t4h0z69T01ZnTzp1bI0T+EQpD0ZZG0wS5n iKKW5kA0O9dk1qdLn16hMjzr2Out3z8f9moV+UsFHw== X-Google-Smtp-Source: AG47ELuuhyXZpUD5G4OtZzg/hTTSQTq3pmC4bHfhMcsV63TZm6gLJKBrq/yg5mncXjkYFYstv+ASqn6MeYDzIOZWWeg= X-Received: by 10.107.68.4 with SMTP id r4mr14639463ioa.161.1521711018511; Thu, 22 Mar 2018 02:30:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.26.212 with HTTP; Thu, 22 Mar 2018 02:30:17 -0700 (PDT) In-Reply-To: References: From: Rahul Soshte Date: Thu, 22 Mar 2018 15:00:17 +0530 Message-ID: Subject: Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="089e0825e388b591e40567fcf4d0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --089e0825e388b591e40567fcf4d0 Content-Type: text/plain; charset="UTF-8" how do I resolve those errors in step 4 of the checklist? On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte wrote: > This is my first time trying to make a Patch. > > I am using Ubuntu 17.10. > > This patch is in reference to the Feature Added by Dave Page > https://redmine.postgresql.org/issues/1305 > > I just added code to call makefile in runtime directory( > $PGADMIN_SRC/runtime/Makefile ) from the top level directory's MakeFile ( > $PGADMIN_SRC/Makefile ) > > > I followed the checklist for submitting a patch sent by Murutuza Zabuawala > > <================================> > Hello, > > Here is the common checklist to follow before sending patch to > pgAdmin4-hackers group, > > 1) Get the latest pull from master branch. > > 2) Apply your patch and check if applies successfully on the latest code. > > 3) Check for PEP8 issues > - activate virtual env > - cd ../web > - yarn run pep8 > > 4) Run regression test > python regression/runtests.py > > - To run only UI/feature tests > python regression/runtests.py --pkg feature_tests > > - To run regression test (without UI/Feature tests) > python regression/runtests.py --exclude feature_tests > > 5) Run Jasmine tests > - activate virtual env > - cd ../web > yarn run test:karma-once > > 6) Make sure to add or update help docs and screenshot(s) if you have > added any new feature or changed any existing one. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > <===================================================> > > But I am facing some issues, > Step 1,2,3 and 5 had no issues > But when I tried step 4 it gave some errors > I executed the following command > > *python regression/runtests.py * > > I got the following errors: > 1)The screenshot attached show I wasnt able to connect to the server > 2) the error ouput on the command line: > =============Running the test cases for 'PostgreSQL 9.4'============= > Traceback (most recent call last): > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 128, in create_database > server['sslmode'] > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 36, in get_db_connection > sslmode=sslmode > File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", > line 130, in connect > conn = _connect(dsn, connection_factory=connection_factory, **kwasync) > OperationalError: FATAL: password authentication failed for user > "postgres" > FATAL: password authentication failed for user "postgres" > > Traceback (most recent call last): > File "regression/runtests.py", line 350, in > server_information = test_utils.create_parent_server_node(server) > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 491, in create_parent_server_node > server_info['sslmode'] > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 36, in get_db_connection > sslmode=sslmode > File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", > line 130, in connect > conn = _connect(dsn, connection_factory=connection_factory, **kwasync) > psycopg2.OperationalError: FATAL: password authentication failed for user > "postgres" > FATAL: password authentication failed for user "postgres" > > Traceback (most recent call last): > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 619, in _cleanup > connection = get_db_server(database["server_id"]) > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 593, in get_db_server > db_name, username, db_password, host, db_port, ssl_mode > File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", > line 36, in get_db_connection > sslmode=sslmode > File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", > line 130, in connect > conn = _connect(dsn, connection_factory=connection_factory, **kwasync) > OperationalError: FATAL: password authentication failed for user > "postgres" > FATAL: password authentication failed for user "postgres" > > I have no password authentication errors when I am connecting from the > application.I had also changed password for postgres manually through the > command line. > --089e0825e388b591e40567fcf4d0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
how do I resolve those errors in step 4 of the checklist?<= br>

On T= hu, Mar 22, 2018 at 2:58 PM, Rahul Soshte <rahulsoshte360@gmail.com= > wrote:
<= div>
This is my first time trying to make a Patch.
<= br>I am using Ubuntu 17.10.

This patch is in reference to the Featur= e Added by Dave Page
https://redmine.postgresql.org/issues/1305<= br>
I just added code to call makefile in runtime directory( $PGAD= MIN_SRC/runtime/Makefile ) from the top level directory's MakeFile=C2= =A0 ( $PGADMIN_SRC/Makefile )


I followed the checkli= st for submitting a patch sent by Murutuza Zabuawala

<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>
Hello,

<= /div>
Here is the common c= hecklist to follow before sending patch to pgAdmin4-hackers group,

1) Get the latest pull from master bra= nch.

2) Apply your patch and c= heck if applies successfully on the latest code.

3) Check for PEP8 issues
- activate = virtual env
- cd ../web
- yarn run pep8

4) Run regression test
python regression/runtests.py=C2=A0

- To run only UI/f= eature tests
= python regression/runtest= s.py --pkg feature_tests=C2=A0

- To run regression te= st (without UI/Feature tests)
python regression/runtests.py --exclude feature_te= sts=C2=A0

5) Run Jasmine tests
- activate virtual env
- cd ../web
=
yarn= run=C2=A0test:karma-once

<= span style=3D"background-color:rgb(255,255,255)">6) Make sure to add or update help docs and scre= enshot(s) if you have added any new=C2=A0featur= e=C2=A0or changed any existing one.

--
Regards,
Murtuza Zabuawala
Enterpr= iseDB:=C2=A0http://www.enterprisedb.com
The Enterprise Postg= reSQL Company
=
<=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>
=

But I am facing some issues,
Ste= p 1,2,3 and 5 had no issues
But when I tried step 4 it gave s= ome errors
I executed the following command
=C2=A0
python regression/runtests.py=C2=A0

I got = the following errors:
1)The screenshot attached show I wasnt = able to connect to the server
2) the error ouput on the comma= nd line:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the test cases f= or 'PostgreSQL 9.4'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Trace= back (most recent call last):
=C2=A0 File "/var/www/flask/pgadmin4/= pgadmin4/web/regression/python_test_utils/test_utils.py", li= ne 128, in create_database
=C2=A0=C2=A0=C2=A0 server['sslmode']<= br>=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regression/p= ython_test_utils/test_utils.py", line 36, in get_db_connection=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/flask/p= gadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py&qu= ot;, line 130, in connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, conn= ection_factory=3Dconnection_factory, **kwasync)
OperationalError: F= ATAL:=C2=A0 password authentication failed for user "postgres"FATAL:=C2=A0 password authentication failed for user "postgres"<= br>
Traceback (most recent call last):
=C2=A0 File "regression/r= untests.py", line 350, in <module>
=C2=A0=C2=A0=C2=A0 server_= information =3D test_utils.create_parent_server_node(server)
=C2=A0= File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", line 491, in create_parent_server_node=C2=A0=C2=A0=C2=A0 server_info['sslmode']
=C2=A0 File "/va= r/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/te= st_utils.py", line 36, in get_db_connection
=C2=A0=C2=A0=C2=A0 sslm= ode=3Dsslmode
=C2=A0 File "/var/www/flask/pgadmin4/local/lib/p= ython2.7/site-packages/psycopg2/__init__.py", line 130, in connec= t
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory=3Dconnect= ion_factory, **kwasync)
psycopg2.OperationalError: FATAL:=C2=A0 pas= sword authentication failed for user "postgres"
FATAL:=C2=A0 p= assword authentication failed for user "postgres"

Tracebac= k (most recent call last):
=C2=A0 File "/var/www/flask/pgadmin4/pga= dmin4/web/regression/python_test_utils/test_utils.py", line = 619, in _cleanup
=C2=A0=C2=A0=C2=A0 connection =3D get_db_server(databas= e["server_id"])
=C2=A0 File "/var/www/flask/pgadmin4= /pgadmin4/web/regression/python_test_utils/test_utils.py", l= ine 593, in get_db_server
=C2=A0=C2=A0=C2=A0 db_name, username, db_passw= ord, host, db_port, ssl_mode
=C2=A0 File "/var/www/flask/pgadmin4/p= gadmin4/web/regression/python_test_utils/test_utils.py", lin= e 36, in get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2= =A0 File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packag= es/psycopg2/__init__.py", line 130, in connect
=C2=A0=C2=A0=C2= =A0 conn =3D _connect(dsn, connection_factory=3Dconnection_factory, **= kwasync)
OperationalError: FATAL:=C2=A0 password authentication failed f= or user "postgres"
FATAL:=C2=A0 password authentication failed= for user "postgres"

I have no password authent= ication errors when I am connecting from the application.I had also changed= password for postgres manually through the command line.

--089e0825e388b591e40567fcf4d0--