Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyxm4-0006Iy-TJ for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 10:48:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyxm3-0002v0-W5 for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 10:48:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyxm3-0002up-Pf for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 10:48:47 +0000 Received: from mail-io0-x243.google.com ([2607:f8b0:4001:c06::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyxlw-0003KZ-2U for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 10:48:47 +0000 Received: by mail-io0-x243.google.com with SMTP id e7so10393418iof.2 for ; Thu, 22 Mar 2018 03:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=GpQJPaAKZ51wYcQBsEN7ZSv23SbshP9CkNOwBvzACHM=; b=OZmvOGKrdsq0OSOVTVimvQGmc3yXz2SmCSB6oeOcmgExaMwo+NkWZKRXppTr7yBJv9 G134lHwLhW7iT3xP22TdFGkvet2k9DhY8LNSBqsDNdwLYPNIRq6W7QUakLafoKaDgTpl Tlgf1mDR11xZo9E3CSzHUIS7weC8cm3RhIUIk8wz9DQlhdux72Z7biJu67TxtcrhFM0Y alYYRd6rnxBMthRDAox73NiZxexjzGbGDGeXmj9mMsqe6SEXbaAyhYXA5qeNDykAib1i rt0qAFtfwCJdztYle4sgqjXrpYmHDdKEmnmqlSrzu+mHEoOvAGSFGV5hIclRcRibtT4C sefQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=GpQJPaAKZ51wYcQBsEN7ZSv23SbshP9CkNOwBvzACHM=; b=eo1a/grwxNh/8Vx3Ki5vrRrCg2BhKUCHlS1mMbJzNXOf/WRgfGNdXoJtL24HRKLYYR TJFCkZ6q9UnwuqpSuvtvoL9irrhVeNf+WFanQ2sbR9UDoWEe+7kCSYAdy/h5hVwyU3s2 oa+31ocJdKeZtQ9DR7btbp9EkCSrgACEPQba47m3bF8V+fxpOgVQnKaYc3o2Jd4wXnPV cpgUs/pMGORWudNKiS41aMeXXPCBfFHqXvM5397/tdtVpUf5Evj7CvAuYU0MwJ5e8QjI 6zyiENBqKHXmF77C6yQuKNfAr2IcBjzjNWBeDXbuO/BmYjJIdZoDGSvZo4aWL3cawS5b JxtA== X-Gm-Message-State: AElRT7FD+Tj6WdKGGp7iQ6/brA5o0ZMPz0lLcAMCQl/1HMvApeBtJLxB Uo0DOXGRHwADg2SWw2MvYBLYb3IXvnlwYKKeZ70sFROQ X-Google-Smtp-Source: AG47ELsmnH9sey58OsFdhOcu/u9AtrZUzdoMLGr5I0FqmHv7cENhzXdqaK2n7bIoZorSW2r5CHQ3uR839aX78ZJ4iug= X-Received: by 10.107.68.4 with SMTP id r4mr14890412ioa.161.1521715717713; Thu, 22 Mar 2018 03:48:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.26.212 with HTTP; Thu, 22 Mar 2018 03:48:37 -0700 (PDT) In-Reply-To: References: From: Rahul Soshte Date: Thu, 22 Mar 2018 16:18:37 +0530 Message-ID: Subject: Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: pgadmin-hackers@postgresql.org, Murtuza Zabuawala Content-Type: multipart/alternative; boundary="089e0825e388cdb35f0567fe0c6d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --089e0825e388cdb35f0567fe0c6d Content-Type: text/plain; charset="UTF-8" Although I have postgresql-9.6 it is showing-Running the test cases for 'PostgreSQL 9.4' On Thu, Mar 22, 2018 at 4:17 PM, Rahul Soshte wrote: > Although I have postgresql-9.6 it is showing > -- > -- > Running the test cases for 'PostgreSQL 9.4' > > On Thu, Mar 22, 2018 at 4:01 PM, Rahul Soshte > wrote: > >> >> ---------- Forwarded message ---------- >> From: Rahul Soshte >> Date: Thu, Mar 22, 2018 at 4:01 PM >> Subject: Re: Little patch for Runtime build from Top Level >> Directory($PGADMIN_SRC) MakeFile >> To: Murtuza Zabuawala >> >> >> I am still getting the same error even when I did SERVER_MODE = False. >> >> On Thu, Mar 22, 2018 at 3:05 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> You need to make SERVER_MODE = False in config_local.py in order to run >>> feature tests. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> On Thu, Mar 22, 2018 at 3:00 PM, Rahul Soshte >>> wrote: >>> >>>> how do I resolve those errors in step 4 of the checklist? >>>> >>>> >>>> On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte >>> > wrote: >>>> >>>>> This is my first time trying to make a Patch. >>>>> >>>>> I am using Ubuntu 17.10. >>>>> >>>>> This patch is in reference to the Feature Added by Dave Page >>>>> https://redmine.postgresql.org/issues/1305 >>>>> >>>>> I just added code to call makefile in runtime directory( >>>>> $PGADMIN_SRC/runtime/Makefile ) from the top level directory's MakeFile ( >>>>> $PGADMIN_SRC/Makefile ) >>>>> >>>>> >>>>> I followed the checklist for submitting a patch sent by Murutuza >>>>> Zabuawala >>>>> >>>>> <================================> >>>>> Hello, >>>>> >>>>> Here is the common checklist to follow before sending patch to >>>>> pgAdmin4-hackers group, >>>>> >>>>> 1) Get the latest pull from master branch. >>>>> >>>>> 2) Apply your patch and check if applies successfully on the latest >>>>> code. >>>>> >>>>> 3) Check for PEP8 issues >>>>> - activate virtual env >>>>> - cd ../web >>>>> - yarn run pep8 >>>>> >>>>> 4) Run regression test >>>>> python regression/runtests.py >>>>> >>>>> - To run only UI/feature tests >>>>> python regression/runtests.py --pkg feature_tests >>>>> >>>>> - To run regression test (without UI/Feature tests) >>>>> python regression/runtests.py --exclude feature_tests >>>>> >>>>> 5) Run Jasmine tests >>>>> - activate virtual env >>>>> - cd ../web >>>>> yarn run test:karma-once >>>>> >>>>> 6) Make sure to add or update help docs and screenshot(s) if you have >>>>> added any new feature or changed any existing one. >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> <===================================================> >>>>> >>>>> But I am facing some issues, >>>>> Step 1,2,3 and 5 had no issues >>>>> But when I tried step 4 it gave some errors >>>>> I executed the following command >>>>> >>>>> *python regression/runtests.py * >>>>> >>>>> I got the following errors: >>>>> 1)The screenshot attached show I wasnt able to connect to the server >>>>> 2) the error ouput on the command line: >>>>> =============Running the test cases for 'PostgreSQL 9.4'============= >>>>> Traceback (most recent call last): >>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>> line 128, in create_database >>>>> server['sslmode'] >>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>> line 36, in get_db_connection >>>>> sslmode=sslmode >>>>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>>>> line 130, in connect >>>>> conn = _connect(dsn, connection_factory=connection_factory, >>>>> **kwasync) >>>>> OperationalError: FATAL: password authentication failed for user >>>>> "postgres" >>>>> FATAL: password authentication failed for user "postgres" >>>>> >>>>> Traceback (most recent call last): >>>>> File "regression/runtests.py", line 350, in >>>>> server_information = test_utils.create_parent_server_node(server) >>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>> line 491, in create_parent_server_node >>>>> server_info['sslmode'] >>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>> line 36, in get_db_connection >>>>> sslmode=sslmode >>>>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>>>> line 130, in connect >>>>> conn = _connect(dsn, connection_factory=connection_factory, >>>>> **kwasync) >>>>> psycopg2.OperationalError: FATAL: password authentication failed for >>>>> user "postgres" >>>>> FATAL: password authentication failed for user "postgres" >>>>> >>>>> Traceback (most recent call last): >>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>> line 619, in _cleanup >>>>> connection = get_db_server(database["server_id"]) >>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>> line 593, in get_db_server >>>>> db_name, username, db_password, host, db_port, ssl_mode >>>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>>> line 36, in get_db_connection >>>>> sslmode=sslmode >>>>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>>>> line 130, in connect >>>>> conn = _connect(dsn, connection_factory=connection_factory, >>>>> **kwasync) >>>>> OperationalError: FATAL: password authentication failed for user >>>>> "postgres" >>>>> FATAL: password authentication failed for user "postgres" >>>>> >>>>> I have no password authentication errors when I am connecting from the >>>>> application.I had also changed password for postgres manually through the >>>>> command line. >>>>> >>>> >>>> >>> >> >> > --089e0825e388cdb35f0567fe0c6d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Although I have postgresql-9.6 it is showing-Running the test cases for 'PostgreSQL 9.4'=


On Thu, Mar 22, 2018 at 4:17 PM, Rahul Soshte <rahuls= oshte360@gmail.com> wrote:
=
Although I have postgresql-9.6 it is showing
--
--
Running the test cases for 'PostgreSQL 9.4'
<= /span>

On Thu, Mar 22, 2018 at 4:01 PM, Rahul S= oshte <rahulsoshte360@gmail.com> wrote:

---------- Forwarded message ----------
From: Rahul Soshte <rahulsoshte360@gmail.com>Date: Thu, Mar 22, 2018 at 4:01 PM
Subject: Re: Little patch for Runtim= e build from Top Level Directory($PGADMIN_SRC) MakeFile
To: Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com>


I am still getting the same error even when I did SERVER_MODE =3D = False.

On Thu, Mar 22, 2018 at 3= :05 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprised<= wbr>b.com> wrote:
You ne= ed to make SERVER_MODE = =3D False in config_local.py in order to run feature tests.

--
Regards,
Murtuza Zabuawala
Enterpri= seDB:=C2=A0http://www.enterprisedb.com
The Enterprise Postgr= eSQL Company


On Thu, Mar 22, 2018 at 3:00 PM, Rahul Sosht= e <rahulsoshte360@gmail.com> wrote:
how do I resolve those errors in step 4 = of the checklist?


On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte <rahuls= oshte360@gmail.com> wrote:
=
This is my first time trying to make a= Patch.

I am using Ubuntu 17.10.

This patch is in refer= ence to the Feature Added by Dave Page
https://redmine.postgresql.org/issues/1305

I just added code to call makefile in runtim= e directory( $PGADMIN_SRC/runtime/Makefile ) from the top level directory&#= 39;s MakeFile=C2=A0 ( $PGADMIN_SRC/Makefile )


I foll= owed the checklist for submitting a patch sent by Murutuza Zabuawala

<= ;=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D>
Hello,

Here i= s the common checklist to follow before sending patch to pgAdmin4-ha= ckers group,

1) Get the latest pull from master branch.

2) Apply your patch and c= heck if applies successfully on the latest code.

3) Check for PEP8 issues
- activa= te virtual env
- cd ../web
- yarn= run pep8

4) Run regression t= est
python regression/runtests.py=C2=A0
<= div style=3D"font-size:small;font-style:normal;font-variant-ligatures:norma= l;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align= :start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:= 0px;text-decoration-style:initial;text-decoration-color:initial;font-family= :verdana,sans-serif;color:rgb(68,68,68)">
- To run only UI/feature tests
python regression/runtests.py --pkg = feature_tests=C2=A0
<= span style=3D"background-color:rgb(243,243,243)">
- To r= un regression test (without UI/Feature tests)
python regression/runtests.py --exclude feature_tests=C2= =A0

5) Run Jasmine tests
- activate virt= ual env
- cd ../web
yarn run=C2=A0test:karma= -once

6) Make sure to add or update help docs a= nd screenshot(s) if you have added any new=C2=A0feature=C2=A0or changed any existing one.

=
--
Regards,
Murtuza Zabu= awala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The = Enterprise PostgreSQL Company
<=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>=

But I am facing some issues,
=
Step 1,2,3 and 5 had no issues
But when I tried st= ep 4 it gave some errors
I executed the following command
= =C2=A0
python r= egression/runtests.py=C2=A0

I got the follow= ing errors:
1)The screenshot attached show I wasnt able to co= nnect to the server
2) the error ouput on the command line:=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the test cases for 'Po= stgreSQL 9.4'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Traceback (most= recent call last):
=C2=A0 File "/var/www/flask/pgadmin4/pgadm= in4/web/regression/python_test_utils/test_utils.py", line 128, in= create_database
=C2=A0=C2=A0=C2=A0 server['sslmode']
=C2=A0 = File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test= _utils/test_utils.py", line 36, in get_db_connection
=C2=A0=C2= =A0=C2=A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/flask/pgadmin4/lo= cal/lib/python2.7/site-packages/psycopg2/__init__.py", line = 130, in connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_fac= tory=3Dconnection_factory, **kwasync)
OperationalError: FATAL:=C2= =A0 password authentication failed for user "postgres"
FATAL:= =C2=A0 password authentication failed for user "postgres"

= Traceback (most recent call last):
=C2=A0 File "regression/runtests= .py", line 350, in <module>
=C2=A0=C2=A0=C2=A0 server_informa= tion =3D test_utils.create_parent_server_node(server)
=C2=A0 File &= quot;/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_= utils/test_utils.py", line 491, in create_parent_server_node
=C2=A0= =C2=A0=C2=A0 server_info['sslmode']
=C2=A0 File "/var/www/f= lask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_util= s.py", line 36, in get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Ds= slmode
=C2=A0 File "/var/www/flask/pgadmin4/local/lib/python2.= 7/site-packages/psycopg2/__init__.py", line 130, in connect
= =C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory=3Dconnection_<= wbr>factory, **kwasync)
psycopg2.OperationalError: FATAL:=C2=A0 password= authentication failed for user "postgres"
FATAL:=C2=A0 passwo= rd authentication failed for user "postgres"

Traceback (mo= st recent call last):
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", line 619, = in _cleanup
=C2=A0=C2=A0=C2=A0 connection =3D get_db_server(database[&qu= ot;server_id"])
=C2=A0 File "/var/www/flask/pgadmin4/pgad= min4/web/regression/python_test_utils/test_utils.py", line 5= 93, in get_db_server
=C2=A0=C2=A0=C2=A0 db_name, username, db_password, = host, db_port, ssl_mode
=C2=A0 File "/var/www/flask/pgadmin4/pgadm<= wbr>in4/web/regression/python_test_utils/test_utils.py", line 36,= in get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2=A0 Fil= e "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", line 130, in connect
=C2=A0=C2=A0=C2=A0 con= n =3D _connect(dsn, connection_factory=3Dconnection_factory, **kwasync= )
OperationalError: FATAL:=C2=A0 password authentication failed for user= "postgres"
FATAL:=C2=A0 password authentication failed for us= er "postgres"

I have no password authentication= errors when I am connecting from the application.I had also changed passwo= rd for postgres manually through the command line.






--089e0825e388cdb35f0567fe0c6d--