Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyxl9-0006GI-Vs for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 10:47:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyxl8-0001v9-Qf for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 10:47:50 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyxl8-0001uz-4p for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 10:47:50 +0000 Received: from mail-it0-x244.google.com ([2607:f8b0:4001:c0b::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyxl5-0000wS-40 for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 10:47:48 +0000 Received: by mail-it0-x244.google.com with SMTP id e98-v6so10534696itd.4 for ; Thu, 22 Mar 2018 03:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=LbUrUI/d3yepDvO3NEdWcjsroUiUus2Mfyh1HoFqffg=; b=LRh2Po3HzSjU2f9sENFfc41XOO6/mFQA4Q6rFP8uvcMz+hvmOKRlHISeZjxi4v2eV8 FfsO6z+zGJpVretfZvLONnFqw7ni8WgwvUVf1sF9R6Pn+udlLBqmDjy5TNDz9jRmJic5 RV+pN0Q1OF1wonjB8/rljtF9lV/jxcXFuLx5zAG5w3tpiQLD7MuYi4ulUeIjgxYbMikV lMqXjPEhABhlKqgBo4FmcpvziQjIuUQnydoNFTrxy0v5xAugzRDk6R3ylZ7Dt+e1/A39 RHTq21lteqNByMkdlcxrwi/WRo+EQl8/9OX7sAI0vzOdJ25KG381wLyTUDrZEMc4COdj czpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=LbUrUI/d3yepDvO3NEdWcjsroUiUus2Mfyh1HoFqffg=; b=VAzzF3MeW1EMMZz55Q4IUhsOF5Nz2G46WtCdHkklei1iTlBfQp9YPKikD5oidxOE59 iUBCRYyZ1twwKo6in2tA/Hz5bE5036xNXeRvcu/GMgQTxqB304k2dB5CSowanWElsEmv Jxz6QT42IhAg3N55HXVrwsGMI99y6bltnkUVTPSSrdmJS9ooxpicFPnrI7nH8hiDdNyx kH33cHnoPaEW+tfX7LeHS8nfESYOekE9oQC9UgtQKSihV5abn33NqDxIlSQrKPH6KJl/ PtEIwg1rt2ph9R/m35RK5NqepqoKeNn9ZNlIInhXlaft8dkkqdzQO04r/aKe1Pi1LoU/ Yi6w== X-Gm-Message-State: AElRT7FZmQmNYwspnMBdytHXlXALLTDtnHS7rX8WuniOhXdfNbSiMNdF lDEfo0P47tlpisFCbIhckdNPj4N0klB29jdZwjgSeoqQ X-Google-Smtp-Source: AG47ELvLF+4AO5a9Np3U2teQQfPbLJfqwRfaCBSlmwqgFECQgAeIsSIUTplMGtE/ziKAQSAibKeqQpAxT2uqqJqla+E= X-Received: by 2002:a24:62c5:: with SMTP id d188-v6mr7762658itc.5.1521715665828; Thu, 22 Mar 2018 03:47:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.26.212 with HTTP; Thu, 22 Mar 2018 03:47:45 -0700 (PDT) In-Reply-To: References: From: Rahul Soshte Date: Thu, 22 Mar 2018 16:17:45 +0530 Message-ID: Subject: Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: pgadmin-hackers@postgresql.org, Murtuza Zabuawala Content-Type: multipart/alternative; boundary="000000000000b601bf0567fe0914" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b601bf0567fe0914 Content-Type: text/plain; charset="UTF-8" Although I have postgresql-9.6 it is showing -- -- Running the test cases for 'PostgreSQL 9.4' On Thu, Mar 22, 2018 at 4:01 PM, Rahul Soshte wrote: > > ---------- Forwarded message ---------- > From: Rahul Soshte > Date: Thu, Mar 22, 2018 at 4:01 PM > Subject: Re: Little patch for Runtime build from Top Level > Directory($PGADMIN_SRC) MakeFile > To: Murtuza Zabuawala > > > I am still getting the same error even when I did SERVER_MODE = False. > > On Thu, Mar 22, 2018 at 3:05 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> You need to make SERVER_MODE = False in config_local.py in order to run >> feature tests. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Thu, Mar 22, 2018 at 3:00 PM, Rahul Soshte >> wrote: >> >>> how do I resolve those errors in step 4 of the checklist? >>> >>> >>> On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte >>> wrote: >>> >>>> This is my first time trying to make a Patch. >>>> >>>> I am using Ubuntu 17.10. >>>> >>>> This patch is in reference to the Feature Added by Dave Page >>>> https://redmine.postgresql.org/issues/1305 >>>> >>>> I just added code to call makefile in runtime directory( >>>> $PGADMIN_SRC/runtime/Makefile ) from the top level directory's MakeFile ( >>>> $PGADMIN_SRC/Makefile ) >>>> >>>> >>>> I followed the checklist for submitting a patch sent by Murutuza >>>> Zabuawala >>>> >>>> <================================> >>>> Hello, >>>> >>>> Here is the common checklist to follow before sending patch to >>>> pgAdmin4-hackers group, >>>> >>>> 1) Get the latest pull from master branch. >>>> >>>> 2) Apply your patch and check if applies successfully on the latest >>>> code. >>>> >>>> 3) Check for PEP8 issues >>>> - activate virtual env >>>> - cd ../web >>>> - yarn run pep8 >>>> >>>> 4) Run regression test >>>> python regression/runtests.py >>>> >>>> - To run only UI/feature tests >>>> python regression/runtests.py --pkg feature_tests >>>> >>>> - To run regression test (without UI/Feature tests) >>>> python regression/runtests.py --exclude feature_tests >>>> >>>> 5) Run Jasmine tests >>>> - activate virtual env >>>> - cd ../web >>>> yarn run test:karma-once >>>> >>>> 6) Make sure to add or update help docs and screenshot(s) if you have >>>> added any new feature or changed any existing one. >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> <===================================================> >>>> >>>> But I am facing some issues, >>>> Step 1,2,3 and 5 had no issues >>>> But when I tried step 4 it gave some errors >>>> I executed the following command >>>> >>>> *python regression/runtests.py * >>>> >>>> I got the following errors: >>>> 1)The screenshot attached show I wasnt able to connect to the server >>>> 2) the error ouput on the command line: >>>> =============Running the test cases for 'PostgreSQL 9.4'============= >>>> Traceback (most recent call last): >>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>> line 128, in create_database >>>> server['sslmode'] >>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>> line 36, in get_db_connection >>>> sslmode=sslmode >>>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>>> line 130, in connect >>>> conn = _connect(dsn, connection_factory=connection_factory, >>>> **kwasync) >>>> OperationalError: FATAL: password authentication failed for user >>>> "postgres" >>>> FATAL: password authentication failed for user "postgres" >>>> >>>> Traceback (most recent call last): >>>> File "regression/runtests.py", line 350, in >>>> server_information = test_utils.create_parent_server_node(server) >>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>> line 491, in create_parent_server_node >>>> server_info['sslmode'] >>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>> line 36, in get_db_connection >>>> sslmode=sslmode >>>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>>> line 130, in connect >>>> conn = _connect(dsn, connection_factory=connection_factory, >>>> **kwasync) >>>> psycopg2.OperationalError: FATAL: password authentication failed for >>>> user "postgres" >>>> FATAL: password authentication failed for user "postgres" >>>> >>>> Traceback (most recent call last): >>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>> line 619, in _cleanup >>>> connection = get_db_server(database["server_id"]) >>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>> line 593, in get_db_server >>>> db_name, username, db_password, host, db_port, ssl_mode >>>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>>> line 36, in get_db_connection >>>> sslmode=sslmode >>>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>>> line 130, in connect >>>> conn = _connect(dsn, connection_factory=connection_factory, >>>> **kwasync) >>>> OperationalError: FATAL: password authentication failed for user >>>> "postgres" >>>> FATAL: password authentication failed for user "postgres" >>>> >>>> I have no password authentication errors when I am connecting from the >>>> application.I had also changed password for postgres manually through the >>>> command line. >>>> >>> >>> >> > > --000000000000b601bf0567fe0914 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Although I have postgresql-9.6 it is showing
--
--Running the test cases for 'PostgreSQL 9.4'

On Thu, Mar 22, 2018 at 4:0= 1 PM, Rahul Soshte <rahulsoshte360@gmail.com> wrote:<= br>
<= div dir=3D"ltr">
---------- Forwarded message= ----------
From: Rahul Soshte <rahulsoshte360@gmail.com>
Date: Thu, Mar 22, 2018 at 4:0= 1 PM
Subject: Re: Little patch for Runtime build from Top Level Director= y($PGADMIN_SRC) MakeFile
To: Murtuza Zabuawala <murtuza.zabuawala@e= nterprisedb.com>


I am still getting the = same error even when I did SERVER_MODE =3D False.

On Thu, Mar 22, 2018 at 3:= 05 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
You ne= ed to make SERVER_MODE = =3D False in config_local.py in order to run feature tests.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://= www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Mar 22, 2018 at 3:00 PM, Rahul Sosht= e <rahulsoshte360@gmail.com> wrote:
how do I resolve those errors in step 4 = of the checklist?


On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte <rahuls= oshte360@gmail.com> wrote:
=
This is my first time trying to make a= Patch.

I am using Ubuntu 17.10.

This patch is in refer= ence to the Feature Added by Dave Page
https://redmine.postgresql.org/issues/1305

I just added code to call makefile in runtim= e directory( $PGADMIN_SRC/runtime/Makefile ) from the top level directory&#= 39;s MakeFile=C2=A0 ( $PGADMIN_SRC/Makefile )


I foll= owed the checklist for submitting a patch sent by Murutuza Zabuawala

<= ;=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D>
Hello,

Here i= s the common checklist to follow before sending patch to pgAdmin4-ha= ckers group,

1) Get the latest pull from master branch.

2) Apply your patch and c= heck if applies successfully on the latest code.

3) Check for PEP8 issues
- activa= te virtual env
- cd ../web
- yarn= run pep8

4) Run regression t= est
python regression/runtests.py=C2=A0
<= div style=3D"font-size:small;font-style:normal;font-variant-ligatures:norma= l;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align= :start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:= 0px;text-decoration-style:initial;text-decoration-color:initial;font-family= :verdana,sans-serif;color:rgb(68,68,68)">
- To run only UI/feature tests
python regression/runtests.py --pkg = feature_tests=C2=A0
<= span style=3D"background-color:rgb(243,243,243)">
- To r= un regression test (without UI/Feature tests)
python regression/runtests.py --exclude feature_tests=C2= =A0

5) Run Jasmine tests
- activate virtual env
- cd ../web
yarn run=C2=A0test:karma-once

6) Make sure to add or update help docs and screenshot(s) if = you have added any new=C2=A0feature=C2=A0or changed any existing one.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.= enterprisedb.com
The Enterprise PostgreSQL Company
<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>
But I am facing some issues,
Step 1,2,3 and 5 had no issues=
But when I tried step 4 it gave some errors
I = executed the following command
=C2=A0
python regression/runtests.py=C2=A0
I got the following errors:
1)The screensho= t attached show I wasnt able to connect to the server
2) the = error ouput on the command line:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= Running the test cases for 'PostgreSQL 9.4'=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D
Traceback (most recent call last):
=C2=A0 File "= /var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils= /test_utils.py", line 128, in create_database
=C2=A0=C2=A0=C2=A0 se= rver['sslmode']
=C2=A0 File "/var/www/flask/pgadmin4/pgadm<= wbr>in4/web/regression/python_test_utils/test_utils.py", line 36,= in get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2=A0 Fil= e "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", line 130, in connect
=C2=A0=C2=A0=C2=A0 con= n =3D _connect(dsn, connection_factory=3Dconnection_factory, **kwasync= )
OperationalError: FATAL:=C2=A0 password authentication failed for user= "postgres"
FATAL:=C2=A0 password authentication failed for us= er "postgres"

Traceback (most recent call last):
=C2=A0= File "regression/runtests.py", line 350, in <module>
= =C2=A0=C2=A0=C2=A0 server_information =3D test_utils.create_parent_server_node(server)
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4= /web/regression/python_test_utils/test_utils.py", line 491, in cr= eate_parent_server_node
=C2=A0=C2=A0=C2=A0 server_info['sslmode'= ]
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/regression= /python_test_utils/test_utils.py", line 36, in get_db_connection<= br>=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/flask= /pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py&= quot;, line 130, in connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, co= nnection_factory=3Dconnection_factory, **kwasync)
psycopg2.Operatio= nalError: FATAL:=C2=A0 password authentication failed for user "postgr= es"
FATAL:=C2=A0 password authentication failed for user "post= gres"

Traceback (most recent call last):
=C2=A0 File "/= var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/= test_utils.py", line 619, in _cleanup
=C2=A0=C2=A0=C2=A0 connection= =3D get_db_server(database["server_id"])
=C2=A0 File &qu= ot;/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_ut= ils/test_utils.py", line 593, in get_db_server
=C2=A0=C2=A0=C2=A0 d= b_name, username, db_password, host, db_port, ssl_mode
=C2=A0 File "= ;/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_util= s/test_utils.py", line 36, in get_db_connection
=C2=A0=C2=A0=C2=A0 = sslmode=3Dsslmode
=C2=A0 File "/var/www/flask/pgadmin4/local/l= ib/python2.7/site-packages/psycopg2/__init__.py", line 130, in co= nnect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_factory=3Dcon= nection_factory, **kwasync)
OperationalError: FATAL:=C2=A0 password= authentication failed for user "postgres"
FATAL:=C2=A0 passwo= rd authentication failed for user "postgres"

I = have no password authentication errors when I am connecting from the applic= ation.I had also changed password for postgres manually through the command= line.





--000000000000b601bf0567fe0914--