Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAv6D-0001ho-49 for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Aug 2020 13:04:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kAv6A-0001K6-OQ for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Aug 2020 13:04:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAv6A-0001Jy-HB for pgadmin-hackers@lists.postgresql.org; Wed, 26 Aug 2020 13:04:18 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kAv66-0000RB-L5 for pgadmin-hackers@postgresql.org; Wed, 26 Aug 2020 13:04:17 +0000 Received: by mail-ej1-x62c.google.com with SMTP id bo3so2708831ejb.11 for ; Wed, 26 Aug 2020 06:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S+tBWSEalwyb3EFQR0eM5iMsi7/lT09OPV1lklTJjJc=; b=AVf4hlEVAoWxLbA5U2nI7JuqgVlaIYfU1cHL3defLH4qqYUuUWGTaP1nnykWFsnocF WKFkZ/S/mQYOHDDmHaB5neR8fE1CxjNkexl5pBIu0R5ahSVLvm8dQQMP74oX4Q+qV6Pp JqYmnG1lN7CF0msWdzCnDfooIy0uNfFl0asa0AbQCJQtvbq7EhFczt2bBmsckpmSKBTm yAJi0/WtYNsUuQtWbUGS4LR1pBTEZURDLcztL+Amm5bBQ4dUsCO37hO8NG6gDNjCr6z1 RKBS6QwY5tP0TJeWbXl2WZCVmK7CQRoAuNKJDac93GA9Ttso2+skchXIJ8X6V3ZPJS0c GRHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S+tBWSEalwyb3EFQR0eM5iMsi7/lT09OPV1lklTJjJc=; b=YmzZTftY1V//XhhspKqM40wxSv4oWm0r78IaHcob+UzKH8AxSjM73UjkTWtU60ACcH 8nP2ShMPZn5uSbKpAeK0q2xNof6f+3fiiUl7j+SwhSPXJ37+/lIaxroPxczJdNMEG+Yr scLG28N+QmBF+j4aVbaxjgHnubE9BbWZCLdhwHIFvJ/Bv2BnI/RaHsf2gmcEQgNHn7Hi m3wH6SzX3muDHOLU0hQr7AeaRqc140ltEX6WbzXUD/4Nbw9VY11ieXyxZrascHCpfmlB 1CEIkVn+yeyfY030tFHpAgqg7Tm5DOcvaqg94krHHx5Wsls9yQ3eD7d33dEze30BMayZ Pujg== X-Gm-Message-State: AOAM530V7RL7pIPLvdzM3V+vm9l2is7WarAu6/Gldv83WWkxG6SEf03a F4EcKJhEuAiIzLuT3wT12Yk99kQstrkLvzHlt6MhC8w9n1+AzkohD7NrtjXEj9Ut0EilEZ6cRon BCez3fzPOYM6gH1qB3nI1iMQ9JHV0Qt2A3OCokC5O+/32I5zqC0dEkE937UjWN9dOEOoc11Ojdv S2WNgQZaLKBg/Cbg6ElQUNWLYXC6OX7Me8RdCjk68+jSjpy1h2erBgyr+cvQ== X-Google-Smtp-Source: ABdhPJxe1T5ievOT4JkE0kiHRdJgAq8aVo9AH7LuOB76vR9w7gMiGaoLz/UQym6qiQZiC8KkYN0kOXswBvmZyVMkI/0= X-Received: by 2002:a17:906:440c:: with SMTP id x12mr15541838ejo.293.1598447053139; Wed, 26 Aug 2020 06:04:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aradhana Birewar Date: Wed, 26 Aug 2020 18:34:02 +0530 Message-ID: Subject: Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website To: Nikhil Mohite Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000cb8cea05adc77403" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000cb8cea05adc77403 Content-Type: text/plain; charset="UTF-8" Hi Nikhil, I was going through the style guide, I have a few observations that I would like to share with you. 1. In the Typography section, for font size text, the Roboto font is not getting applied. [image: image.png] 2. In the Dropdown section, the expanded dropdown image appears vertically stretched. [image: image.png] 3. Tabs for navigating between themes need small UI modifications, only selected tab should have medium font-weight (font-weight: 500), others have normal font-weight. (font-weight: 400) Also selected tab bottom border should be the same as text width. [image: image.png] [image: Screenshot 2020-08-26 at 5.58.47 PM.png] 4. In the Toggle Buttons section, the title should be Toggle On. [image: image.png] Everything else looks great. Thanks and Regards, Aradhana On Wed, Aug 26, 2020 at 4:06 PM Dave Page wrote: > Thanks, applied with a few changes for consistency in the titles and 404 > handling. > > On Wed, Aug 26, 2020 at 8:23 AM Nikhil Mohite < > nikhil.mohite@enterprisedb.com> wrote: > >> Hi Dave/Team, >> >> Updated the implementation for the set title of the page, for this, I >> have done a few changes in the flow. >> 1. Earlier we are using {% include %} for showing pages in the base >> page (styleguide/index.html) for a style guide but in the Django template >> we can't use {% block %} statement if we are adding page using "{% include >> %}". >> 2. To overcome this issue now using {% extends %} instead of {% include >> %}, For this added dynamic URL generation in views so instead of loading >> "index.html" of style guide we are loading specific component HTML file >> (e.g: typography.html) and that template extends the "index.html" of the >> style guide. >> >> PFA v6 patch for the same. >> >> If required any changes please let me know. >> >> Regards, >> Nikhil Mohite. >> >> >> On Tue, Aug 25, 2020 at 7:09 PM Dave Page wrote: >> >>> Hi >>> >>> On Tue, Aug 25, 2020 at 12:49 PM Nikhil Mohite < >>> nikhil.mohite@enterprisedb.com> wrote: >>> >>>> >>>> PFA v5 patch for the same. >>>> >>>> if required any updates in this please let me know. >>>> >>> >>> Hmm, yeah - that doesn't work for me I'm afraid; it's mixing content >>> with code. >>> >>> The titles should be defined in the HTML pages themselves. We do that >>> everywhere else by including a template block like the following in the >>> lowest level content: >>> >>> {% block title %}Contributing{% endblock %} >>> >>> And then in base.html: >>> >>> {% block title %}{% endblock %} >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EDB: http://www.enterprisedb.com >>> >>> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > --000000000000cb8cea05adc77403 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Nikhil,

I was going through the= style guide, I have a few observations that I would like to share with you= .
  1. In the Typography section, for font size text, the Robo= to font is not getting applied.

    3D"image.png"

  2. In the= Dropdown section, the expanded dropdown image appears=C2=A0vertically stre= tched.

    3D"image.png"

  3. Tabs for navigating between=C2= =A0themes need small UI modifications, only selected tab should have medium= font-weight (font-weight: 500), others have normal font-weight.
    (font-= weight: 400) Also selected tab bottom border should be the same as text wid= th.

    3D"image.png"
    3D"Screenshot

  4. In the= Toggle Buttons section, the=C2=A0title should be Toggle On.


Everything else looks great.=C2=A0

Thanks = and Regards,
Aradhana
<= br>
On Wed,= Aug 26, 2020 at 4:06 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied with a few changes for c= onsistency in the titles and 404 handling.

On Wed, Aug 26, 2020 at 8:23 AM N= ikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Dave/Team,
Updated the implementation for the set title of the page, = for this, I have done a few changes in the flow.
1. Earlier we ar= e using {% include %} for showing pages in the base page=C2=A0(styleguide/i= ndex.html) for a style guide but in the Django template we can't use {%= block %} statement if we are adding page using "{% include %}".<= /div>
2. To overcome this issue now using {% extends %} instead of=C2= =A0 {% include %},=C2=A0 For this added dynamic URL generation in views so = instead of loading "index.html" of style guide we are loading spe= cific component HTML file (e.g: typography.html) and that template extends = the "index.html" of the style guide.

PFA= v6 patch for the same.

If required any changes pl= ease let me know.

Regards,
Nikhil Mohite= .


On Tue, Aug 25, 2020 at 7:09 PM Dave Page <dpage@pgadmin.org> w= rote:
Hi

On Tue, Aug 25, 2020 at 12:49 PM Nikhil Mohit= e <n= ikhil.mohite@enterprisedb.com> wrote:

PFA v5 patch for the same.

if re= quired any updates in this please let me know.

Hmm, yeah - that doesn't work for me I'm afra= id; it's mixing content with code.

The titles = should be defined in the HTML pages themselves. We do that everywhere else = by including a template block like the following in the lowest level conten= t:

{% block title %}Contributing{% endblock %}

And then in base.html:

<t= itle>{% block title %}{% endblock %}</title>
<= br>
--


--
--000000000000cb8cea05adc77403--