public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: Busy icon not visible in Debugger and Query tool in Runtime environment
Date: Fri, 8 Jul 2016 13:00:31 +0530
Message-ID: <CAM5-9D-4dh13eLjotiqNLB2hczYmpc2iU6UsC8a8Hn8BA4ES5g@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

The spinner icon is not visible while executing query or running debugger
in Runtime environment specific to Ubuntu. This issue is related to RM#1186

To make it work, we need to explicitly set *-webkit-animation* property to
'none' for classes "sql-editor-busy-icon.fa-pulse" and ".debugger-container
fa-pulse".

'fa-pulse' class is responsible to spin the busy icon, but setting its*
-webkit-animation* property to none will not spin icon but icon and message
will be shown.

Please review

Thanks,
Surinder Kumar


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] busy_icon_fix_debugger_query_tool.patch (1.2K, 3-busy_icon_fix_debugger_query_tool.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/datagrid/templates/datagrid/index.html b/web/pgadmin/tools/datagrid/templates/datagrid/index.html
index b138a46..f2f6085 100644
--- a/web/pgadmin/tools/datagrid/templates/datagrid/index.html
+++ b/web/pgadmin/tools/datagrid/templates/datagrid/index.html
@@ -11,6 +11,7 @@
     .alertify-notifier{-webkit-transform: none;}
     .alertify-notifier .ajs-message{-webkit-transform: none;}
     .alertify .ajs-dialog.ajs-shake{-webkit-animation-name: none;}
+    .sql-editor-busy-icon.fa-pulse{-webkit-animation: none;}
     {% endif %}
 </style>
 <div id="main-editor_panel">
diff --git a/web/pgadmin/tools/debugger/templates/debugger/direct.html b/web/pgadmin/tools/debugger/templates/debugger/direct.html
index 5448313..297c362 100644
--- a/web/pgadmin/tools/debugger/templates/debugger/direct.html
+++ b/web/pgadmin/tools/debugger/templates/debugger/direct.html
@@ -24,6 +24,7 @@ console.log(err);
     .alertify-notifier{-webkit-transform: none;}
     .alertify-notifier .ajs-message{-webkit-transform: none;}
     .alertify .ajs-dialog.ajs-shake{-webkit-animation-name: none;}
+    .debugger-container .wcLoadingIcon.fa-pulse{-webkit-animation: none;}
 </style>
 {% endif %}
 <nav class="navbar-inverse navbar-fixed-top">

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: Busy icon not visible in Debugger and Query tool in Runtime environment
  In-Reply-To: <CAM5-9D-4dh13eLjotiqNLB2hczYmpc2iU6UsC8a8Hn8BA4ES5g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox