public inbox for [email protected]
help / color / mirror / Atom feedFrom: Surinder Kumar <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character
Date: Tue, 12 Jul 2016 15:57:19 +0530
Message-ID: <CAM5-9D-EiK+pXzOCXq2afm+_QbtC7oU+pQcfA14O8R6ckoGmmw@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D8cyNM2uHikSaqSxcSwk3Sy0yve9oeyx9mhpm541g6ZbA@mail.gmail.com>
References: <CAM5-9D80C1BH7xENfmrzjo+RS_=N1ijBx7chvDykBUtarSUfrA@mail.gmail.com>
<CAKKotZTQt4+2SB-prG2YtMy+5pVdG+Jj1O1ysKSBDoqcHhstEQ@mail.gmail.com>
<CAM5-9D8cyNM2uHikSaqSxcSwk3Sy0yve9oeyx9mhpm541g6ZbA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On Tue, Jul 12, 2016 at 3:48 PM, Surinder Kumar <
[email protected]> wrote:
> On Tue, Jul 12, 2016 at 3:43 PM, Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> Just a heads up, This issue is occurs only in runtime & If you try in web
>> everything works fine when you provide unicode characters as object name.
>>
> No, this issue is reported for both web and runtime application. It is
> reproducible to me in web application.
>
It is reproducible for me on
Mac OS X Yosemite version 10.10.2
Python version: 2.7
Browsers: Chrome & Firefox.
>
>> Now sure but the issue is when runtime(QtWebkit) sends data it does not
>> encodes it properly & this should be generic fix in runtime.
>>
>> Regards,
>> Murtuza
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Tue, Jul 12, 2016 at 3:27 PM, Surinder Kumar <
>> [email protected]> wrote:
>>
>>> Hi
>>>
>>> *What is happening in code?*
>>> Database is created with Chinese characters successfully with ascii
>>> values(Chinese characters converted to ascii) before saving internally.
>>>
>>> but when database properties is retrieved by name, it fails to fetch
>>> data and throws UnicodeError.
>>>
>>> *Solution:*
>>> Database name should be encoded in 'utf-8' before storing to database.
>>> This resolved the issue.
>>> I have tested this patch by creating database name using Japanese and
>>> Chinese characters. It works.
>>>
>>> Also referenced the code to *set default encoding to 'uff-8' *before
>>> start of application.
>>> https://github.com/joeyespo/grip/issues/86
>>>
>>> @Ashesh/@Dave can you please review the patch?
>>> If it looks good, we can do the same changes in case of other nodes.
>>>
>>> Thanks,
>>> Surinder Kumar
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list ([email protected])
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character
In-Reply-To: <CAM5-9D-EiK+pXzOCXq2afm+_QbtC7oU+pQcfA14O8R6ckoGmmw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox